Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4300

Medium-size icons still blue

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Not A Defect
    • Component/s: greenballs-plugin
    • Labels:
      None
    • Environment:
      Platform: All, OS: All
    • Similar Issues:

      Description

      The Hudson Dashboard allows the user to toggle between small (16x16), medium
      (24x24), and large (32x32) icons. The small and large icons are green, but the
      medium icons are still blue with this plugin enabled.

        Attachments

          Activity

          Hide
          asgeirn asgeirn added a comment -

          Strange. Could you provide some details of what browser/s you have tested this
          on?

          Does the /legend page show the correct icons?

          Since the plugin does HTTP 302 trickery the blue icons might have been cached by
          your browser. Could you try clearing the browser cache?

          Show
          asgeirn asgeirn added a comment - Strange. Could you provide some details of what browser/s you have tested this on? Does the /legend page show the correct icons? Since the plugin does HTTP 302 trickery the blue icons might have been cached by your browser. Could you try clearing the browser cache?
          Hide
          malfunction84 Mark Lewis added a comment -

          It was a caching issue. Clearing the cache did the trick. Thanks, and sorry
          for not trying that first.

          Show
          malfunction84 Mark Lewis added a comment - It was a caching issue. Clearing the cache did the trick. Thanks, and sorry for not trying that first.
          Hide
          pjdarton pjdarton added a comment - - edited

          Not convinced that this is a browser-caching issue.

          Setup:

          • Hudson 1.352 (on Ubuntu-64, installed using apt-get install),
          • IE8 & Firefox 3.6 (on Vista-32)

          I installed hudson & got it running using Firefox, including installing the greenballs plugin.
          The following day, I opened up the web-UI using IE8 and found that whilst large & small balls were green, medium ones were blue. I then checked using Firefox and found that this showed the same.
          As IE had never previously been run (I don't normally use IE) before the greenballs plugin was run, it couldn't have obtained incorrect data from before the plugin was installed.
          The fact that small and large balls worked fine but medium ones are still blue suggests to me that there's something different about medium ones.

          However, with firefox showing medium balls, I then told Firefox to completely refresh the page by pressing ctrl-F5.
          This caused the (medium) balls to change from blue to green.
          Furtherfore, when I then told IE to change to small icons and back to medium (and NOT pressing Ctrl-F5 at all), IE also showed the balls as green.
          i.e. IE8 changed what it was showing as a result of server-side changes.

          So, I think it might well be caching, but it's server-side, not within the browser.
          Maybe there's some caching going on within the servlet code that calls Hudson? Maybe the date/times of the icons aren't set right and this is confusing that servlet code?

          Show
          pjdarton pjdarton added a comment - - edited Not convinced that this is a browser-caching issue. Setup: Hudson 1.352 (on Ubuntu-64, installed using apt-get install), IE8 & Firefox 3.6 (on Vista-32) I installed hudson & got it running using Firefox, including installing the greenballs plugin. The following day, I opened up the web-UI using IE8 and found that whilst large & small balls were green, medium ones were blue. I then checked using Firefox and found that this showed the same. As IE had never previously been run (I don't normally use IE) before the greenballs plugin was run, it couldn't have obtained incorrect data from before the plugin was installed. The fact that small and large balls worked fine but medium ones are still blue suggests to me that there's something different about medium ones. However, with firefox showing medium balls, I then told Firefox to completely refresh the page by pressing ctrl-F5. This caused the (medium) balls to change from blue to green. Furtherfore, when I then told IE to change to small icons and back to medium (and NOT pressing Ctrl-F5 at all), IE also showed the balls as green. i.e. IE8 changed what it was showing as a result of server-side changes. So, I think it might well be caching, but it's server-side, not within the browser. Maybe there's some caching going on within the servlet code that calls Hudson? Maybe the date/times of the icons aren't set right and this is confusing that servlet code?
          Hide
          asgeirn asgeirn added a comment -

          Weird. There is no special handling of medium sized icons compared to the other sizes.

          Just for kicks – could you try the attached version of the plugin? It logs all requests it handles on the logger hudson.plugins.greenballs.

          To capture these logging events you need to go into the logging configuration and configure a new logging destination, enabling all levels. Go to http://HUDSON:8080/log/new and add the logger hudson.plugin.greenballs for all levels.

          Show
          asgeirn asgeirn added a comment - Weird. There is no special handling of medium sized icons compared to the other sizes. Just for kicks – could you try the attached version of the plugin? It logs all requests it handles on the logger hudson.plugins.greenballs . To capture these logging events you need to go into the logging configuration and configure a new logging destination, enabling all levels. Go to http://HUDSON:8080/log/new and add the logger hudson.plugin.greenballs for all levels.
          Hide
          wgracelee wgracelee added a comment -

          Just upgraded to 1.6, and the ball on dashboard is blue. But the rest of them are green. My master machine is linux.

          Show
          wgracelee wgracelee added a comment - Just upgraded to 1.6, and the ball on dashboard is blue. But the rest of them are green. My master machine is linux.
          Hide
          asgeirn asgeirn added a comment -

          Such issues are quite often related to browser chaching, especially if you have been using Hudson without the plugin for a while.

          Clearing the browser cache should fix this.

          Show
          asgeirn asgeirn added a comment - Such issues are quite often related to browser chaching, especially if you have been using Hudson without the plugin for a while. Clearing the browser cache should fix this.
          Hide
          evernat evernat added a comment -

          closing this issue as not a defect, because it was only the client cache which was not up to date (and there was no response from the unconvinced user)

          Show
          evernat evernat added a comment - closing this issue as not a defect, because it was only the client cache which was not up to date (and there was no response from the unconvinced user)

            People

            Assignee:
            asgeirn asgeirn
            Reporter:
            malfunction84 Mark Lewis
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: