Details
-
Bug
-
Status: Closed (View Workflow)
-
Critical
-
Resolution: Fixed
-
None
-
Platform: All, OS: All
Description
Hudson 1.318, cppunit plugin 0.5.1:
Unintendedly, my output cppunit xml file suddenly contained an invalid character
in a message about a test failure.
This caused the plugin to crash with the attached exception dump, which again
meant that processing of this build failed, and I did not get an email saying
that the build failed (or was unstable). No mail is good news. I found out by
coincidence a while later that it wasn't so ...
I think the plugin should guard itself against all kinds of input errors, and
flag them as a Failed (or Unstable) build.
Attachments
Issue Links
- is duplicated by
-
-
- Closed
-
Activity
Gregory Boissinot
added a comment - I fixed the cppunit plugin. The build is set to unstable with a log message for
invalid XML files.
The correction is available in the trunk.
Have you got the opportunity to validate the behavior before I release this new
version?
Gregory Boissinot
added a comment - I fixed the cppunit plugin. The build is set to unstable with a log message for
invalid XML files.
The correction is available in the trunk.
Have you got the opportunity to validate the behavior before I release this new
version? 
torbent
added a comment - Sadly, no.
I can test the plugin before I put it on our production Hudson, but I'm not able
to build from trunk.
torbent
added a comment - Sadly, no.
I can test the plugin before I put it on our production Hudson, but I'm not able
to build from trunk. Gregory Boissinot
added a comment - Fixed with cppunit plugin 1.1 
First, I think you should do it the same way in CppUnit and xUnit (see issue 4317).
Second, the actual handling (fail/unstable) would make little difference to me,
as my build process would fail the build anyway. If you believe setting Unstable
(with an explicit message, I hope?) is better, then just do that.