Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43194

Lightweight checkout for PR merge jobs

    XMLWordPrintable

Details

    • Blue Ocean 1.4 - beta 2

    Description

      Please pull in the changes made to the SCM API to reduce the number of checkouts required for pipelines. Related to JENKINS-33273

       

      There was a mention in the referenced issue about PRs needing special treatment: "there is no implementation currently for github-branch-source-plugin in the case of a PR job configured to merge with the base branch, as GitHub does not offer an API dedicated to this purpose. In the case that the merge can be assumed to be a fast-forward (there is no base branch change subsequent to the common ancestor), this plugin could in principle load content via API from the PR branch; it would still need to fall back to full checkout and Git merge otherwise." - https://issues.jenkins-ci.org/browse/JENKINS-33273?focusedCommentId=292273#comment-292273

      Attachments

        Issue Links

          causes

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-57257 No commit found for SHA after updating github branch source plugin

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is duplicated by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-53988 skipDefaultCheckout not honored in Pull Requests

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Closed
          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-33273 Optimize Jenkinsfile loading and branch detection

          • Major - Major loss of function.
          • Resolved

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-50937 GitHub Multibranch PR: unclear error message for PR with merge conflicts

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-44729 Optimize git clones via shared reference repo for multi branch builds of same repository

          • Major - Major loss of function.
          • Open
          links to

          Web Link CloudBees Internal CD-341

          Web Link workflow-multibranch PR 69

          Activity

            Ascending order - Click to sort in descending order
            View 16 older comments
            bitwiseman Liam Newman added a comment - - edited

            jglick

            We cannot use merge_commit_sha from this plugin. Just forget it exists.

            Why? I need to understand why this is not possible. I don't need you to spoon feed it to me but I do need more information than you've provided.

            The suggestion that we should fail and make the user bring their PR up-to-date is an interesting one. I'll add that to the list of options.

            bitwiseman Liam Newman added a comment - - edited jglick We cannot use merge_commit_sha from this plugin. Just forget it exists. Why? I need to understand why this is not possible. I don't need you to spoon feed it to me but I do need more information than you've provided. The suggestion that we should fail and make the user bring their PR up-to-date is an interesting one. I'll add that to the list of options.
            bitwiseman Liam Newman added a comment -

            I've released a beta release of this change in v2.4.6-beta-1:

            This is not production ready but anyone wanting to test it and give feedback would be appreciated. It is on the experimental update site.
            Also: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-branch-source/2.4.6-beta-1/github-branch-source-2.4.6-beta-1.hpi

            bitwiseman Liam Newman added a comment - I've released a beta release of this change in v2.4.6-beta-1: This is not production ready but anyone wanting to test it and give feedback would be appreciated. It is on the experimental update site. Also: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/github-branch-source/2.4.6-beta-1/github-branch-source-2.4.6-beta-1.hpi
            bitwiseman Liam Newman added a comment -

            Released in v2.5.0.

            bitwiseman Liam Newman added a comment - Released in v2.5.0.
            silverorange James F. added a comment -

            I have been experiencing problems since the most recent update of this plugin to 2.5.0.  I'm running the latest Jenkins with all plugins updated.  After updating from 2.4.5 of this plugin to 2.5.0 my tests are failing with the following error.  As soon as I roll the plugin back to 2.4.5 the tests being passing again.  Anyone have any idea what might be causing this?

             

            Caused: org.kohsuke.github.GHFileNotFoundException:

            {"message":"No commit found for SHA: xxxxxxxxxxxxxxdc556f036","documentation_url":"[https://developer.github.com/v3/repos/commits/#get-a-single-commit]"}
            silverorange James F. added a comment - I have been experiencing problems since the most recent update of this plugin to 2.5.0.  I'm running the latest Jenkins with all plugins updated.  After updating from 2.4.5 of this plugin to 2.5.0 my tests are failing with the following error.  As soon as I roll the plugin back to 2.4.5 the tests being passing again.  Anyone have any idea what might be causing this?   Caused: org.kohsuke.github.GHFileNotFoundException: {"message":"No commit found for SHA: xxxxxxxxxxxxxxdc556f036","documentation_url":"[https://developer.github.com/v3/repos/commits/#get-a-single-commit]"}
            bitwiseman Liam Newman added a comment -

            silverorange
            Please open a new issue with more details including callstacks.
            As a work around please try closing and reopening the PR that is causing the failure.

            bitwiseman Liam Newman added a comment - silverorange Please open a new issue with more details including callstacks. As a work around please try closing and reopening the PR that is causing the failure.

            People

              bitwiseman Liam Newman
              maxpowa Max Gurela
              Votes:
              11 Vote for this issue
              Watchers:
              21 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: