Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43217

Closing pipeline results "modal" after clicking on a stage sets the url incorrectly to the previous URL, not activity

    XMLWordPrintable

Details

    • Blue Ocean 1.0-rc4, Blue Ocean - 1.1-beta-1

    Description

      Closing the modal results screen always closes it, but the URI sometimes has an incorrect path. The side effect of this is if you click on anywhere else, you get a full page reload. 

       

      To reproduce: 

      • Open a pipeline finished run - note the URI (call that URI A)
      • Click on any stage - note the URI changes with the stage id (call that URI B)
      • Close the modal
      • Note that screen shows activity (where you originally came from) BUT the URI == URI A
      • Click on branches/activity and note you get a page reload

      It should show /activity or wherever it came from. It shouldn't just go back on item in the history. 

       

      In Scope: 

      • Fix
      • Unit or ATH test to ensure that the close actually restores the correct URI

       

      Perhaps this is best done with a change - don't use path to set stage ids, use a query parameter, that way "back" will go back to the correct place. Or close needs to push the history to where it remembers it originally came from... I dunno. Maybe the 2nd amendment people can do something about that, I don't know. FAKE NEWS.

      Attachments

        Activity

          Ascending order - Click to sort in descending order
          View 5 older comments
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cliff Meyers
          Path:
          src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/55b26d530f10e21249fda2313532da7158ea0165
          Log:
          JENKINS-43217 make the steps more discrete

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js http://jenkins-ci.org/commit/blueocean-acceptance-test/55b26d530f10e21249fda2313532da7158ea0165 Log: JENKINS-43217 make the steps more discrete
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cliff Meyers
          Path:
          http://jenkins-ci.org/commit/blueocean-acceptance-test/fdcdaa4d9b0bad38a786455c97526dcc5d6aa64b
          Log:
          Merge branch 'master' into bug/JENKINS-43217-run-details-modal-madness

          Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/23e500a16a9a^...fdcdaa4d9b0b

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: http://jenkins-ci.org/commit/blueocean-acceptance-test/fdcdaa4d9b0bad38a786455c97526dcc5d6aa64b Log: Merge branch 'master' into bug/ JENKINS-43217 -run-details-modal-madness Compare: https://github.com/jenkinsci/blueocean-acceptance-test/compare/23e500a16a9a ^...fdcdaa4d9b0b
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cliff Meyers
          Path:
          src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/922c8bd3fdfb81bc6180be519d099b2203acca2f
          Log:
          JENKINS-43217 better description for last step

          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js http://jenkins-ci.org/commit/blueocean-acceptance-test/922c8bd3fdfb81bc6180be519d099b2203acca2f Log: JENKINS-43217 better description for last step
          cliffmeyers Cliff Meyers added a comment -

          PR's:

          https://github.com/jenkinsci/blueocean-plugin/pull/935
          https://github.com/jenkinsci/blueocean-acceptance-test/pull/133/files

          cliffmeyers Cliff Meyers added a comment - PR's: https://github.com/jenkinsci/blueocean-plugin/pull/935 https://github.com/jenkinsci/blueocean-acceptance-test/pull/133/files
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Cliff Meyers
          Path:
          src/main/js/page_objects/blueocean/bluePipelineRunDetail.js
          src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js
          http://jenkins-ci.org/commit/blueocean-acceptance-test/0354987e434201b6c485e5f1e1fe9fb799df546d
          Log:
          Bug/jenkins 43217 run details modal madness (#133)

          • JENKINS-43217 rewrite waitForLocationChange -> waitForLocationContains so it doesn't require the URL to actually change, as it could be brittle due to timing issues; rework "closeModal" page object command to just wait for the RunDetails-content element to go away; refactor the "runDetailsDeepLink" test to "runDetailsFallbackNavigation" and adjust to new API
          • JENKINS-43217 add a test case that ensures that navigating within run details and closing redirects back to the right URL
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Cliff Meyers Path: src/main/js/page_objects/blueocean/bluePipelineRunDetail.js src/test/js/runDetailsModal/runDetailsBackwardsNavigation.js http://jenkins-ci.org/commit/blueocean-acceptance-test/0354987e434201b6c485e5f1e1fe9fb799df546d Log: Bug/jenkins 43217 run details modal madness (#133) JENKINS-43217 rewrite waitForLocationChange -> waitForLocationContains so it doesn't require the URL to actually change, as it could be brittle due to timing issues; rework "closeModal" page object command to just wait for the RunDetails-content element to go away; refactor the "runDetailsDeepLink" test to "runDetailsFallbackNavigation" and adjust to new API JENKINS-43217 add a test case that ensures that navigating within run details and closing redirects back to the right URL JENKINS-43217 make the steps more discrete JENKINS-43217 better description for last step

          People

            cliffmeyers Cliff Meyers
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: