Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43265

REGRESSION Dashboard showPipelineList prevents extension point rendering

    XMLWordPrintable

Details

    • Blue Ocean - 1.1-beta-1

    Description

      https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/js/components/Pipelines.jsx#L76

       

      const showPipelineList = !this.pager.pending && pipelines && pipelines.length > 0;
      const showEmptyState = !this.pager.pending && (!pipelines || !pipelines.length);
      
      { showEmptyState && <DashboardPlaceholder t={translate} /> }
      { showPipelineList &&
      <main>
      <article>
      { /* TODO: need to adjust Extensions to make store available */ }
      <Extensions.Renderer
      extensionPoint="jenkins.pipeline.list.top"
      store={ this.context.store }
      router={ this.context.router }
      />

      The above prevents that the extension point "jenkins.pipeline.list.top" is rendered when no pipelines are there. However in my use case I want to render a navigation box but it has nothing to do with pipelines (not directly) so it should always show.

      In case the point is that this extension point is thought to be only there in case pipeline exists, then IMO we need another extension renderer call outside.

      REGRESSION because before we always rendered the extension point.

      Attachments

        Activity

          jamesdumay James Dumay added a comment -

          tscherler is this for your new project?

          jamesdumay James Dumay added a comment - tscherler is this for your new project?

          jamesdumay yeah I discovered it there, but generally IMO we can/should not create conditional extensions points that is a really bad idea.

          tscherler Thorsten Scherler added a comment - jamesdumay yeah I discovered it there, but generally IMO we can/should not create conditional extensions points that is a really bad idea.
          cliffmeyers Cliff Meyers added a comment - - edited

          tscherler this was an oversight on my part and I think is a totally valid issue. jamesdumay I can fix this one fairly quickly if you send it my way.

          cliffmeyers Cliff Meyers added a comment - - edited tscherler this was an oversight on my part and I think is a totally valid issue. jamesdumay I can fix this one fairly quickly if you send it my way.
          jamesdumay James Dumay added a comment -

          cliffmeyers if you wouldn't mind

          jamesdumay James Dumay added a comment - cliffmeyers if you wouldn't mind
          cliffmeyers Cliff Meyers added a comment - PR: https://github.com/jenkinsci/blueocean-plugin/pull/948

          People

            cliffmeyers Cliff Meyers
            tscherler Thorsten Scherler
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: