Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43265

REGRESSION Dashboard showPipelineList prevents extension point rendering

XMLWordPrintable

    • Blue Ocean - 1.1-beta-1

      https://github.com/jenkinsci/blueocean-plugin/blob/master/blueocean-dashboard/src/main/js/components/Pipelines.jsx#L76

       

      const showPipelineList = !this.pager.pending && pipelines && pipelines.length > 0;
      const showEmptyState = !this.pager.pending && (!pipelines || !pipelines.length);
      
      { showEmptyState && <DashboardPlaceholder t={translate} /> }
      { showPipelineList &&
      <main>
      <article>
      { /* TODO: need to adjust Extensions to make store available */ }
      <Extensions.Renderer
      extensionPoint="jenkins.pipeline.list.top"
      store={ this.context.store }
      router={ this.context.router }
      />

      The above prevents that the extension point "jenkins.pipeline.list.top" is rendered when no pipelines are there. However in my use case I want to render a navigation box but it has nothing to do with pipelines (not directly) so it should always show.

      In case the point is that this extension point is thought to be only there in case pipeline exists, then IMO we need another extension renderer call outside.

      REGRESSION because before we always rendered the extension point.

            cliffmeyers Cliff Meyers
            tscherler Thorsten Scherler
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: