Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43316

When developer selects text it should pause karaoke

    • Blue Ocean 1.1, Blue Ocean 1.1, Blue Ocean 1.2-beta1, Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2, Blue Ocean 1.6 - beta 2, Blue Ocean - 1.6 - beta 4

      Steps to reproduce

      1. I am viewing the running Pipeline defined in the example below
      2. Step 1 of stage 1 is executing. I select its text with my mouse to copy and paste or interact with the log in some way (selecting, clicking, etc - I am focused on this log as its streaming)
      3. Step 1 of stage 1 finishes and Step 1 of Stage 2 starts executing
      4. My focus is ripped away from Step 1 of Stage 1 to Step 1 of Stage 2.

      What should happen
      When I open step 1 of stage 1, karaoke should not move my focus to Step 1 of Stage 2.

      Example

      pipeline {
          agent any
          stages {
              stage('1') {
                  steps {
                      sh 'ping -c 10 localhost'
                  }
              }
              stage('2') {
                  steps {
                      sh 'ping -c 50 localhost'
                  }
              }
          }
      }
      

          [JENKINS-43316] When developer selects text it should pause karaoke

          James Dumay created issue -
          James Dumay made changes -
          Epic Link New: JENKINS-35750 [ 171713 ]

          Cliff Meyers added a comment -

          Piggy-backing on this, it would be cool if pressing the "HOME" key (which scrolls browser to the top) also disabled karaoke.

          I wonder if it would be easier to code the logic so that a mouse event or keyboard event stops karaoke, except in the following cases:

          • User pressed "END" key (to scroll to bottom)
          • User scrolled log console to very bottom

          Maybe also on a mouse click that isn't an interactive element. It's hard to say which approach is the right way, but it feels like most of the time when the user begins interacting that it's safe to assume we should stop scrolling. I could be wrong, but thought it was worth discussing.

          Cliff Meyers added a comment - Piggy-backing on this, it would be cool if pressing the "HOME" key (which scrolls browser to the top) also disabled karaoke. I wonder if it would be easier to code the logic so that a mouse event or keyboard event stops karaoke, except in the following cases: User pressed "END" key (to scroll to bottom) User scrolled log console to very bottom Maybe also on a mouse click that isn't an interactive element. It's hard to say which approach is the right way, but it feels like most of the time when the user begins interacting that it's safe to assume we should stop scrolling. I could be wrong, but thought it was worth discussing.
          James Dumay made changes -
          Labels New: pipeline-improvement
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.1 [ 271 ] New: Blue Ocean 1.2 [ 296 ]
          James Dumay made changes -
          Rank New: Ranked higher
          James Dumay made changes -
          Rank New: Ranked higher
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.2 [ 296 ] New: Blue Ocean 1.3 [ 311 ]
          James Dumay made changes -
          Epic Link Original: JENKINS-35750 [ 171713 ] New: JENKINS-43952 [ 181484 ]
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.3 [ 311 ] New: Blue Ocean 1.1-beta5 [ 321 ]
          James Dumay made changes -
          Rank New: Ranked lower

            sophistifunk Josh McDonald
            jamesdumay James Dumay
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated: