Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43348

Option to use author instead of commiter in declarative pipeline

    XMLWordPrintable

Details

    Description

      Problem
      Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`).

      Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout.

      (in `git-plugin` this is called `AuthorInChangelog`)

      Scope

      • Switch to displaying the Author information for Git repositories (instead of Committer)

      Attachments

        Issue Links

          Activity

            rochdev Roch Devost created issue -
            rochdev Roch Devost added a comment -

            I am actually wondering if this should be reported as a bug instead, since the GitHub source is basically incompatible with GitHub.

            rochdev Roch Devost added a comment - I am actually wondering if this should be reported as a bug instead, since the GitHub source is basically incompatible with GitHub.
            jamesdumay James Dumay made changes -
            Field Original Value New Value
            Issue Type New Feature [ 2 ] Bug [ 1 ]
            jamesdumay James Dumay added a comment -

            I don't think that the core API for change sets can differentiate between committer and author. I'd strongly suggest either it is updated to support that or we switch from one to another.

            jamesdumay James Dumay added a comment - I don't think that the core API for change sets can differentiate between committer and author. I'd strongly suggest either it is updated to support that or we switch from one to another.
            jamesdumay James Dumay made changes -
            Labels pipeline-improvement
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-35750 [ 171713 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2 [ 296 ]
            stephenconnolly Stephen Connolly made changes -
            Epic Link JENKINS-35750 [ 171713 ] JENKINS-43426 [ 180671 ]
            stephenconnolly Stephen Connolly made changes -
            Assignee Andrew Bayer [ abayer ]
            jamesdumay James Dumay made changes -
            Rank Ranked lower
            abayer Andrew Bayer added a comment -

            As rochdev pointed out, the git plugin has this support already - https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/extensions/impl/AuthorInChangelog.java - so I think this would be best as an option for the GitHub branch source, probably for BitBucket branch source as well.

            abayer Andrew Bayer added a comment - As rochdev pointed out, the git plugin has this support already - https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/extensions/impl/AuthorInChangelog.java - so I think this would be best as an option for the GitHub branch source, probably for BitBucket branch source as well.
            rochdev Roch Devost added a comment -

            If it is possible to enable it by default it would be best, since the current behaviour doesn't make much sense anyway. I can't think of a reason why anybody would want to keep `nobody` as the author of every commits.

            rochdev Roch Devost added a comment - If it is possible to enable it by default it would be best, since the current behaviour doesn't make much sense anyway. I can't think of a reason why anybody would want to keep `nobody` as the author of every commits.
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.2 [ 296 ] Blue Ocean 1.3 [ 311 ]
            jamesdumay James Dumay made changes -
            Epic Link JENKINS-43426 [ 180671 ] JENKINS-43952 [ 181484 ]

            JENKINS-43507 enabled the GitSCMExtension that provides AuthorInChangeLog

            stephenconnolly Stephen Connolly added a comment - JENKINS-43507 enabled the GitSCMExtension that provides AuthorInChangeLog
            stephenconnolly Stephen Connolly made changes -
            Link This issue duplicates JENKINS-43507 [ JENKINS-43507 ]
            stephenconnolly Stephen Connolly made changes -
            Resolution Duplicate [ 3 ]
            Status Open [ 1 ] Resolved [ 5 ]
            jamesdumay James Dumay made changes -
            Component/s github-branch-source-plugin [ 20858 ]
            Component/s pipeline-model-definition-plugin [ 21706 ]
            jamesdumay James Dumay made changes -
            Resolution Duplicate [ 3 ]
            Status Resolved [ 5 ] Reopened [ 4 ]
            jamesdumay James Dumay made changes -
            Description Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`).

            Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout.

            (in `git-plugin` this is called `AuthorInChangelog`)

            *Problem*
            Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`).

            Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout.

            (in `git-plugin` this is called `AuthorInChangelog`)

            *Scope*
            * Switch to displaying the Author information for Git repositories (instead of Committer)
            jamesdumay James Dumay made changes -
            Link This issue duplicates JENKINS-43507 [ JENKINS-43507 ]
            jamesdumay James Dumay made changes -
            Link This issue is blocked by JENKINS-43507 [ JENKINS-43507 ]
            jamesdumay James Dumay made changes -
            Sprint Blue Ocean 1.4 [ 311 ]
            jamesdumay James Dumay made changes -
            Rank Ranked higher
            abayer Andrew Bayer made changes -
            Component/s pipeline-model-definition-plugin [ 21706 ]
            Component/s blueocean-plugin [ 21481 ]
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]
            abayer Andrew Bayer added a comment -

            Seems like this may make sense to add as an option for Declarative - might actually end up doing it in git-plugin, though. We'll see.

            abayer Andrew Bayer added a comment - Seems like this may make sense to add as an option for Declarative - might actually end up doing it in git-plugin , though. We'll see.
            abayer Andrew Bayer made changes -
            Issue Type Bug [ 1 ] Improvement [ 4 ]

            I have to agree completely that substituting the commiter for what should really be the patch author is really not very useful at all.  It doesn't make sense to e-mail the commiter when there is a problem with the patch.  It doesn't make sense for Blue Ocean to list the commiter as the person responsible for the change.

            Is this issue anywhere near completion?

            brianjmurrell Brian J Murrell added a comment - I have to agree completely that substituting the commiter for what should really be the patch author is really not very useful at all.  It doesn't make sense to e-mail the commiter when there is a problem with the patch.  It doesn't make sense for Blue Ocean to list the commiter as the person responsible for the change. Is this issue anywhere near completion?
            rupunzlkim Kim Abbott made changes -
            Attachment commitAuthor.png [ 50059 ]
            rupunzlkim Kim Abbott made changes -
            Attachment commitAuthor.png [ 50059 ]
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]

            People

              Unassigned Unassigned
              rochdev Roch Devost
              Votes:
              1 Vote for this issue
              Watchers:
              7 Start watching this issue

              Dates

                Created:
                Updated: