Details
-
Improvement
-
Status: Reopened (View Workflow)
-
Minor
-
Resolution: Unresolved
Description
Problem
Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`).
Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout.
(in `git-plugin` this is called `AuthorInChangelog`)
Scope
- Switch to displaying the Author information for Git repositories (instead of Committer)
Attachments
Issue Links
- is blocked by
-
JENKINS-43507 Allow SCMSource and SCMNavigator subtypes to share common traits
-
- Resolved
-
Activity
Roch Devost
created issue -
| Field | Original Value | New Value |
|---|---|---|
| Issue Type | New Feature [ 2 ] | Bug [ 1 ] |
I don't think that the core API for change sets can differentiate between committer and author. I'd strongly suggest either it is updated to support that or we switch from one to another.
| Labels | pipeline-improvement |
| Epic Link | JENKINS-35750 [ 171713 ] |
| Sprint | Blue Ocean 1.2 [ 296 ] |
| Epic Link | JENKINS-35750 [ 171713 ] |
|
| Assignee | Andrew Bayer [ abayer ] |
| Rank | Ranked lower |
As rochdev pointed out, the git plugin has this support already - https://github.com/jenkinsci/git-plugin/blob/master/src/main/java/hudson/plugins/git/extensions/impl/AuthorInChangelog.java - so I think this would be best as an option for the GitHub branch source, probably for BitBucket branch source as well.
Roch Devost
added a comment - If it is possible to enable it by default it would be best, since the current behaviour doesn't make much sense anyway. I can't think of a reason why anybody would want to keep `nobody` as the author of every commits.
Roch Devost
added a comment - If it is possible to enable it by default it would be best, since the current behaviour doesn't make much sense anyway. I can't think of a reason why anybody would want to keep `nobody` as the author of every commits. | Sprint | Blue Ocean 1.2 [ 296 ] | Blue Ocean 1.3 [ 311 ] |
| Epic Link |
|
JENKINS-43952 [ 181484 ] |
JENKINS-43507 enabled the GitSCMExtension that provides AuthorInChangeLog
| Link |
This issue duplicates |
| Resolution | Duplicate [ 3 ] | |
| Status | Open [ 1 ] | Resolved [ 5 ] |
| Component/s | github-branch-source-plugin [ 20858 ] | |
| Component/s | pipeline-model-definition-plugin [ 21706 ] |
| Resolution | Duplicate [ 3 ] | |
| Status | Resolved [ 5 ] | Reopened [ 4 ] |
| Description |
Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`). Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout. (in `git-plugin` this is called `AuthorInChangelog`) |
*Problem* Right now when adding a GitHub source in Blue Ocean every change merged from a pull request is being shown as "Changes from noreply". This also impacts all plugins that rely on the commiters for a build since it effectively hides the actual authors (including when using `email-ext` or `mailer`). Since changing the default behaviour might be a breaking change, an option should be added to the pipeline so that each agent uses the correct strategy for the checkout. (in `git-plugin` this is called `AuthorInChangelog`) *Scope* * Switch to displaying the Author information for Git repositories (instead of Committer) |
| Link |
This issue duplicates |
| Link |
This issue is blocked by |
| Sprint | Blue Ocean 1.4 [ 311 ] |
| Rank | Ranked higher |
| Component/s | pipeline-model-definition-plugin [ 21706 ] | |
| Component/s | blueocean-plugin [ 21481 ] |
| Assignee | Andrew Bayer [ abayer ] |
Seems like this may make sense to add as an option for Declarative - might actually end up doing it in git-plugin, though. We'll see.
| Issue Type | Bug [ 1 ] | Improvement [ 4 ] |
Brian J Murrell
added a comment - I have to agree completely that substituting the commiter for what should really be the patch author is really not very useful at all. It doesn't make sense to e-mail the commiter when there is a problem with the patch. It doesn't make sense for Blue Ocean to list the commiter as the person responsible for the change.
Is this issue anywhere near completion?
Brian J Murrell
added a comment - I have to agree completely that substituting the commiter for what should really be the patch author is really not very useful at all. It doesn't make sense to e-mail the commiter when there is a problem with the patch. It doesn't make sense for Blue Ocean to list the commiter as the person responsible for the change.
Is this issue anywhere near completion? | Attachment | commitAuthor.png [ 50059 ] |
| Attachment | commitAuthor.png [ 50059 ] |
| Assignee | Andrew Bayer [ abayer ] |
I am actually wondering if this should be reported as a bug instead, since the GitHub source is basically incompatible with GitHub.