• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • active-choices-plugin
    • None
    • Ubuntu 16.04.2
      OpenJDK8
      Jenkins v2.46.1 LTS
      Active Choices Plug-in 1.4
      Matrix Configuration Parameter Plugin 1.1.0

      After upgrading to Ubuntu 16.04.2 and Jenkins 2.46.1,
      some of input parameter HTML description stops to work.

        1. config.xml
          3 kB
        2. Screenshot_2017-07-06_23-47-55.png
          Screenshot_2017-07-06_23-47-55.png
          70 kB
        3. Screenshot_2017-07-06_23-48-07.png
          Screenshot_2017-07-06_23-48-07.png
          61 kB
        4. Screenshot_2017-07-06_23-48-07.png
          Screenshot_2017-07-06_23-48-07.png
          61 kB
        5. Screenshot_2017-12-28_14-05-29.png
          Screenshot_2017-12-28_14-05-29.png
          39 kB
        6. Screenshot from 2017-07-06 23-04-40.png
          Screenshot from 2017-07-06 23-04-40.png
          48 kB
        7. Screenshot from 2017-07-06 23-04-40.png
          Screenshot from 2017-07-06 23-04-40.png
          48 kB
        8. Selection_001.png
          Selection_001.png
          73 kB
        9. Selection_002.png
          Selection_002.png
          49 kB
        10. uno-choice.hpi
          242 kB

          [JENKINS-43380] Input parameter HTML description not working

          The fix seems easy. But I may not have understood the issue very well. At least I don't seem to be able to reproduce it with the latest version of the plug-in, updating java.version=7, jenkins-plugin to 2.3, and jenkins.version to 2.7.4.

           

          Bruno P. Kinoshita added a comment - The fix seems easy. But I may not have understood the issue very well. At least I don't seem to be able to reproduce it with the latest version of the plug-in, updating java.version=7, jenkins-plugin to 2.3, and jenkins.version to 2.7.4.  

          Daniel Beck added a comment -

          kinow

           jenkins.version to 2.7.4.

          No surprise there, SECURITY-353 was only fixed in 2.32.2: https://jenkins.io/security/advisory/2017-02-01/

          Daniel Beck added a comment - kinow  jenkins.version to 2.7.4. No surprise there, SECURITY-353 was only fixed in 2.32.2: https://jenkins.io/security/advisory/2017-02-01/

          Thanks Daniel! Thought I was using a newer version, but was only confused by the 4 in 2.46.1 Sorry.

          Tested with the pom using 2.32.2 as jenkins.version. Successfully reproduced the issue. Fixed as suggested, and it worked.

          Reverted changes to pom, kept just the jelly change, and everything still worked fine.

          Issue included in the next release. Thanks!

          Bruno

          Bruno P. Kinoshita added a comment - Thanks Daniel! Thought I was using a newer version, but was only confused by the 4 in 2.46.1 Sorry. Tested with the pom using 2.32.2 as jenkins.version. Successfully reproduced the issue. Fixed as suggested, and it worked. Reverted changes to pom, kept just the jelly change, and everything still worked fine. Issue included in the next release. Thanks! Bruno

          Daniel Beck added a comment -

          kinow Glad I could help, thanks for taking care of this.

          Daniel Beck added a comment - kinow Glad I could help, thanks for taking care of this.

          Code changed in jenkins
          User: Bruno P. Kinoshita
          Path:
          src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly
          src/main/resources/org/biouno/unochoice/common/choiceParameterCommon.jelly
          http://jenkins-ci.org/commit/active-choices-plugin/84309cae515339a41fc36fe88958aadc781bcbe4
          Log:
          [FIXED JENKINS-43380] fixing HTML description not showing correclty in parameters

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Bruno P. Kinoshita Path: src/main/resources/org/biouno/unochoice/DynamicReferenceParameter/index.jelly src/main/resources/org/biouno/unochoice/common/choiceParameterCommon.jelly http://jenkins-ci.org/commit/active-choices-plugin/84309cae515339a41fc36fe88958aadc781bcbe4 Log: [FIXED JENKINS-43380] fixing HTML description not showing correclty in parameters

          Fixed by applying the fix suggested by Daniel. Adding a screen shot with a HTML dynamic param, an choices param, and the String param from vanilla Jenkins. Plus the config.xml used.

          Cheers

          Bruno

          Bruno P. Kinoshita added a comment - Fixed by applying the fix suggested by Daniel. Adding a screen shot with a HTML dynamic param, an choices param, and the String param from vanilla Jenkins. Plus the config.xml used. Cheers Bruno

          ioannis I'm attaching the hpi for this issue. With this, I believe we have no more blockers to release a new version? If you could give it some more testing to make sure we are ready to release it, I'll cut the release once you give the green signal Thanks!

          Bruno P. Kinoshita added a comment - ioannis I'm attaching the hpi for this issue. With this, I believe we have no more blockers to release a new version? If you could give it some more testing to make sure we are ready to release it, I'll cut the release once you give the green signal Thanks!

          Oh, and all issues for 2.0.1 are in https://wiki.jenkins.io/display/JENKINS/Active+Choices+Plugin under its release notes section.

          Bruno P. Kinoshita added a comment - Oh, and all issues for 2.0.1 are in https://wiki.jenkins.io/display/JENKINS/Active+Choices+Plugin under its release notes section.

          kinow thank you for providing the hpi file for testing. It looks good! I have tested the fix successfully with Active Choice parameters containing description fields with HTML. The HTML is rendered correctly on the build form (using Jenkins v 2.93) I think we are ready for a new release of the Active Choices plugin! By the way why is the next  AC release 2.0.1 and not 2.1?

          Ioannis Moutsatsos added a comment - kinow thank you for providing the hpi file for testing. It looks good! I have tested the fix successfully with Active Choice parameters containing description fields with HTML. The HTML is rendered correctly on the build form (using Jenkins v 2.93) I think we are ready for a new release of the Active Choices plugin! By the way why is the next  AC release 2.0.1 and not 2.1?

          Thanks for testing it ioannis! Oh, we have some new features besides the bugfixes, so let's go with 2.1. I will prepare the release today or tomorrow, and then announce in the biouno mailing list / twitter.

          Bruno P. Kinoshita added a comment - Thanks for testing it ioannis ! Oh, we have some new features besides the bugfixes, so let's go with 2.1. I will prepare the release today or tomorrow, and then announce in the biouno mailing list / twitter.

            kinow Bruno P. Kinoshita
            totoroliu Rick Liu
            Votes:
            3 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: