Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43536

Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Plugin

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Minor Minor
    • envinject-plugin
    • None

      It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases. depends on JENKINS-43535

          [JENKINS-43536] Minimize scope of AbstractProject/AbstractBuild usage in EnvInject Plugin

          Oleg Nenashev created issue -
          Oleg Nenashev made changes -
          Epic Link New: JENKINS-42614 [ 179553 ]
          Oleg Nenashev made changes -
          Description Original: It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases New: It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases. depends on JENKINS-43536
          Oleg Nenashev made changes -
          Link New: This issue depends on JENKINS-43535 [ JENKINS-43535 ]
          Oleg Nenashev made changes -
          Description Original: It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases. depends on JENKINS-43536 New: It is required to simplify Pipeline support and to troubleshoot defects in currently supported cases. depends on JENKINS-43535
          Oleg Nenashev made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - https://github.com/jenkinsci/envinject-lib/pull/8 https://github.com/jenkinsci/envinject-api-plugin/pull/1 https://github.com/jenkinsci/envinject-plugin/pull/118
          Oleg Nenashev made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java
          src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java
          src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java
          src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java
          http://jenkins-ci.org/commit/envinject-plugin/6ec719d3bb7ec84c56f03c10c8ad132ebd33d551
          Log:
          JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible

          It won't help Jenkins Pipeline much I suppose, but at least it streamlines the handling logic.
          The change depends on EnvInject Lib API update.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuilder$1.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectListener.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectPluginAction.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java src/main/java/org/jenkinsci/plugins/envinject/service/BuildCauseRetriever.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectActionSetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectPasswordsMasker.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvInjectVariableGetter.java src/main/java/org/jenkinsci/plugins/envinject/service/EnvironmentVariablesNodeLoader.java src/main/java/org/jenkinsci/plugins/envinject/util/RunHelper.java http://jenkins-ci.org/commit/envinject-plugin/6ec719d3bb7ec84c56f03c10c8ad132ebd33d551 Log: JENKINS-43536 - Avoid usage of AbstractProject/AbstractBuild where possible It won't help Jenkins Pipeline much I suppose, but at least it streamlines the handling logic. The change depends on EnvInject Lib API update.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java
          src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java
          src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java
          http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816
          Log:
          JENKINS-43536 - Pick changes for JENKINS-43845

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml src/main/java/org/jenkinsci/plugins/envinject/EnvInjectAction.java src/main/java/org/jenkinsci/plugins/envinject/EnvInjectBuildVariableContributor.java src/main/java/org/jenkinsci/plugins/envinject/model/EnvInjectJobPropertyContributor.java http://jenkins-ci.org/commit/envinject-plugin/af113cfd5008e73b349266891b89d6b043296816 Log: JENKINS-43536 - Pick changes for JENKINS-43845

            oleg_nenashev Oleg Nenashev
            oleg_nenashev Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: