We rely too heavily on the ATH to test basic parts of the LogConsole component - for example if the "show more" button shows up. Many of these things are better unit tested (or at least that one). 

          [JENKINS-43712] unit test <LogConsole>

          Michael Neale created issue -
          Michael Neale made changes -
          Epic Link New: JENKINS-35750 [ 171713 ]
          Michael Neale made changes -
          Link New: This issue relates to JENKINS-42995 [ JENKINS-42995 ]
          James Dumay made changes -
          Epic Link Original: JENKINS-35750 [ 171713 ] New: JENKINS-43952 [ 181484 ]
          James Dumay made changes -
          Sprint New: Blue Ocean 1.1 [ 271 ]
          James Dumay made changes -
          Rank New: Ranked lower
          James Dumay made changes -
          Epic Link Original: JENKINS-43952 [ 181484 ] New: JENKINS-42919 [ 179928 ]
          James Dumay made changes -
          Sprint Original: Blue Ocean 1.2-beta2 [ 271 ] New: Blue Ocean 1.4 [ 311 ]
          James Dumay made changes -
          Rank New: Ranked lower

          Cliff Meyers added a comment -

          Yes: we should add a prop "max lines displayed" and default it to 5000 or whatever, but we can unit test it with smaller values (show 5 lines max by default, and test rendering with a 10 line log file)

          Cliff Meyers added a comment - Yes: we should add a prop "max lines displayed" and default it to 5000 or whatever, but we can unit test it with smaller values (show 5 lines max by default, and test rendering with a 10 line log file)

            Unassigned Unassigned
            michaelneale Michael Neale
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: