Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43783

Unparsed commit message causes pipeline aggregator to not show anything except table header

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      Hi,

      I just discovered this awesome plugin, and got it to work quite well. When I reverted a commit, thus creating a commit message: Revert "xyz: masked ascii chars here", Pipeline Aggregator stopped showing any lines at all (previously 16). 

      After some troubleshooting, I found the message attached in jenkins_log_backtrace.

      SEVERE: ChangeLogAnnotator hudson.plugins.collabnet.CNChangeLogAnnotator@31da6210 failed to annotate message 'Revert "xyz: masked ascii chars here"'; You must override the newer overload of annotate

      I guess something went wrong with the parsing of the commit message. This led me to try to see if, I decrease the number of lines, I could revive Aggregator. Lo and behold, it started working again. See the image below for when I swap between 1 row (not including the commit message above) and 2 lines (including the commit message above --> causing no output).

      I might be able to solve the initial crash in Jenkins somehow, but it would be great if Pipeline-Aggregator could handle this somehow as well. It was more or less by luck I found the correlation between commit message and non-working Aggregator.

       

      Thanks in advance! Great plugin.

      /Magnus

       

        Attachments

          Activity

          Hide
          fajran Fajran Rusadi added a comment -

          Hi, I am also having this problem. Looks like if there are quotes in the commit message, the JSON returned by the Pipeline Aggregator API does not have the quotes escaped and thus break the JSON format.

          I guess something should escape the text. I am not familiar with Jenkins code so cannot really tell where that should happen.

           

          Show
          fajran Fajran Rusadi added a comment - Hi, I am also having this problem. Looks like if there are quotes in the commit message, the JSON returned by the Pipeline Aggregator API does not have the quotes escaped and thus break the JSON format. I guess something should escape the text. I am not familiar with Jenkins code so cannot really tell where that should happen.  
          Hide
          paul8620 Paul Horvath added a comment -

          nice catches can you provide me with a github repo that reporduces this issues for quick solving thx

          Show
          paul8620 Paul Horvath added a comment - nice catches can you provide me with a github repo that reporduces this issues for quick solving thx
          Hide
          fajran Fajran Rusadi added a comment -

          I created a pull request with fix for this issue https://github.com/jenkinsci/pipeline-aggregator-view-plugin/pull/1

          Show
          fajran Fajran Rusadi added a comment - I created a pull request with fix for this issue  https://github.com/jenkinsci/pipeline-aggregator-view-plugin/pull/1
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Paul
          Path:
          src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java
          src/main/webapp/js/pipeline-aggregator.js
          src/test/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregatorTest.java
          http://jenkins-ci.org/commit/pipeline-aggregator-view-plugin/b3a2c3a362005dc03acc05456aa5b8f6d7e15b03
          Log:
          Merge pull request #1 from fajran/JENKINS-43783

          Put ChangeLogs in a list instead of map

          Compare: https://github.com/jenkinsci/pipeline-aggregator-view-plugin/compare/fdb8b74c9c9c...b3a2c3a36200

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Paul Path: src/main/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregator.java src/main/webapp/js/pipeline-aggregator.js src/test/java/com/ooyala/jenkins/plugins/pipelineaggregatorview/PipelineAggregatorTest.java http://jenkins-ci.org/commit/pipeline-aggregator-view-plugin/b3a2c3a362005dc03acc05456aa5b8f6d7e15b03 Log: Merge pull request #1 from fajran/ JENKINS-43783 Put ChangeLogs in a list instead of map Compare: https://github.com/jenkinsci/pipeline-aggregator-view-plugin/compare/fdb8b74c9c9c...b3a2c3a36200

            People

            Assignee:
            paul8620 Paul Horvath
            Reporter:
            tigrlily Magnus Wahlstrand
            Votes:
            0 Vote for this issue
            Watchers:
            4 Start watching this issue

              Dates

              Created:
              Updated: