Details
-
Bug
-
Status: Closed (View Workflow)
-
Major
-
Resolution: Fixed
-
Jenkins Version: 2.56
Plugin version: latest (at 26h April 2017)
Pipeline Version: 2.5
Java version: (build 1.8.0_51-b16)
Description
The pipeline view does not show the button to stop a running pipeline build, if the user does not has the right administer.
with the right administer:
without the right administer:
On the startpage the button does show the stop button independent of the administer right and the user can stop the build. So it seems to be a gui problem not a problem with the underlying security model:
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
- links to
Activity
Core PR up at https://github.com/jenkinsci/jenkins/pull/3101 to get rid of that last lurking usage of the ABORT permission in core. WorkflowJob doesn't have the ABORT permission, hence this issue.
Alongside the core PR, I've also got https://github.com/jenkinsci/workflow-job-plugin/pull/80 up to add the deprecated ABORT permission to WorkflowJob so this gets bandaided on older versions of core as well.
Code changed in jenkins
User: Andrew Bayer
Path:
src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
http://jenkins-ci.org/commit/workflow-job-plugin/2fb0a89c4d3c8da8d81e1b5fe0e389e767dc1bbd
Log:
JENKINS-43834 Add deprecated ABORT permission
Going forward (with core 2.86 or 2.87 and later), CANCEL will be used
in HistoryWidget, but this bandaids things for Pipelines on earlier
core versions.
Code changed in jenkins
User: Sam Van Oort
Path:
src/main/java/org/jenkinsci/plugins/workflow/job/WorkflowJob.java
http://jenkins-ci.org/commit/workflow-job-plugin/94308a9ecd09f62cf2e1f075d56b2dbf9165bb46
Log:
Merge pull request #80 from abayer/jenkins-43834
JENKINS-43834 Add deprecated ABORT permission
Compare: https://github.com/jenkinsci/workflow-job-plugin/compare/d88e5d2aa5b0...94308a9ecd09
Code changed in jenkins
User: Andrew Bayer
Path:
core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly
http://jenkins-ci.org/commit/jenkins/0d9beb20ab86a522d019df6dc6e467c3184f0b5b
Log:
[FIXED JENKINS-43834] Stop using deprecated ABORT permission
This is the only place it's actually referenced, so let's get rid of
it entirely.
Looks to be due to https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/widgets/HistoryWidget/entry.jelly#L64 - the ABORT permission is specific to AbstractProject and so is never actually granted in WorkflowJob world.