Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-43936

Performance issues caused by User.getOrCreate

    XMLWordPrintable

Details

    Description

      According to the source code, when executing User.getOrCreate() this code is executed all the time even if the user is in memory. It only needs to be done once - which should be if the user is not in memory (ie do it once when the user is loaded) - after which it is in the map of loaded users - no need to do it again - ever.... (until Jenkins restart).

      One simple solution seems to be to change 

      if (!configFile.isFile() && !configFile.getParentFile().isDirectory()) {

      per

      if (u == null && !configFile.isFile() && !configFile.getParentFile().isDirectory()) {

      The typical stacktrace I am seeing on Jenkins instance which reveal this is an issue is:

      "Handling GET /m2/securityRealm/finishLogin from X.X.X.X : RequestHandlerThread[#4449]" #326951 daemon prio=5 os_prio=0 tid=0x00007fb1f1480000 nid=0x2b0d runnable [0x00007fb1a3b2f000]
   java.lang.Thread.State: RUNNABLE
	at java.io.UnixFileSystem.getBooleanAttributes0(Native Method)
	at java.io.UnixFileSystem.getBooleanAttributes(UnixFileSystem.java:242)
	at java.io.File.isFile(File.java:882)
	at hudson.model.User.getOrCreate(User.java:429)
	at hudson.model.User.getById(User.java:529)
	at hudson.model.User$UserIDCanonicalIdResolver.resolveCanonicalId(User.java:1071)
	at hudson.model.User.get(User.java:399)
	at hudson.model.User.get(User.java:368)
	at hudson.model.User.get(User.java:488)

      For the moment, it seems to be only a problem on NFS systems with perhaps a non very good performance.

      Attachments

        Issue Links

          is related to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-47718 Deprecate User.getUser(String)

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          relates to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47429 Absolutely atrocious user lookup performance when many legacy users

          • Major - Major loss of function.
          • Resolved

          Activity

            Ascending order - Click to sort in descending order
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Félix Belzunce Arcos
            Path:
            core/src/main/java/hudson/model/User.java
            http://jenkins-ci.org/commit/jenkins/f091c9de34e2c8fcaf93966180226dea52f90e38
            Log:
            JENKINS-43936 Only migrate legacy users once per restart

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Félix Belzunce Arcos Path: core/src/main/java/hudson/model/User.java http://jenkins-ci.org/commit/jenkins/f091c9de34e2c8fcaf93966180226dea52f90e38 Log: JENKINS-43936 Only migrate legacy users once per restart
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Oleg Nenashev
            Path:
            core/src/main/java/hudson/model/User.java
            http://jenkins-ci.org/commit/jenkins/8a48e0ccb9273d91eb74bf3c07f71d1d7aab16dc
            Log:
            Merge pull request #2862 from fbelzunc/JENKINS-43936

            [FIXED JENKINS-43936] Only migrate legacy users once per restart

            Compare: https://github.com/jenkinsci/jenkins/compare/6ff50863e433...8a48e0ccb927

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: core/src/main/java/hudson/model/User.java http://jenkins-ci.org/commit/jenkins/8a48e0ccb9273d91eb74bf3c07f71d1d7aab16dc Log: Merge pull request #2862 from fbelzunc/ JENKINS-43936 [FIXED JENKINS-43936] Only migrate legacy users once per restart Compare: https://github.com/jenkinsci/jenkins/compare/6ff50863e433...8a48e0ccb927
            oleg_nenashev Oleg Nenashev added a comment - - edited

            The fix has been released in 2.58. I have marked it as a LTS candidate

            oleg_nenashev Oleg Nenashev added a comment - - edited The fix has been released in 2.58. I have marked it as a LTS candidate
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Félix Belzunce Arcos
            Path:
            core/src/main/java/hudson/model/User.java
            http://jenkins-ci.org/commit/jenkins/1c56f01283719e8ade32e872ef9fa636a4437d2e
            Log:
            JENKINS-43936 Only migrate legacy users once per restart

            (cherry picked from commit f091c9de34e2c8fcaf93966180226dea52f90e38)

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Félix Belzunce Arcos Path: core/src/main/java/hudson/model/User.java http://jenkins-ci.org/commit/jenkins/1c56f01283719e8ade32e872ef9fa636a4437d2e Log: JENKINS-43936 Only migrate legacy users once per restart (cherry picked from commit f091c9de34e2c8fcaf93966180226dea52f90e38)
            oleg_nenashev Oleg Nenashev added a comment -

            JENKINS-47718 also deprecates the confusing User.get(String) API for cases when the user Creation is not expected

            oleg_nenashev Oleg Nenashev added a comment - JENKINS-47718 also deprecates the confusing User.get(String) API for cases when the user Creation is not expected

            People

              fbelzunc Félix Belzunce Arcos
              fbelzunc Félix Belzunce Arcos
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: