Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44322

email-ext sends wrong build status when called from declarative script

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • token-macro-plugin
    • None
    • Jenkins 2.61
      email-ext plugin 2.57.2

      I have a simple declarative script:

      pipeline {
          agent { label "mypc1" }
          stages {
              stage('build') {
                  steps {
                      sh '''
                          python --version
                      '''
                  }
              }
          }
          post {
      
              // We want to send notification emails to daldrich and the culprits.
              // The subject and body use the default content set in 'Jenkins > Configure System'
      
              success {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              failure {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              unstable {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
              changed {
                  script{ emailext (body: '${DEFAULT_CONTENT}',
                                    recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                                    subject: '${DEFAULT_SUBJECT}',
                                    to: 'daldrich')
                  }
              }
          }
      }
      

      Problem 1

      The email subject uses : '${DEFAULT_SUBJECT}', which ends with ‘$BUILD_STATUS!’. In the received email for a successful build the build status is ‘Building!’:

      Experimental_LedaAP_gcc_build » trunk - Build # 43 - Building!

      This is in ‘post’ so I expect the status to be ‘Success!’.

      abayer wrote on IRC:

      The build hasn't actually finished yet at that point. email-ext probably needs to be changed to be aware of that.

      So I think there is a bug in the plugin.

      Problem 2

      I'm expecting the email to be sent to daldrich and the culprits. There are culprits since there were svn commits by another user since the job last ran successfully.

      On Failure, the recipients are daldrich and the culprits, which is correct.

      When the failure is Fixed, the recipients are only daldrich - the culprits are not included, which is incorrect. (In a traditional Jenkins job, recipients and culprits are notified of Fixed, if they are specified in the job configuration).

      I think this is also a bug in the plugin.

          [JENKINS-44322] email-ext sends wrong build status when called from declarative script

          problem 1: +1

          Raphaël UNIQUE added a comment - problem 1: +1

          still waiting for someone with the problem to provide debug output

          David van Laatum added a comment - still waiting for someone with the problem to provide debug output

          Raphaël UNIQUE added a comment - - edited

          Script:

          	post 
          	
          	{ 
          		always {
          			emailext attachLog: true, body: '$DEFAULT_CONTENT', compressLog: true, recipientProviders: [[$class: 'RequesterRecipientProvider'], [$class: 'DevelopersRecipientProvider']], subject: '$DEFAULT_SUBJECT'
          		}
                  ....
          

          Log:

          [Pipeline] { (Declarative: Post Actions)
          [Pipeline] emailext
          15:50:11 messageContentType = text/html; charset=UTF-8
          15:50:11 Request made to attach build log
          15:50:11 Request made to compress build log
          15:50:11 Adding recipients from project recipient list
          15:50:11   Collecting change authors...
          15:50:11     build: 59
          15:50:11       adding author: Raphaël Unique
          15:50:11       adding author: Raphaël Unique
          15:50:11       adding author: Raphaël Unique
          15:50:11 Adding Raphaël Unique with address Raphael.Unique@xxx
          15:50:11 Adding recipients from trigger recipient list
          15:50:11 Successfully created MimeMessage
          15:50:11 Sending email to: Raphael.Unique@xxx
           

          Result:
          Mail subject: Multibranch » test_pipeline_xxx » trunk - Build # 59 - Building!

          Raphaël UNIQUE added a comment - - edited Script: post { always { emailext attachLog: true , body: '$DEFAULT_CONTENT' , compressLog: true , recipientProviders: [[$class: 'RequesterRecipientProvider' ], [$class: 'DevelopersRecipientProvider' ]], subject: '$DEFAULT_SUBJECT' } .... Log: [Pipeline] { (Declarative: Post Actions) [Pipeline] emailext 15:50:11 messageContentType = text/html; charset=UTF-8 15:50:11 Request made to attach build log 15:50:11 Request made to compress build log 15:50:11 Adding recipients from project recipient list 15:50:11 Collecting change authors... 15:50:11 build: 59 15:50:11 adding author: Raphaël Unique 15:50:11 adding author: Raphaël Unique 15:50:11 adding author: Raphaël Unique 15:50:11 Adding Raphaël Unique with address Raphael.Unique@xxx 15:50:11 Adding recipients from trigger recipient list 15:50:11 Successfully created MimeMessage 15:50:11 Sending email to: Raphael.Unique@xxx   Result: Mail subject: Multibranch » test_pipeline_xxx » trunk - Build # 59 - Building!

          Code changed in jenkins
          User: Alex Earl
          Path:
          src/main/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacro.java
          src/test/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacroTest.java
          http://jenkins-ci.org/commit/token-macro-plugin/6561df61269e2829757388a67f1fce10a165cbff
          Log:
          Fix JENKINS-44322

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alex Earl Path: src/main/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacro.java src/test/java/org/jenkinsci/plugins/tokenmacro/impl/BuildStatusMacroTest.java http://jenkins-ci.org/commit/token-macro-plugin/6561df61269e2829757388a67f1fce10a165cbff Log: Fix JENKINS-44322

          Alex Earl added a comment -

          This will be fixed in Token Macro 2.2

          Alex Earl added a comment - This will be fixed in Token Macro 2.2

          Benjamin Kihm added a comment -

          We have the problem again with Token Macro Version 2.7 and Email Extension 2.65 on Jenkins 2.164.1. Similar to davida2009 we use a shell script call which fails and an email block after the build stage:

            post {
              unstable {
                emailext to: '*****@*****.com, *****@*****.com',
                recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                subject: '${DEFAULT_SUBJECT}',
                body: '${DEFAULT_CONTENT}'
              }    failure {
                emailext to: '*****@*****.com, *****@*****.com',
                recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                subject: '${DEFAULT_SUBJECT}',
                body: '${DEFAULT_CONTENT}'
              }    fixed {
                emailext to: '*****@*****.com, *****@*****.com',
                recipientProviders: [[$class: 'CulpritsRecipientProvider']],
                subject: '${DEFAULT_SUBJECT}',
                body: '${DEFAULT_CONTENT}'
              }
            }
          

          In the Email subject we got

          ***-service » branchName - Build # 4 - SUCCESS
          
          

          instead of 

          ***-service » branchName - Build # 4 - Failure
          

          Our setting for the default email subject is

          $PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!
          

          Benjamin Kihm added a comment - We have the problem again with Token Macro Version 2.7 and Email Extension 2.65 on Jenkins 2.164.1. Similar to davida2009 we use a shell script call which fails and an email block after the build stage: post { unstable { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } failure { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } fixed { emailext to: '*****@*****.com, *****@*****.com' , recipientProviders: [[$class: 'CulpritsRecipientProvider' ]], subject: '${DEFAULT_SUBJECT}' , body: '${DEFAULT_CONTENT}' } } In the Email subject we got ***-service » branchName - Build # 4 - SUCCESS instead of  ***-service » branchName - Build # 4 - Failure Our setting for the default email subject is $PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!

          Benjamin Brummer added a comment - - edited

          bkihm, here we have the same error since with Jenkins 2.164.1 and email ext 2.65 (2.64)

          /* Set email content */
          def subjectContent = '$PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!'
          def bodyContent = '${SCRIPT, template="groovy-html.template"}'
          .....
          
          stage('Test') {
           steps {
            bat 'exit 1'
           }
          }
          
          ...
          
          fixed {
            emailext(
             body: bodyContent,
             recipientProviders: [
             developers(),
             requestor()
             ],
             subject: subjectContent
            )
          }
          

          Build on Jenkins fails and is red. Email says "Test - Build # 52 - SUCCESS!

          Benjamin Brummer added a comment - - edited bkihm , here we have the same error since with Jenkins 2.164.1 and email ext 2.65 (2.64) /* Set email content */ def subjectContent = '$PROJECT_NAME - Build # $BUILD_NUMBER - $BUILD_STATUS!' def bodyContent = '${SCRIPT, template= "groovy-html.template" }' ..... stage( 'Test' ) { steps { bat 'exit 1' } } ... fixed { emailext( body: bodyContent, recipientProviders: [ developers(), requestor() ], subject: subjectContent ) } Build on Jenkins fails and is red. Email says "Test - Build # 52 - SUCCESS!

          Devin Nusbaum added a comment -

          bkihm benbrummer I suspect that you are running into JENKINS-56402, which is a recent problem in Pipeline: Declarative Plugin version 1.3.5 and 1.3.6 that should be fixed in the upcoming 1.3.7 release, see that issue for details if you are running those versions currently.

          Devin Nusbaum added a comment - bkihm benbrummer I suspect that you are running into JENKINS-56402 , which is a recent problem in Pipeline: Declarative Plugin version 1.3.5 and 1.3.6 that should be fixed in the upcoming 1.3.7 release, see that issue for details if you are running those versions currently.

          Benjamin Kihm added a comment -

          dnusbaum: Thank you for the hint. This would explain why a rollback to previous versions (Token Macro 2.6 and Email Extension 2.63) do not helped out.

          Benjamin Kihm added a comment - dnusbaum : Thank you for the hint. This would explain why a rollback to previous versions (Token Macro 2.6 and Email Extension 2.63) do not helped out.

          Benjamin Kihm added a comment - - edited

          A rollback of Declarative plugin to v1.3.4.1. helped out.

          I have closed this ticket again

          Benjamin Kihm added a comment - - edited A rollback of Declarative plugin to v1.3.4.1. helped out. I have closed this ticket again

            slide_o_mix Alex Earl
            davida2009 David Aldrich
            Votes:
            2 Vote for this issue
            Watchers:
            9 Start watching this issue

              Created:
              Updated:
              Resolved: