• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • maven-plugin
    • None
    • Platform: All, OS: All

      Hudson went into an infinite loop while parsing my POMs.
      As it turned out, an empty module entry in the parent POM was the reason for
      this. E.g.:
      <modules>
      <module>common</module>
      <module>module-a</module>
      <module/>
      </modules>

      Note: Maven itself warns about the empty module but otherwise has no problem
      with it.

          [JENKINS-4442] Infinite loop while parsing POMs

          kutzi added a comment -

          Created an attachment (id=900)
          Patch

          kutzi added a comment - Created an attachment (id=900) Patch

          kutzi added a comment -

          From my analysis: Hudson - when getting an empty module - tries to parse again
          the parent module, resulting in the infinite loop.

          The attached patch simply skips any module with an empty name.

          kutzi added a comment - From my analysis: Hudson - when getting an empty module - tries to parse again the parent module, resulting in the infinite loop. The attached patch simply skips any module with an empty name.

          Andrew Bayer added a comment -

          Taking issue.

          Andrew Bayer added a comment - Taking issue.

          Code changed in hudson
          User: : abayer
          Path:
          trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenUtil.java
          trunk/hudson/main/test/src/test/java/hudson/maven/MavenEmptyModuleTest.java
          trunk/hudson/main/test/src/test/resources/hudson/maven/maven-empty-mod.zip
          trunk/www/changelog.html
          http://fisheye4.cenqua.com/changelog/hudson/?cs=21610
          Log:
          [FIXED JENKINS-4442] Empty or whitespace-only modules are now properly ignored by POM parser

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : abayer Path: trunk/hudson/main/maven-plugin/src/main/java/hudson/maven/MavenUtil.java trunk/hudson/main/test/src/test/java/hudson/maven/MavenEmptyModuleTest.java trunk/hudson/main/test/src/test/resources/hudson/maven/maven-empty-mod.zip trunk/www/changelog.html http://fisheye4.cenqua.com/changelog/hudson/?cs=21610 Log: [FIXED JENKINS-4442] Empty or whitespace-only modules are now properly ignored by POM parser

            abayer Andrew Bayer
            kutzi kutzi
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

              Created:
              Updated:
              Resolved: