Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44538

Blue Ocean organization displayName not being exposed or used

    XMLWordPrintable

Details

    • Blue Ocean 1.1

    Description

      Blue Ocean organizations have a name and display name. But only name seems to be exposed and used for the front-end.

      This is the result of https://ci.blueocean.io/blue/rest/organizations/ where organization name and display name are both exposed as name.

      [
          {
              "_class": "io.jenkins.blueocean.service.embedded.rest.OrganizationImpl",
              "_links": {
                  "pipelines": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/pipelines/"
                  },
                  "self": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/"
                  },
                  "user": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/user/"
                  },
                  "users": {
                      "_class": "io.jenkins.blueocean.rest.hal.Link",
                      "href": "/blue/rest/organizations/jenkins/users/"
                  }
              },
              "name":"jenkins",
              "name":"Jenkins"
          }
      ]
      

      Caused by this line:
      https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18

      Also the frontend seems to be using the name for everything:
      https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73

      The main page displays "jenkins" instead of "Jenkins"

      Attachments

        Activity

          jamesdumay James Dumay added a comment -

          alobato what is the improvement you are describing here? This ticket doesn't have any actionable information.

          jamesdumay James Dumay added a comment - alobato what is the improvement you are describing here? This ticket doesn't have any actionable information.
          alobato Alvaro Lobato added a comment - - edited

          jamesdumay after looking more deeply into this, the problem is that the displayName is not being used. It exists as an attribute to the organization, defaulting to "Jenkins" and name "jenkins", but it isn't used and also it is wrongly exposed through the API as name:

          This is the result of: https://ci.blueocean.io/blue/rest/organizations/

          [
              {
                  "_class": "io.jenkins.blueocean.service.embedded.rest.OrganizationImpl",
                  "_links": {
                      "pipelines": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/pipelines/"
                      },
                      "self": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/"
                      },
                      "user": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/user/"
                      },
                      "users": {
                          "_class": "io.jenkins.blueocean.rest.hal.Link",
                          "href": "/blue/rest/organizations/jenkins/users/"
                      }
                  },
                  "name":"jenkins",
                  "name":"Jenkins"
              }
          ]
          

          Caused by this line:
          https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18

          Also the frontend seems to be using the name for everything:
          https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73

          I'll re-frase the description.

          alobato Alvaro Lobato added a comment - - edited jamesdumay after looking more deeply into this, the problem is that the displayName is not being used. It exists as an attribute to the organization, defaulting to "Jenkins" and name "jenkins", but it isn't used and also it is wrongly exposed through the API as name: This is the result of: https://ci.blueocean.io/blue/rest/organizations/ [ { "_class" : "io.jenkins.blueocean.service.embedded. rest .OrganizationImpl" , "_links" : { "pipelines" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/pipelines/" }, "self" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/" }, "user" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/user/" }, "users" : { "_class" : "io.jenkins.blueocean. rest .hal.Link" , "href" : "/blue/ rest /organizations/jenkins/users/" } }, "name" : "jenkins" , "name" : "Jenkins" } ] Caused by this line: https://github.com/jenkinsci/blueocean-plugin/blob/80627f6dcbcec4c8535cc15c3bfbc6597fdb1ced/blueocean-rest/src/main/java/io/jenkins/blueocean/rest/model/BlueOrganization.java#L18 Also the frontend seems to be using the name for everything: https://github.com/jenkinsci/blueocean-plugin/blob/fb065140166674ee4720e5b81b85923f95257e55/blueocean-dashboard/src/main/js/components/PipelineRowItem.jsx#L73 I'll re-frase the description.
          michaelneale Michael Neale added a comment -

          ah vivek  - if that json above is legit, that is a duplicate name being returned (presumably the second one is meant to be displayName... ??

          michaelneale Michael Neale added a comment - ah vivek  - if that json above is legit, that is a duplicate name being returned (presumably the second one is meant to be displayName... ??
          jamesdumay James Dumay added a comment -

          alobato I've split the frontend work out into JENKINS-44595.

          jamesdumay James Dumay added a comment - alobato I've split the frontend work out into JENKINS-44595 .

          People

            vivek Vivek Pandey
            alobato Alvaro Lobato
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: