Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44619

ReplayAction should check Job.isBuildable

XMLWordPrintable

      ReplayAction.isEnabled ought to check Job.isBuildable so that we do not offer to replay a disabled job, a dead branch project, etc. (Probably doRun should also report an HTTP error if run returns null, as it would for an unbuildable job among other cases.)

          [JENKINS-44619] ReplayAction should check Job.isBuildable

          Jesse Glick created issue -

          Jesse Glick added a comment -

          More salient after JENKINS-27299.

          Jesse Glick added a comment - More salient after  JENKINS-27299 .
          Jesse Glick made changes -
          Link New: This issue blocks JENKINS-27299 [ JENKINS-27299 ]
          James Dumay made changes -
          Labels New: cloudbees-internal-pipeline
          Andrew Bayer made changes -
          Assignee New: Andrew Bayer [ abayer ]
          Andrew Bayer made changes -
          Status Original: Open [ 1 ] New: In Progress [ 3 ]
          Andrew Bayer made changes -
          Status Original: In Progress [ 3 ] New: In Review [ 10005 ]

          Andrew Bayer added a comment -

          PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/173

          Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/173
          Andrew Bayer made changes -
          Remote Link New: This issue links to "PR #173 (Web Link)" [ 17723 ]

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Andrew Bayer
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java
          src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java
          http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e
          Log:
          [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e Log: [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs

            abayer Andrew Bayer
            jglick Jesse Glick
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: