Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44619

ReplayAction should check Job.isBuildable

    XMLWordPrintable

Details

    Description

      ReplayAction.isEnabled ought to check Job.isBuildable so that we do not offer to replay a disabled job, a dead branch project, etc. (Probably doRun should also report an HTTP error if run returns null, as it would for an unbuildable job among other cases.)

      Attachments

        Issue Links

          blocks

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27299 Refactor Disable Build feature out of AbstractProject for Pipeline Compatibility

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          links to

          Web Link CloudBees Internal CJP-7354

          Web Link PR #173

          Activity

            Ascending order - Click to sort in descending order
            jglick Jesse Glick created issue -
            jglick Jesse Glick added a comment -

            More salient after JENKINS-27299.

            jglick Jesse Glick added a comment - More salient after  JENKINS-27299 .
            jglick Jesse Glick made changes -
            Field Original Value New Value
            Link This issue blocks JENKINS-27299 [ JENKINS-27299 ]
            jamesdumay James Dumay made changes -
            Labels cloudbees-internal-pipeline
            abayer Andrew Bayer made changes -
            Assignee Andrew Bayer [ abayer ]
            abayer Andrew Bayer made changes -
            Status Open [ 1 ] In Progress [ 3 ]
            abayer Andrew Bayer made changes -
            Status In Progress [ 3 ] In Review [ 10005 ]
            abayer Andrew Bayer added a comment -

            PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/173

            abayer Andrew Bayer added a comment - PR up at https://github.com/jenkinsci/workflow-cps-plugin/pull/173
            abayer Andrew Bayer made changes -
            Remote Link This issue links to "PR #173 (Web Link)" [ 17723 ]
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Andrew Bayer
            Path:
            pom.xml
            src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java
            src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java
            http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e
            Log:
            [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs

            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Andrew Bayer Path: pom.xml src/main/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayAction.java src/test/java/org/jenkinsci/plugins/workflow/cps/replay/ReplayActionTest.java http://jenkins-ci.org/commit/workflow-cps-plugin/42f668240d5827e544768311b33b6da0fd4fb59e Log: [FIXED JENKINS-44619] Don't allow replays of nonbuildable jobs
            abayer Andrew Bayer added a comment -

            Merged, will be in next release (presumably 2.42)

            abayer Andrew Bayer added a comment - Merged, will be in next release (presumably 2.42)
            abayer Andrew Bayer made changes -
            Resolution Fixed [ 1 ]
            Status In Review [ 10005 ] Resolved [ 5 ]
            cloudbees CloudBees Inc. made changes -
            Remote Link This issue links to "CloudBees Internal CJP-7354 (Web Link)" [ 19060 ]

            People

              abayer Andrew Bayer
              jglick Jesse Glick
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: