• Icon: Bug Bug
    • Resolution: Cannot Reproduce
    • Icon: Critical Critical
    • None
    • Jenkins 2.46.3, CentOS 7, matrix-combinations-parameter 1.2.0, matrix-project 1.11

      If I select only one parameter, immediate crash. If I don't, it does canary build, then crashes.

      I rolled back to 1.1.0 and it works now, so definitely something new from 1.1.0 to 1.2.0.

      Triggering JOBNAME ยป PARAM_value1
      FATAL: null
      java.lang.NullPointerException
      	at java.util.HashSet.<init>(HashSet.java:118)
      	at hudson.model.ParametersAction.shouldSchedule(ParametersAction.java:228)
      	at hudson.model.Queue.scheduleInternal(Queue.java:615)
      	at hudson.model.Queue.schedule2(Queue.java:585)
      	at hudson.matrix.MatrixConfiguration.scheduleBuild(MatrixConfiguration.java:512)
      	at hudson.matrix.DefaultMatrixExecutionStrategyImpl.scheduleConfigurationBuild(DefaultMatrixExecutionStrategyImpl.java:247)
      	at hudson.matrix.DefaultMatrixExecutionStrategyImpl.run(DefaultMatrixExecutionStrategyImpl.java:159)
      	at hudson.matrix.MatrixBuild$MatrixBuildExecution.doRun(MatrixBuild.java:364)
      	at hudson.model.AbstractBuild$AbstractBuildExecution.run(AbstractBuild.java:534)
      	at hudson.model.Run.execute(Run.java:1728)
      	at hudson.matrix.MatrixBuild.run(MatrixBuild.java:313)
      	at hudson.model.ResourceController.execute(ResourceController.java:98)
      	at hudson.model.Executor.run(Executor.java:405)

          [JENKINS-44719] NPE with Matrix Combination 1.2.0

          ikedam added a comment -

          aarondmarasco_vsi
          I cannot get what you mean with "touchstone build".
          Or, you meant there are two different behaviors and please attach both logs (If I select only one parameter, immediate crash. If I don't, it does canary build, then crashes).

          Your project looks have many configured items (envinject, description-setter), and please try isolate the cause.
          Especially I want to know:

          • Whether the problem reproduces when you triggered the project directly, not via the upstream project.
            • If it happens only when triggered via the upstream, we have to have look also on the upstream configuration.
          • Whether the problem reproduces even without envinject or description-setter.

          ikedam added a comment - aarondmarasco_vsi I cannot get what you mean with "touchstone build". Or, you meant there are two different behaviors and please attach both logs (If I select only one parameter, immediate crash. If I don't, it does canary build, then crashes). Your project looks have many configured items (envinject, description-setter), and please try isolate the cause. Especially I want to know: Whether the problem reproduces when you triggered the project directly, not via the upstream project. If it happens only when triggered via the upstream, we have to have look also on the upstream configuration. Whether the problem reproduces even without envinject or description-setter.

          ikedam added a comment -

          There're two ParametersAction in build.xml, and it look strange to me.
          But I'm not sure what caused it, and whether it causes this issue.

          ikedam added a comment - There're two ParametersAction in build.xml, and it look strange to me. But I'm not sure what caused it, and whether it causes this issue.

          The "touchstone build" is the Matrix option where you put in boolean parameters, e.g. COMPONENT=="file_write_demux" as a filter. I'm pretty sure it is part of the standard matrix option. So that succeeds and then when it tries to iterate across the other axis values it will crash.

           

          Unfortunately, we have very little resources and I cannot keep breaking the builds, sorry. The EnvInject is absolutely required for the build. I can answer specific questions about the config, but for now I need to stick with 1.1.0.

          Aaron D. Marasco added a comment - The "touchstone build" is the Matrix option where you put in boolean parameters, e.g. COMPONENT=="file_write_demux" as a filter. I'm pretty sure it is part of the standard matrix option. So that succeeds and then when it tries to iterate across the other axis values it will crash.   Unfortunately, we have very little resources and I cannot keep breaking the builds, sorry. The EnvInject is absolutely required for the build. I can answer specific questions about the config, but for now I need to stick with 1.1.0.

          ikedam added a comment -

          aarondmarasco_vsi
          I tried touchstone build, but I cannot reproduce the issue yet.
          Can you attach build.xml of touchstone builds?

          And please let me know how do you define DESCRIPTION_SETTER_DESCRIPTION parameter.
          It looks defined in a strange way to me.

          ikedam added a comment - aarondmarasco_vsi I tried touchstone build, but I cannot reproduce the issue yet. Can you attach build.xml of touchstone builds? And please let me know how do you define DESCRIPTION_SETTER_DESCRIPTION parameter. It looks defined in a strange way to me.

          ikedam added a comment -

          Looks like using pre-scm-buildstep plugin

          ikedam added a comment - Looks like using pre-scm-buildstep plugin

          Yes, it's pre-SCM.

          Aaron D. Marasco added a comment - Yes, it's pre-SCM.

          Cannot lock a comment to a specific user and do not want to publicly post the full configuration. Emailed.

          Aaron D. Marasco added a comment - Cannot lock a comment to a specific user and do not want to publicly post the full configuration. Emailed.

          ikedam added a comment -

          ikedam added a comment - The stacktrace happens here: https://github.com/jenkinsci/jenkins/blob/jenkins-2.46.3/core/src/main/java/hudson/model/ParametersAction.java#L228 http://hg.openjdk.java.net/jdk8/jdk8/jdk/file/687fd7c7986d/src/share/classes/java/util/HashSet.java#l118 This means ParametersAction.parameter is set to null, that is, ParametersAction is initialized with null. This is definitely not an issue of matrix-combinations-plugin, as matrix-combinations never handles ParametersAction. In other words, it never can do that. And there are not so many changes between matrix-combinations 1.1.0 and 1.2.0, and I don't think it happens only with 1.2.0. I believe this issue happens with combinations of plugins, and caused by some undeterministic behaviors. It looks rather the issue of MatrixChildParametersAction: https://github.com/jenkinsci/matrix-project-plugin/blob/matrix-project-1.11/src/main/java/hudson/matrix/MatrixChildParametersAction.java I can reproduce the NPE with the following script in Script Console: import hudson.matrix.*; def pp = Jenkins.instance.getItem("testmatrix"); def pb = pp.getBuildByNumber(1); def c = new Combination(pp.axes, "value1"); def actions = pb.getExactRun(c).getAction(ParametersAction.class); actions.shouldSchedule([]); But I could not reproduce the NPE with operations on GUI.

          ikedam added a comment -

          aarondmarasco_vsi

          Unfortunately, I could not reproduce the issue though I tried various combinations of configurations.
          I cannot do anything unless I can reproduce the issue my environment.
          And your configuration is too complicated to find the root cause.

          Please reopen the ticket if you find the least exact steps to reproduce the issue.

          ikedam added a comment - aarondmarasco_vsi Unfortunately, I could not reproduce the issue though I tried various combinations of configurations. I cannot do anything unless I can reproduce the issue my environment. And your configuration is too complicated to find the root cause. Please reopen the ticket if you find the least exact steps to reproduce the issue.

          Appreciate the time you put into it; thanks. I duped to JENKINS-44994 for the main matrix plugin with a specific link to your debugging work.

          Aaron D. Marasco added a comment - Appreciate the time you put into it; thanks. I duped to JENKINS-44994 for the main matrix plugin with a specific link to your debugging work.

            aarondmarasco_vsi Aaron D. Marasco
            aarondmarasco_vsi Aaron D. Marasco
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: