Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-44851

Launch agents on Java 7 from Jenkins 2.60 fails without clear message

      Launching Jenkins 2.60 agents on Java 7 should fail with a controlled exception but it is not. The channel is just closed currently without further notice.

      This code needs fix.

      Flagged as LTS candidate as I suspect it will cause pain to users.

          [JENKINS-44851] Launch agents on Java 7 from Jenkins 2.60 fails without clear message

          Jesse Glick added a comment -

          Fine for Windows agents. For SSH agents we are apparently using a custom implementation which checks for Java 5!

          Jesse Glick added a comment - Fine for Windows agents . For SSH agents we are apparently using a custom implementation  which checks for Java 5 !

          jglick ssh-slaves should check for Java 7, right? - as its baseline is 1.625. Or just remove the default implementation.

          Antonio Muñiz added a comment - jglick ssh-slaves should check for Java 7, right? - as its baseline is 1.625. Or just remove the default implementation.

          Daniel Beck added a comment -

          Daniel Beck added a comment - For SSH Slaves, I tried, and failed, in https://github.com/jenkinsci/ssh-slaves-plugin/pull/27#issuecomment-304837590 – CC oleg_nenashev .

          Jesse Glick added a comment -

          ssh-slaves should check for Java 7, right? - as its baseline is 1.625

          No, because when it is running on 2.54+, it ought to be requiring 8. That is why it should be using the core check, and the core check should be fixed.

          Jesse Glick added a comment - ssh-slaves should check for Java 7, right? - as its baseline is 1.625 No, because when it is running on 2.54+, it ought to be requiring 8. That is why it should be using the core check, and the core check should be fixed.

          Code changed in jenkins
          User: Antonio Muniz
          Path:
          core/src/main/java/hudson/slaves/ComputerLauncher.java
          core/src/main/resources/hudson/slaves/Messages.properties
          core/src/test/java/hudson/slaves/ComputerLauncherTest.java
          http://jenkins-ci.org/commit/jenkins/f546ffc9ea09626e2e15bd4d9564ee32da18335d
          Log:
          JENKINS-44851 Agents JVM must be 1.8+ now (#2915)

          • Fix old Java 6 and 7 tests (an exception is expected now)
          • Add new tests to Java 8
          • Fix messages

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Antonio Muniz Path: core/src/main/java/hudson/slaves/ComputerLauncher.java core/src/main/resources/hudson/slaves/Messages.properties core/src/test/java/hudson/slaves/ComputerLauncherTest.java http://jenkins-ci.org/commit/jenkins/f546ffc9ea09626e2e15bd4d9564ee32da18335d Log: JENKINS-44851 Agents JVM must be 1.8+ now (#2915) JENKINS-44851 Agents JVM must be 1.8+ now JENKINS-44851 Fix tests Fix old Java 6 and 7 tests (an exception is expected now) Add new tests to Java 8 Fix messages

            amuniz Antonio Muñiz
            amuniz Antonio Muñiz
            Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

              Created:
              Updated:
              Resolved: