Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45130

When ambiguous classes are in a list / array they are given their simple name not FQCN

XMLWordPrintable

    • Icon: New Feature New Feature
    • Resolution: Fixed
    • Icon: Minor Minor
    • structs-plugin
    • None

      When determining if an instance of a parameter needs a simple name or a FQCN, the JENKINS-43337 fix uses the erased type of the parameter which will fail for the cases where the parameter is a container parameter such as a List or Array, instead the erased type of the container's generic parameter should be used as there will be no instances of type `List` or `[]` so the simple name will be used always

          [JENKINS-45130] When ambiguous classes are in a list / array they are given their simple name not FQCN

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AbstractSharedName.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousArrayContainer.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousListContainer.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/first/SharedName.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/second/SharedName.java
          http://jenkins-ci.org/commit/structs-plugin/d89586ea96d95602f6e5ce879c289e284b131cb6
          Log:
          JENKINS-45130 Add tests to demonstrate issue

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AbstractSharedName.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousArrayContainer.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousListContainer.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/first/SharedName.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/second/SharedName.java http://jenkins-ci.org/commit/structs-plugin/d89586ea96d95602f6e5ce879c289e284b131cb6 Log: JENKINS-45130 Add tests to demonstrate issue

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java
          http://jenkins-ci.org/commit/structs-plugin/9585e086ee2732408b8efc7222b74518f0a5b33b
          Log:
          [FIXED JENKINS-45130] Ambiguous classes in list / array need their FQCN

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java http://jenkins-ci.org/commit/structs-plugin/9585e086ee2732408b8efc7222b74518f0a5b33b Log: [FIXED JENKINS-45130] Ambiguous classes in list / array need their FQCN

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AbstractSharedName.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousArrayContainer.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousListContainer.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/first/SharedName.java
          plugin/src/test/java/org/jenkinsci/plugins/structs/describable/second/SharedName.java
          http://jenkins-ci.org/commit/structs-plugin/2e73ba892889b438fe885f86ad3153a2d92713cd
          Log:
          Merge pull request #22 from stephenc/jenkins-45130

          JENKINS-45130 Ambiguous classes in list / array need their FQCN

          Compare: https://github.com/jenkinsci/structs-plugin/compare/50278b74c005...2e73ba892889

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: plugin/src/main/java/org/jenkinsci/plugins/structs/describable/DescribableParameter.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AbstractSharedName.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousArrayContainer.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/AmbiguousListContainer.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/DescribableModelTest.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/first/SharedName.java plugin/src/test/java/org/jenkinsci/plugins/structs/describable/second/SharedName.java http://jenkins-ci.org/commit/structs-plugin/2e73ba892889b438fe885f86ad3153a2d92713cd Log: Merge pull request #22 from stephenc/jenkins-45130 JENKINS-45130 Ambiguous classes in list / array need their FQCN Compare: https://github.com/jenkinsci/structs-plugin/compare/50278b74c005...2e73ba892889

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java
          src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java
          src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java
          http://jenkins-ci.org/commit/github-branch-source-plugin/b35932383d8d4cd7185dfd1bd8e3c41c03d31b23
          Log:
          JENKINS-43507 Fresh eyes find and fix fresh bugs

          • Need to upgrade to structs 1.9 to pick up JENKINS-45130
          • Two legacy setters were not purging useless traits, and we were missing tests to verify same
          • Pick up git's -alpha-4

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigator.java src/main/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSource.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMNavigatorTraitsTest.java src/test/java/org/jenkinsci/plugins/github_branch_source/GitHubSCMSourceTraitsTest.java http://jenkins-ci.org/commit/github-branch-source-plugin/b35932383d8d4cd7185dfd1bd8e3c41c03d31b23 Log: JENKINS-43507 Fresh eyes find and fix fresh bugs Need to upgrade to structs 1.9 to pick up JENKINS-45130 Two legacy setters were not purging useless traits, and we were missing tests to verify same Pick up git's -alpha-4

            stephenconnolly Stephen Connolly
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: