LocalBackup has bogus timezone handling logic

XMLWordPrintable

      We just noticed it in functional tests. According to the investigation, LocalDirectory#retrieveBackupFromLocation fails to retrieve backups in some cases, because the expected file name in the File filter differs from the actual one by one hour.

      User impact needs to be investigated.

      [ERROR] testRetrieveBackupFromLocation(org.jenkinsci.plugins.periodicbackup.LocalDirectoryTest)  Time elapsed: 0.707 s  <<< ERROR!
org.jenkinsci.plugins.periodicbackup.PeriodicBackupException: Backup archives do not exist in /Users/stephenc/tmp/periodicbackup-plugin/target/test-classes/data
	at org.jenkinsci.plugins.periodicbackup.LocalDirectory.retrieveBackupFromLocation(LocalDirectory.java:126)
	at org.jenkinsci.plugins.periodicbackup.LocalDirectoryTest.testRetrieveBackupFromLocation(LocalDirectoryTest.java:69)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:498)
	at junit.framework.TestCase.runTest(TestCase.java:176)
	at org.jvnet.hudson.test.HudsonTestCase.runTest(HudsonTestCase.java:453)
	at junit.framework.TestCase.runBare(TestCase.java:141)
	at org.jvnet.hudson.test.HudsonTestCase.runBare(HudsonTestCase.java:287)
	at junit.framework.TestResult$1.protect(TestResult.java:122)
	at junit.framework.TestResult.runProtected(TestResult.java:142)
	at junit.framework.TestResult.run(TestResult.java:125)
	at junit.framework.TestCase.run(TestCase.java:129)
	at junit.framework.TestSuite.runTest(TestSuite.java:252)
	at junit.framework.TestSuite.run(TestSuite.java:247)
	at org.junit.internal.runners.JUnit38ClassRunner.run(JUnit38ClassRunner.java:86)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeFailedMethod(JUnit4Provider.java:379)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeWithRerun(JUnit4Provider.java:290)
	at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:236)
	at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:159)
	at org.apache.maven.surefire.booter.ForkedBooter.invokeProviderInSameClassLoader(ForkedBooter.java:386)
	at org.apache.maven.surefire.booter.ForkedBooter.runSuitesInProcess(ForkedBooter.java:323)
	at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:143)

            Assignee:
            Unassigned
            Reporter:
            Oleg Nenashev
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated: