Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45540

Refactor id-and-description tear-off

    XMLWordPrintable

Details

    Description

      There is no need for BaseStandardCredentials to require sub-classes to include the `id-and-description` tear-off.

      Much better would be to just override `config.jelly` and put the `id` at the top and the `description` at the bottom in between the include for `credentials.jelly`.

      Should be possible to make this backwards compatible by retaining an empty `id-and-description.jelly`

      Attachments

        Issue Links

          Activity

            jglick Jesse Glick added a comment -

            That would be the better pattern but I think for compatibility you cannot touch id-and-description, just leave it alone but mark as deprecated. Existing subclasses using it would presumably already be overriding config so they would not benefit from the new pattern.

            jglick Jesse Glick added a comment - That would be the better pattern but I think for compatibility you cannot touch id-and-description , just leave it alone but mark as deprecated. Existing subclasses using it would presumably already be overriding config so they would not benefit from the new pattern.

            Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

            stephenconnolly Stephen Connolly added a comment - Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

            People

              Unassigned Unassigned
              stephenconnolly Stephen Connolly
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated: