Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45881

Javascript hoverNotification calls returning error

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • core
    • None

      I've detected that if my default language set by the browser is Catalan, the calls to hoverNotification() return error as some of the messages can contain the apostrophe sign.

      To avoid problems with languages that use this type of signs, messages should be surrounded by quotation marks.

      To reproduce the issue, pass Catalan as preferred language in the headers:

      Accept-Language: ca,en;q=0.8,ca-ES;q=0.6,es;q=0.4

          [JENKINS-45881] Javascript hoverNotification calls returning error

          Oleg Nenashev added a comment -

          I need a full page HTML in order to understand from where it comes

          Oleg Nenashev added a comment - I need a full page HTML in order to understand from where it comes

          Carlos Arnau added a comment -

          Added full page HTML.

          Carlos Arnau added a comment - Added full page HTML.

          Oleg Nenashev added a comment -

          Oleg Nenashev added a comment - It comes from the BuildButtonColumn: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/views/BuildButtonColumn/column.properties . This code has been updated by stephenc in https://github.com/jenkinsci/jenkins/commit/3dbf30f8ef2f9aa789d44a8f206ade35aebbeaf7 ( JENKINS-34522 ). So it should be fixed in Jenkins 2.50+  

          Oleg Nenashev added a comment -

          carnau ping, do you confirm the fix?

          Oleg Nenashev added a comment - carnau ping, do you confirm the fix?

          Carlos Arnau added a comment -

          oleg_nenashev I currently don't have access to any Jenkins 2.50+. I do use Jenkins at work and they don't have plans to update anytime soon, so there is no easy way for me to validate it.

          If there is some kind of Jenkins demo with public access somewhere, I will be happy to help and test it there.

          Carlos Arnau added a comment - oleg_nenashev I currently don't have access to any Jenkins 2.50+. I do use Jenkins at work and they don't have plans to update anytime soon, so there is no easy way for me to validate it. If there is some kind of Jenkins demo with public access somewhere, I will be happy to help and test it there.

          Oleg Nenashev added a comment -

          carnau AFAIK there is no public instance which grants anonymous users the build permission.
          But you can just start the instance on your own, e.g. in Docker. https://jenkins.io/download/

          Oleg Nenashev added a comment - carnau AFAIK there is no public instance which grants anonymous users the build permission. But you can just start the instance on your own, e.g. in Docker. https://jenkins.io/download/

          Carlos Arnau added a comment -

          Tried docker with image jenkins/jenkins:lts, works fine. Feel free to close this issue.

          Carlos Arnau added a comment - Tried docker with image jenkins/jenkins:lts, works fine. Feel free to close this issue.

          Oleg Nenashev added a comment -

          Closing according to the comment above

          Oleg Nenashev added a comment - Closing according to the comment above

            oleg_nenashev Oleg Nenashev
            carnau Carlos Arnau
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: