Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-45881

Javascript hoverNotification calls returning error

    XMLWordPrintable

Details

    • Bug
    • Status: Resolved (View Workflow)
    • Minor
    • Resolution: Fixed
    • core
    • None

    Description

      I've detected that if my default language set by the browser is Catalan, the calls to hoverNotification() return error as some of the messages can contain the apostrophe sign.

      To avoid problems with languages that use this type of signs, messages should be surrounded by quotation marks.

      To reproduce the issue, pass Catalan as preferred language in the headers:

      Accept-Language: ca,en;q=0.8,ca-ES;q=0.6,es;q=0.4

      Attachments

        Issue Links

          Activity

            oleg_nenashev Oleg Nenashev added a comment -

            I need a full page HTML in order to understand from where it comes

            oleg_nenashev Oleg Nenashev added a comment - I need a full page HTML in order to understand from where it comes
            carnau Carlos Arnau added a comment -

            Added full page HTML.

            carnau Carlos Arnau added a comment - Added full page HTML.
            oleg_nenashev Oleg Nenashev added a comment - It comes from the BuildButtonColumn: https://github.com/jenkinsci/jenkins/blob/master/core/src/main/resources/hudson/views/BuildButtonColumn/column.properties . This code has been updated by stephenc in https://github.com/jenkinsci/jenkins/commit/3dbf30f8ef2f9aa789d44a8f206ade35aebbeaf7 ( JENKINS-34522 ). So it should be fixed in Jenkins 2.50+  
            oleg_nenashev Oleg Nenashev added a comment -

            carnau ping, do you confirm the fix?

            oleg_nenashev Oleg Nenashev added a comment - carnau ping, do you confirm the fix?
            carnau Carlos Arnau added a comment -

            oleg_nenashev I currently don't have access to any Jenkins 2.50+. I do use Jenkins at work and they don't have plans to update anytime soon, so there is no easy way for me to validate it.

            If there is some kind of Jenkins demo with public access somewhere, I will be happy to help and test it there.

            carnau Carlos Arnau added a comment - oleg_nenashev I currently don't have access to any Jenkins 2.50+. I do use Jenkins at work and they don't have plans to update anytime soon, so there is no easy way for me to validate it. If there is some kind of Jenkins demo with public access somewhere, I will be happy to help and test it there.
            oleg_nenashev Oleg Nenashev added a comment -

            carnau AFAIK there is no public instance which grants anonymous users the build permission.
            But you can just start the instance on your own, e.g. in Docker. https://jenkins.io/download/

            oleg_nenashev Oleg Nenashev added a comment - carnau AFAIK there is no public instance which grants anonymous users the build permission. But you can just start the instance on your own, e.g. in Docker. https://jenkins.io/download/
            carnau Carlos Arnau added a comment -

            Tried docker with image jenkins/jenkins:lts, works fine. Feel free to close this issue.

            carnau Carlos Arnau added a comment - Tried docker with image jenkins/jenkins:lts, works fine. Feel free to close this issue.
            oleg_nenashev Oleg Nenashev added a comment -

            Closing according to the comment above

            oleg_nenashev Oleg Nenashev added a comment - Closing according to the comment above

            People

              oleg_nenashev Oleg Nenashev
              carnau Carlos Arnau
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: