Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46132

All Agents have the same Proc Info which is Master's Proc Info

XMLWordPrintable

      1. Add a few agents to the instance
      2. Generate the support bundle
      3. Compare `proc/self/cmdline` of the `nodes/master` and any of the `nodes/slave/*`

      Expected: They are different

      Actual: They are identical

          [JENKINS-46132] All Agents have the same Proc Info which is Master's Proc Info

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Denys Digtiar
          Path:
          src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java
          src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java
          src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java
          http://jenkins-ci.org/commit/support-core-plugin/a1b81f201d652c9fb5b010c7f7943d31195e1b41
          Log:
          JENKINS-46132 - Download actual proc info from the Linux agents

          FileContent which was using Master's files for all the agents is
          replaced with FilePathContent which loads actual info via remoting.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Denys Digtiar Path: src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java http://jenkins-ci.org/commit/support-core-plugin/a1b81f201d652c9fb5b010c7f7943d31195e1b41 Log: JENKINS-46132 - Download actual proc info from the Linux agents FileContent which was using Master's files for all the agents is replaced with FilePathContent which loads actual info via remoting.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Denys Digtiar
          Path:
          src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java
          http://jenkins-ci.org/commit/support-core-plugin/b28c11e9ff8d91e0e7e22c6d1d980ab46dafe5f6
          Log:
          JENKINS-46132 - Bring FileContent and FilePathContent closer.

          `FileContent` handles the `FileNotFoundException` gracefully while
          `FilePathContent` wasn't doing it. This resulted in a number of warning
          logged which is breaking `SupportActionTest` which expects none.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Denys Digtiar Path: src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java http://jenkins-ci.org/commit/support-core-plugin/b28c11e9ff8d91e0e7e22c6d1d980ab46dafe5f6 Log: JENKINS-46132 - Bring FileContent and FilePathContent closer. `FileContent` handles the `FileNotFoundException` gracefully while `FilePathContent` wasn't doing it. This resulted in a number of warning logged which is breaking `SupportActionTest` which expects none.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Denys Digtiar
          Path:
          Jenkinsfile
          pom.xml
          src/main/java/com/cloudbees/jenkins/support/AsyncResultCache.java
          src/main/java/com/cloudbees/jenkins/support/SupportAction.java
          src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java
          src/main/java/com/cloudbees/jenkins/support/api/CommandOutputContent.java
          src/main/java/com/cloudbees/jenkins/support/api/Component.java
          src/main/java/com/cloudbees/jenkins/support/configfiles/AgentsConfigFile.java
          src/main/java/com/cloudbees/jenkins/support/configfiles/ConfigFileComponent.java
          src/main/java/com/cloudbees/jenkins/support/configfiles/OtherConfigFilesComponent.java
          src/main/java/com/cloudbees/jenkins/support/impl/AboutJenkins.java
          src/main/java/com/cloudbees/jenkins/support/impl/BuildQueue.java
          src/main/java/com/cloudbees/jenkins/support/impl/DumpExportTable.java
          src/main/java/com/cloudbees/jenkins/support/impl/EnvironmentVariables.java
          src/main/java/com/cloudbees/jenkins/support/impl/FileDescriptorLimit.java
          src/main/java/com/cloudbees/jenkins/support/impl/HeapUsageHistogram.java
          src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java
          src/main/java/com/cloudbees/jenkins/support/impl/LoadStats.java
          src/main/java/com/cloudbees/jenkins/support/impl/Metrics.java
          src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java
          src/main/java/com/cloudbees/jenkins/support/impl/NodeMonitors.java
          src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java
          src/main/java/com/cloudbees/jenkins/support/impl/RootCAs.java
          src/main/java/com/cloudbees/jenkins/support/impl/SlaveLaunchLogs.java
          src/main/java/com/cloudbees/jenkins/support/impl/SlaveLogs.java
          src/main/java/com/cloudbees/jenkins/support/impl/SmartLogFetcher.java
          src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java
          src/main/java/com/cloudbees/jenkins/support/impl/SystemProperties.java
          src/main/java/com/cloudbees/jenkins/support/impl/ThreadDumps.java
          src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java
          src/main/java/com/cloudbees/jenkins/support/slowrequest/SlowRequestChecker.java
          src/main/java/com/cloudbees/jenkins/support/slowrequest/SlowRequestFilter.java
          src/main/java/com/cloudbees/jenkins/support/timer/DeadlockTrackChecker.java
          src/main/java/com/cloudbees/jenkins/support/util/Helper.java
          src/main/java/com/cloudbees/jenkins/support/util/SystemPlatform.java
          http://jenkins-ci.org/commit/support-core-plugin/735f1b2034000ec32376d08a2d72ddc067bd6d12
          Log:
          Merge branch 'master' into JENKINS-46132

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Denys Digtiar Path: Jenkinsfile pom.xml src/main/java/com/cloudbees/jenkins/support/AsyncResultCache.java src/main/java/com/cloudbees/jenkins/support/SupportAction.java src/main/java/com/cloudbees/jenkins/support/SupportPlugin.java src/main/java/com/cloudbees/jenkins/support/api/CommandOutputContent.java src/main/java/com/cloudbees/jenkins/support/api/Component.java src/main/java/com/cloudbees/jenkins/support/configfiles/AgentsConfigFile.java src/main/java/com/cloudbees/jenkins/support/configfiles/ConfigFileComponent.java src/main/java/com/cloudbees/jenkins/support/configfiles/OtherConfigFilesComponent.java src/main/java/com/cloudbees/jenkins/support/impl/AboutJenkins.java src/main/java/com/cloudbees/jenkins/support/impl/BuildQueue.java src/main/java/com/cloudbees/jenkins/support/impl/DumpExportTable.java src/main/java/com/cloudbees/jenkins/support/impl/EnvironmentVariables.java src/main/java/com/cloudbees/jenkins/support/impl/FileDescriptorLimit.java src/main/java/com/cloudbees/jenkins/support/impl/HeapUsageHistogram.java src/main/java/com/cloudbees/jenkins/support/impl/JenkinsLogs.java src/main/java/com/cloudbees/jenkins/support/impl/LoadStats.java src/main/java/com/cloudbees/jenkins/support/impl/Metrics.java src/main/java/com/cloudbees/jenkins/support/impl/NetworkInterfaces.java src/main/java/com/cloudbees/jenkins/support/impl/NodeMonitors.java src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java src/main/java/com/cloudbees/jenkins/support/impl/RootCAs.java src/main/java/com/cloudbees/jenkins/support/impl/SlaveLaunchLogs.java src/main/java/com/cloudbees/jenkins/support/impl/SlaveLogs.java src/main/java/com/cloudbees/jenkins/support/impl/SmartLogFetcher.java src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java src/main/java/com/cloudbees/jenkins/support/impl/SystemProperties.java src/main/java/com/cloudbees/jenkins/support/impl/ThreadDumps.java src/main/java/com/cloudbees/jenkins/support/impl/UpdateCenter.java src/main/java/com/cloudbees/jenkins/support/slowrequest/SlowRequestChecker.java src/main/java/com/cloudbees/jenkins/support/slowrequest/SlowRequestFilter.java src/main/java/com/cloudbees/jenkins/support/timer/DeadlockTrackChecker.java src/main/java/com/cloudbees/jenkins/support/util/Helper.java src/main/java/com/cloudbees/jenkins/support/util/SystemPlatform.java http://jenkins-ci.org/commit/support-core-plugin/735f1b2034000ec32376d08a2d72ddc067bd6d12 Log: Merge branch 'master' into JENKINS-46132

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Denys Digtiar
          Path:
          src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java
          http://jenkins-ci.org/commit/support-core-plugin/8ad5d1db9131b2973c4588359a6b22e50469e8bc
          Log:
          JENKINS-46132 - Fix the test for 2.88.1 baseline.

          The underlying implementation of some of the the FilePath functionality
          have changed to NIO. Therefore a `NoSuchFileException` is thrown instead
          of the `FileNotFoundException` when file is missing. `FilePathContent`
          is update to handle both in the same way. `FileContent` has not been
          update since it is still using the old File IO.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Denys Digtiar Path: src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java http://jenkins-ci.org/commit/support-core-plugin/8ad5d1db9131b2973c4588359a6b22e50469e8bc Log: JENKINS-46132 - Fix the test for 2.88.1 baseline. The underlying implementation of some of the the FilePath functionality have changed to NIO. Therefore a `NoSuchFileException` is thrown instead of the `FileNotFoundException` when file is missing. `FilePathContent` is update to handle both in the same way. `FileContent` has not been update since it is still using the old File IO.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Denys Digtiar
          Path:
          src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java
          http://jenkins-ci.org/commit/support-core-plugin/2191eac4054a05b8061c72d30cec43cef5c15b22
          Log:
          JENKINS-46132 - Wildcard imports are unrolled.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Denys Digtiar Path: src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java http://jenkins-ci.org/commit/support-core-plugin/2191eac4054a05b8061c72d30cec43cef5c15b22 Log: JENKINS-46132 - Wildcard imports are unrolled.

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Steven Christou
          Path:
          src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java
          src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java
          src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java
          src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java
          http://jenkins-ci.org/commit/support-core-plugin/2130103a81556280d6bbf9239be2b6f9fd89b37c
          Log:
          Merge pull request #114 from duemir/JENKINS-46132

          JENKINS-46132 - Download actual proc info from the Linux agents

          Compare: https://github.com/jenkinsci/support-core-plugin/compare/1e4d1898dc2a...2130103a8155

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Steven Christou Path: src/main/java/com/cloudbees/jenkins/support/api/FilePathContent.java src/main/java/com/cloudbees/jenkins/support/impl/JVMProcessSystemMetricsContents.java src/main/java/com/cloudbees/jenkins/support/impl/ProcFilesRetriever.java src/main/java/com/cloudbees/jenkins/support/impl/SystemConfiguration.java http://jenkins-ci.org/commit/support-core-plugin/2130103a81556280d6bbf9239be2b6f9fd89b37c Log: Merge pull request #114 from duemir/ JENKINS-46132 JENKINS-46132 - Download actual proc info from the Linux agents Compare: https://github.com/jenkinsci/support-core-plugin/compare/1e4d1898dc2a...2130103a8155

          Denys Digtiar added a comment -

          PR is merged. Awaiting release.

          Denys Digtiar added a comment - PR is merged. Awaiting release.

            duemir Denys Digtiar
            duemir Denys Digtiar
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: