• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Platform: All, OS: All

      Although I have the Include culprits option checked for Unstable builds, the
      emails still only go to the global + committer, but not the culprits.

          [JENKINS-4617] "Include culprits" option not working

          Alan Harder added a comment -

          m211, that change is only in the "if (upstreamCulprits)" block.. have you tested the simple case where there is no upstream job?

          Alan Harder added a comment - m211, that change is only in the "if (upstreamCulprits)" block.. have you tested the simple case where there is no upstream job?

          m211 added a comment -

          yes it works also for the simple case without any upstream job.

          m211 added a comment - yes it works also for the simple case without any upstream job.

          Code changed in jenkins
          User: marco
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26
          Log:
          JENKINS-4617
          we are looking for dependencies since the last successful build
          and not since the last previous not failed build

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: marco Path: core/src/main/java/hudson/model/AbstractBuild.java http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26 Log: JENKINS-4617 we are looking for dependencies since the last successful build and not since the last previous not failed build

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractBuild.java
          test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java
          test/src/test/groovy/hudson/model/AbstractBuildTest.groovy
          http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc
          Log:
          [FIXED JENKINS-4617]
          this and the previous commit constitutes the fix.
          Also added a test case.

          Compare: https://github.com/jenkinsci/jenkins/compare/ad646cd...e761d80

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/AbstractBuild.java test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java test/src/test/groovy/hudson/model/AbstractBuildTest.groovy http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc Log: [FIXED JENKINS-4617] this and the previous commit constitutes the fix. Also added a test case. Compare: https://github.com/jenkinsci/jenkins/compare/ad646cd...e761d80

          dogfood added a comment -

          Integrated in jenkins_main_trunk #683
          JENKINS-4617
          [FIXED JENKINS-4617]

          Kohsuke Kawaguchi : 502219cf1b8be65f91d4ebd81e590558eb8c5b26
          Files :

          • core/src/main/java/hudson/model/AbstractBuild.java

          Kohsuke Kawaguchi : e761d80f4d53a0f368fa8e9fbb06f01db247f8cc
          Files :

          • test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java
          • test/src/test/groovy/hudson/model/AbstractBuildTest.groovy
          • core/src/main/java/hudson/model/AbstractBuild.java
          • changelog.html

          dogfood added a comment - Integrated in jenkins_main_trunk #683 JENKINS-4617 [FIXED JENKINS-4617] Kohsuke Kawaguchi : 502219cf1b8be65f91d4ebd81e590558eb8c5b26 Files : core/src/main/java/hudson/model/AbstractBuild.java Kohsuke Kawaguchi : e761d80f4d53a0f368fa8e9fbb06f01db247f8cc Files : test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java test/src/test/groovy/hudson/model/AbstractBuildTest.groovy core/src/main/java/hudson/model/AbstractBuild.java changelog.html

          Code changed in jenkins
          User: marco
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26
          Log:
          JENKINS-4617
          we are looking for dependencies since the last successful build
          and not since the last previous not failed build

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: marco Path: core/src/main/java/hudson/model/AbstractBuild.java http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26 Log: JENKINS-4617 we are looking for dependencies since the last successful build and not since the last previous not failed build

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractBuild.java
          test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java
          test/src/test/groovy/hudson/model/AbstractBuildTest.groovy
          http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc
          Log:
          [FIXED JENKINS-4617]
          this and the previous commit constitutes the fix.
          Also added a test case.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/AbstractBuild.java test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java test/src/test/groovy/hudson/model/AbstractBuildTest.groovy http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc Log: [FIXED JENKINS-4617] this and the previous commit constitutes the fix. Also added a test case.

          Code changed in jenkins
          User: marco
          Path:
          core/src/main/java/hudson/model/AbstractBuild.java
          http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26
          Log:
          JENKINS-4617
          we are looking for dependencies since the last successful build
          and not since the last previous not failed build

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: marco Path: core/src/main/java/hudson/model/AbstractBuild.java http://jenkins-ci.org/commit/jenkins/502219cf1b8be65f91d4ebd81e590558eb8c5b26 Log: JENKINS-4617 we are looking for dependencies since the last successful build and not since the last previous not failed build

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          changelog.html
          core/src/main/java/hudson/model/AbstractBuild.java
          test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java
          test/src/test/groovy/hudson/model/AbstractBuildTest.groovy
          http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc
          Log:
          [FIXED JENKINS-4617]
          this and the previous commit constitutes the fix.
          Also added a test case.

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: changelog.html core/src/main/java/hudson/model/AbstractBuild.java test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java test/src/test/groovy/hudson/model/AbstractBuildTest.groovy http://jenkins-ci.org/commit/jenkins/e761d80f4d53a0f368fa8e9fbb06f01db247f8cc Log: [FIXED JENKINS-4617] this and the previous commit constitutes the fix. Also added a test case.

          Code changed in jenkins
          User: Kohsuke Kawaguchi
          Path:
          test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java
          http://jenkins-ci.org/commit/jenkins-test-harness/10e915577cde1696703840c9c57014db63b7755f
          Log:
          [FIXED JENKINS-4617]
          this and the previous commit constitutes the fix.
          Also added a test case.

          Originally-Committed-As: e761d80f4d53a0f368fa8e9fbb06f01db247f8cc

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Kohsuke Kawaguchi Path: test/src/main/java/org/jvnet/hudson/test/FakeChangeLogSCM.java http://jenkins-ci.org/commit/jenkins-test-harness/10e915577cde1696703840c9c57014db63b7755f Log: [FIXED JENKINS-4617] this and the previous commit constitutes the fix. Also added a test case. Originally-Committed-As: e761d80f4d53a0f368fa8e9fbb06f01db247f8cc

            markltbaker markltbaker
            mcrooney mcrooney
            Votes:
            6 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: