Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46172

error when I change ssh server settings for authorization

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: ssh-plugin
    • Labels:
      None
    • Similar Issues:

      Description

      java.lang.NullPointerException at org.jvnet.hudson.plugins.CredentialsSSHSite.<init>(CredentialsSSHSite.java:73) at sun.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method) at sun.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:62) at sun.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45) at java.lang.reflect.Constructor.newInstance(Constructor.java:423) at org.kohsuke.stapler.RequestImpl.invokeConstructor(RequestImpl.java:529) at org.kohsuke.stapler.RequestImpl.instantiate(RequestImpl.java:783) at org.kohsuke.stapler.RequestImpl.access$200(RequestImpl.java:83) at org.kohsuke.stapler.RequestImpl$TypePair.convertJSON(RequestImpl.java:678) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:478) at org.kohsuke.stapler.RequestImpl.bindJSON(RequestImpl.java:474) at org.kohsuke.stapler.RequestImpl.bindJSONToList(RequestImpl.java:512) at org.jvnet.hudson.plugins.SSHBuildWrapper$DescriptorImpl.configure(SSHBuildWrapper.java:193) at jenkins.model.Jenkins.configureDescriptor(Jenkins.java:3715) at jenkins.model.Jenkins.doConfigSubmit(Jenkins.java:3677) at java.lang.invoke.MethodHandle.invokeWithArguments(MethodHandle.java:627) at org.kohsuke.stapler.Function$MethodFunction.invoke(Function.java:343) at org.kohsuke.stapler.interceptor.RequirePOST$Processor.invoke(RequirePOST.java:52) at org.kohsuke.stapler.PreInvokeInterceptedFunction.invoke(PreInvokeInterceptedFunction.java:26) at org.kohsuke.stapler.Function.bindAndInvoke(Function.java:184) at org.kohsuke.stapler.Function.bindAndInvokeAndServeResponse(Function.java:117) at org.kohsuke.stapler.MetaClass$1.doDispatch(MetaClass.java:129) at org.kohsuke.stapler.NameBasedDispatcher.dispatch(NameBasedDispatcher.java:58) at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:715) Caused: javax.servlet.ServletException at org.kohsuke.stapler.Stapler.tryInvoke(Stapler.java:765) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:845) at org.kohsuke.stapler.Stapler.invoke(Stapler.java:649) at org.kohsuke.stapler.Stapler.service(Stapler.java:238) at javax.servlet.http.HttpServlet.service(HttpServlet.java:790) at org.eclipse.jetty.servlet.ServletHolder.handle(ServletHolder.java:841) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1650) at hudson.util.PluginServletFilter$1.doFilter(PluginServletFilter.java:135) at hudson.util.PluginServletFilter.doFilter(PluginServletFilter.java:138) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at hudson.security.csrf.CrumbFilter.doFilter(CrumbFilter.java:80) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:84) at hudson.security.UnwrapSecurityExceptionFilter.doFilter(UnwrapSecurityExceptionFilter.java:51) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.ExceptionTranslationFilter.doFilter(ExceptionTranslationFilter.java:117) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.providers.anonymous.AnonymousProcessingFilter.doFilter(AnonymousProcessingFilter.java:125) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.rememberme.RememberMeProcessingFilter.doFilter(RememberMeProcessingFilter.java:142) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.ui.AbstractProcessingFilter.doFilter(AbstractProcessingFilter.java:271) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at jenkins.security.BasicHeaderProcessor.doFilter(BasicHeaderProcessor.java:92) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at org.acegisecurity.context.HttpSessionContextIntegrationFilter.doFilter(HttpSessionContextIntegrationFilter.java:249) at hudson.security.HttpSessionContextIntegrationFilter2.doFilter(HttpSessionContextIntegrationFilter2.java:67) at hudson.security.ChainedServletFilter$1.doFilter(ChainedServletFilter.java:87) at hudson.security.ChainedServletFilter.doFilter(ChainedServletFilter.java:90) at hudson.security.HudsonFilter.doFilter(HudsonFilter.java:171) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.kohsuke.stapler.compression.CompressionFilter.doFilter(CompressionFilter.java:49) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at hudson.util.CharacterEncodingFilter.doFilter(CharacterEncodingFilter.java:82) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.kohsuke.stapler.DiagnosticThreadNameFilter.doFilter(DiagnosticThreadNameFilter.java:30) at org.eclipse.jetty.servlet.ServletHandler$CachedChain.doFilter(ServletHandler.java:1637) at org.eclipse.jetty.servlet.ServletHandler.doHandle(ServletHandler.java:533) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:143) at org.eclipse.jetty.security.SecurityHandler.handle(SecurityHandler.java:524) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:190) at org.eclipse.jetty.server.session.SessionHandler.doHandle(SessionHandler.java:1595) at org.eclipse.jetty.server.handler.ScopedHandler.nextHandle(ScopedHandler.java:188) at org.eclipse.jetty.server.handler.ContextHandler.doHandle(ContextHandler.java:1253) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:168) at org.eclipse.jetty.servlet.ServletHandler.doScope(ServletHandler.java:473) at org.eclipse.jetty.server.session.SessionHandler.doScope(SessionHandler.java:1564) at org.eclipse.jetty.server.handler.ScopedHandler.nextScope(ScopedHandler.java:166) at org.eclipse.jetty.server.handler.ContextHandler.doScope(ContextHandler.java:1155) at org.eclipse.jetty.server.handler.ScopedHandler.handle(ScopedHandler.java:141) at org.eclipse.jetty.server.handler.HandlerWrapper.handle(HandlerWrapper.java:132) at org.eclipse.jetty.server.Server.handle(Server.java:564) at org.eclipse.jetty.server.HttpChannel.handle(HttpChannel.java:317) at org.eclipse.jetty.server.HttpConnection.onFillable(HttpConnection.java:251) at org.eclipse.jetty.io.AbstractConnection$ReadCallback.succeeded(AbstractConnection.java:279) at org.eclipse.jetty.io.FillInterest.fillable(FillInterest.java:110) at org.eclipse.jetty.io.ChannelEndPoint$2.run(ChannelEndPoint.java:124) at org.eclipse.jetty.util.thread.Invocable.invokePreferred(Invocable.java:128) at org.eclipse.jetty.util.thread.Invocable$InvocableExecutor.invoke(Invocable.java:222) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.doProduce(EatWhatYouKill.java:294) at org.eclipse.jetty.util.thread.strategy.EatWhatYouKill.run(EatWhatYouKill.java:199) at winstone.BoundedExecutorService$1.run(BoundedExecutorService.java:77) at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142) at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617) at java.lang.Thread.run(Thread.java:748)

        Attachments

          Activity

          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Lukasz Jader
          Path:
          src/main/java/org/jvnet/hudson/plugins/CredentialsSSHSite.java
          http://jenkins-ci.org/commit/ssh-plugin/d18d0ed20e0fecb08dd22dadb87e28a166b167c9
          Log:
          JENKINS-46172 Prevent NPE when binding incomplete definitions of ssh host

          Proper ssh host should have at least:
          1. hostname not empty
          2. attached credentials

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Lukasz Jader Path: src/main/java/org/jvnet/hudson/plugins/CredentialsSSHSite.java http://jenkins-ci.org/commit/ssh-plugin/d18d0ed20e0fecb08dd22dadb87e28a166b167c9 Log: JENKINS-46172 Prevent NPE when binding incomplete definitions of ssh host Proper ssh host should have at least: 1. hostname not empty 2. attached credentials
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Lukasz Jader
          Path:
          src/main/java/org/jvnet/hudson/plugins/SSHBuildWrapper.java
          http://jenkins-ci.org/commit/ssh-plugin/6f443e7c293f547e2c5e9950d74683b1d935996c
          Log:
          JENKINS-46172 Prevent Jenkins/configure submit if ssh host definition is incomplete.

          Proper ssh host should have at least:
          1. hostname not empty
          2. attached credentials

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Lukasz Jader Path: src/main/java/org/jvnet/hudson/plugins/SSHBuildWrapper.java http://jenkins-ci.org/commit/ssh-plugin/6f443e7c293f547e2c5e9950d74683b1d935996c Log: JENKINS-46172 Prevent Jenkins/configure submit if ssh host definition is incomplete. Proper ssh host should have at least: 1. hostname not empty 2. attached credentials
          Hide
          scm_issue_link SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Lukasz Jader
          Path:
          pom.xml
          http://jenkins-ci.org/commit/ssh-plugin/a08598db301d19515b47ec8c4ec6233c93613d38
          Log:
          JENKINS-46172 bump ssh-credentials dependency to 1.12

          New version is the same as jsch-plugin v. 0.1.54.1 requires.

          Compare: https://github.com/jenkinsci/ssh-plugin/compare/52bd63a77354...a08598db301d

          Show
          scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Lukasz Jader Path: pom.xml http://jenkins-ci.org/commit/ssh-plugin/a08598db301d19515b47ec8c4ec6233c93613d38 Log: JENKINS-46172 bump ssh-credentials dependency to 1.12 New version is the same as jsch-plugin v. 0.1.54.1 requires. Compare: https://github.com/jenkinsci/ssh-plugin/compare/52bd63a77354...a08598db301d
          Hide
          jnorton Jason Norton added a comment -

          Hi Łukasz Jąder, I believe it is entirely possible that this was caused by migration code changes. I have been having to edit manually to add users and have been over the code many times as I was also suspecting this to be the issue. 

          Show
          jnorton Jason Norton added a comment - Hi  Łukasz Jąder , I believe it is entirely possible that this was caused by migration code changes. I have been having to edit manually to add users and have been over the code many times as I was also suspecting this to be the issue. 
          Hide
          ljader Łukasz Jąder added a comment -

          This has been fixed with 2.6 version by saving SSH sites only when they have at least hostname and credentials selected.
          (the NPE exception handling was also improved)

          Show
          ljader Łukasz Jąder added a comment - This has been fixed with 2.6 version by saving SSH sites only when they have at least hostname and credentials selected. (the NPE exception handling was also improved)

            People

            Assignee:
            ljader Łukasz Jąder
            Reporter:
            ryzhenkov Viacheslav Ryzhenkov
            Votes:
            2 Vote for this issue
            Watchers:
            7 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: