Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-4640

hudson.scm.SCM getModuleRoot should take build as a second param

XMLWordPrintable

    • Icon: Improvement Improvement
    • Resolution: Fixed
    • Icon: Major Major
    • core
    • None
    • Platform: All, OS: All

      As described in this thread:
      http://www.nabble.com/Suggestion-for-SCM.getModuleRoot-(via-clearcase-problem)-td25849692.html

      The result of getModuleRoot can be build dependent - we should pass the build of
      interest to the SCM object for this method.

      The current implementation results in a bug that manifests in interaction
      between the clearcase SCM and the m2-extra-steps plugin.

        1. hudson.4640.diff
          5 kB

          [JENKINS-4640] hudson.scm.SCM getModuleRoot should take build as a second param

          Nathan Parry added a comment -

          Created an attachment (id=953)
          Patch to implement the enhancement as described.

          Nathan Parry added a comment - Created an attachment (id=953) Patch to implement the enhancement as described.

          Nathan Parry added a comment -

          The attached patch adds the new methods - they call the existing methods to maintain backwards
          compatibility with existing SCMs until they are updated. It also updates the various places in core where
          the old methods were used to instead use the new ones.

          Nathan Parry added a comment - The attached patch adds the new methods - they call the existing methods to maintain backwards compatibility with existing SCMs until they are updated. It also updates the various places in core where the old methods were used to instead use the new ones.

          SCM/JIRA link daemon added a comment -

          Code changed in hudson
          User: : kohsuke
          Path:
          trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
          trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java
          trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java
          http://jenkins-ci.org/commit/36010
          Log:
          [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.

          SCM/JIRA link daemon added a comment - Code changed in hudson User: : kohsuke Path: trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java http://jenkins-ci.org/commit/36010 Log: [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.

          dogfood added a comment -

          Integrated in hudson_main_trunk #338
          [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling.

          kohsuke :
          Files :

          • /trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java
          • /trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java
          • /trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java

          dogfood added a comment - Integrated in hudson_main_trunk #338 [FIXED JENKINS-4640] applied the patch with some improvements in the backward compatibility handling. kohsuke : Files : /trunk/hudson/main/core/src/main/java/hudson/scm/SCM.java /trunk/hudson/main/core/src/main/java/hudson/model/AbstractBuild.java /trunk/hudson/main/core/src/main/java/hudson/model/AbstractProject.java

            Unassigned Unassigned
            nparry Nathan Parry
            Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

              Created:
              Updated:
              Resolved: