• Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Critical Critical
    • blueocean-plugin
    • None
    • Jenkins:2.74
      Blue Ocean: 1.2.0
    • Blue Ocean 1.2, Blue Ocean 1.3

      After recent upgrade to 1.2.0 the existing views are broken with the following error. Not sure if it is going to be the same problem for the new runs, yet to try out. Appreciate some inputs?

      Error rendering PipelineRunGraph: TypeError: Cannot read property 'name' of undefined
      

          [JENKINS-46436] Blue Ocean: Error rendering PipelineRunGraph

          Michael Neale added a comment -

          and thanks nrayapati for the sample pipeline, most helpful

          Michael Neale added a comment - and thanks nrayapati for the sample pipeline, most helpful

          Cliff Meyers added a comment -

          michaelneale jamesdumay the "limit" of 100 we're running into is due to the default pagination applied to the "nodes" endpoint. I'm not sure how important it is that we handle nodes > 100 in an elegant fashion. We can fix this a few different ways on the UI:

          1. Make sure that pipeline graph renders but only show first 100 nodes.
          2. Bump the limit up to something higher like 500 or 1000 nodes.
          3. Add some logic to the UI so it traverses the paginated data until there are no more pages left.

          I was chatting with vivek about this and he had some thoughts about the performance implications on the backend of fetching this much data. I believe he'll post a comment with some thoughts below.

          Cliff Meyers added a comment - michaelneale jamesdumay the "limit" of 100 we're running into is due to the default pagination applied to the "nodes" endpoint. I'm not sure how important it is that we handle nodes > 100 in an elegant fashion. We can fix this a few different ways on the UI: Make sure that pipeline graph renders but only show first 100 nodes. Bump the limit up to something higher like 500 or 1000 nodes. Add some logic to the UI so it traverses the paginated data until there are no more pages left. I was chatting with vivek about this and he had some thoughts about the performance implications on the backend of fetching this much data. I believe he'll post a comment with some thoughts below.

          Cliff Meyers added a comment -

          michaelneale jamesdumay I've hardened some of the UI code so it's resistant to when we fetch 100 nodes but there are actually more - it just renders the first 100 in the graph. It's probably good to have that in place regardless, I just wanted you guys to make the call as to how much further we should go to support the n > 100 use case.

          Cliff Meyers added a comment - michaelneale jamesdumay I've hardened some of the UI code so it's resistant to when we fetch 100 nodes but there are actually more - it just renders the first 100 in the graph. It's probably good to have that in place regardless, I just wanted you guys to make the call as to how much further we should go to support the n > 100 use case.

          Naresh Rayapati added a comment - - edited

          Thanks cliffmeyers Agree with you, to maintain the passivity the first option would be to show first 100 when the actual number is more than the limit.

          And also it would be awesome if we can bump the limit slightly, 100 seems little low for me, may be just to 150 or 200 as we have most of our pipelines has just little over 100 stages. Just my 1¢.

          Naresh Rayapati added a comment - - edited Thanks cliffmeyers  Agree with you, to maintain the passivity the first option would be to show first 100 when the actual number is more than the limit. And also it would be awesome if we can bump the limit slightly, 100 seems little low for me, may be just to 150 or 200 as we have most of our pipelines has just little over 100 stages. Just my 1¢.

          Cliff Meyers added a comment -

          Added a link to WIP PR.

          Cliff Meyers added a comment - Added a link to WIP PR.

          Cliff Meyers added a comment -

          Pipeline graph will no longer error out but the render but limited to 100 nodes. sophistifunk is doing some more involved improvements to pipeline graph and if we raise the limit, that work will be done there. I'll try to post an update to this ticket if that happens as a FYI.

          Cliff Meyers added a comment - Pipeline graph will no longer error out but the render but limited to 100 nodes. sophistifunk is doing some more involved improvements to pipeline graph and if we raise the limit, that work will be done there. I'll try to post an update to this ticket if that happens as a FYI.

          Thanks a bunch cliffmeyers, is there any date that we can expect this code to be released? Thanks again.  

          Naresh Rayapati added a comment - Thanks a bunch cliffmeyers , is there any date that we can expect this code to be released? Thanks again.  

          Cliff Meyers added a comment -

          nrayapati sorry for the much-delayed reply here... it will be available in Blue Ocean 1.3. That should ship hopefully in the next week or so, or you can grab the 1.3 beta off experimental Jenkins update center.

          Cliff Meyers added a comment - nrayapati sorry for the much-delayed reply here... it will be available in Blue Ocean 1.3. That should ship hopefully in the next week or so, or you can grab the 1.3 beta off experimental Jenkins update center.

          cliffmeyers No thats fine, Thanks for an update.

          Naresh Rayapati added a comment - cliffmeyers No thats fine, Thanks for an update.

          cliffmeyers I have updated the plugin to 1.3.0 yesterday and it was working correctly for the existing jobs, how ever it is still a problem for the new jobs, this time it is a slight different error Error rendering PipelineRunGraph: TypeError: Cannot read property 'id' of undefined. Appreciate your help. Thank you. 

          Also attaching the screenshot which has the js stack-trace too. 

          Naresh Rayapati added a comment - cliffmeyers I have updated the plugin to 1.3.0 yesterday and it was working correctly for the existing jobs, how ever it is still a problem for the new jobs, this time it is a slight different error  Error rendering PipelineRunGraph: TypeError: Cannot read property 'id' of undefined.  Appreciate your help. Thank you.  Also attaching the screenshot which has the js stack-trace too. 

            cliffmeyers Cliff Meyers
            nrayapati Naresh Rayapati
            Votes:
            0 Vote for this issue
            Watchers:
            7 Start watching this issue

              Created:
              Updated:
              Resolved: