Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46674

Direct SQS integration causes JSONException

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Critical Critical
    • github-sqs-plugin
    • Jenkins 2.74

      GitHub SQS Build Trigger Plugin 1.6-SNAPSHOT (private-5ddfb3a5)

      GitHub API Plugin 1.86
      GitHub Branch Source Plugin .2.2.3
      GitHub Pipeline for Blue Ocean 1.2.0
      GitHub plugin 1.28.0

      Currently this plugin is completely broken when setting up GitHub -> SQS -> Jenkins since there is code introduced in ddd75e5e05e244e5bbf9f68b9fa8a07db3f1ca30 assuming that the message have the structure of a message the comes from GitHub -> SNS -> SQS -> Jenkins integration.

      If you configure GitHub for SQS you get this stack trace:

      net.sf.json.JSONException: null object
      	at net.sf.json.JSONObject.verifyIsNull(JSONObject.java:2688)
      	at net.sf.json.JSONObject.getJSONObject(JSONObject.java:1998)
      	at jenkins.github.aws.parser.MessageParser.getGithubEvent(MessageParser.java:33)
      	at com.base2services.jenkins.SqsQueueHandler$SQSQueueReceiver.run(SqsQueueHandler.java:91)
      	at hudson.util.SequentialExecutionQueue$QueueEntry.run(SequentialExecutionQueue.java:119)
      	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
      	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
      	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
      	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
      	at java.lang.Thread.run(Thread.java:748)
      
      

      GitHub's SNS integration adds:

      { 
        "MessageAttributes": {
          "X-Github-Event": {
            "Type": "String",
            "Value": "push"
          }
        }
      }

      But those doesn't exist when running with out SNS.

      Attached two example SQS messages captured for the same push, one from GH -> SQS and one from GH -> SNS -> SQS.

       

       

        1. gh-sns-sqs.json
          11 kB
          Rickard von Essen
        2. gh-sqs.json
          9 kB
          Rickard von Essen

            Unassigned Unassigned
            rickard_v_essen Rickard von Essen
            Votes:
            2 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated: