[JENKINS-46785] Add a way to disable all reporters (and selectively enable a few)

Type: Improvement
Resolution: Fixed
Priority: Minor
Component/s: pipeline-maven-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

Currently when you upgrade the plugin you are at risk that new reporters are added/integrated and these collide with existing pipeline code you have to parse these results.

This leads to duplicate reports.

On top of this you may want to get the version of the thing you are building by useing something like

withMaven() {
  bsVersion = returnStdout: true, script: sh "mvn help:evaluate -Dexpression=project.version | grep -E '^[[:digit:]+.]+.*-SNAPSHOT' "
}

unfortunately using the above means that the taskScanner is currently invoked (which will then be invoked multiple times) which will cause unnecessary IO, fingerprinting is also involved - which again when you just want to run a simple maven command with no scanners is not good. The workaround of adding

withMaven(options: [concordionPublisher(disabled: true), findbugsPublisher(disabled: true), dependenciesFingerprintPublisher(disabled: true), artifactsPublisher(disabled: true), invokerPublisher(disabled: true), junitPublisher(disabled: true, ignoreAttachments: false), openTasksPublisher(disabled: true), pipelineGraphPublisher(disabled: true)]) {
// some block
}

is both verbose and will likely not do what is expected when a new publisher/reporter is integrated.

is duplicated by

JENKINS-47667 "Option" to disable every publishers/reporters

Closed

JENKINS-49708 withMaven option to skip ALL reporters

Closed

relates to

JENKINS-45887 Automatically archive JGiven reports

Closed

SCM/JIRA link daemon added a comment - 2017-12-14 11:06

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html
http://jenkins-ci.org/commit/pipeline-maven-plugin/a353d078089aca62f5ddc9ea75ab633655cfe85a
Log:
~~JENKINS-46785~~ Strategy to enable / disable publishers in pipelines.
Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...])" attribute

SCM/JIRA link daemon added a comment - 2017-12-14 11:06 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html http://jenkins-ci.org/commit/pipeline-maven-plugin/a353d078089aca62f5ddc9ea75ab633655cfe85a Log: JENKINS-46785 Strategy to enable / disable publishers in pipelines. Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...] )" attribute

SCM/JIRA link daemon added a comment - 2017-12-14 11:24

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
http://jenkins-ci.org/commit/pipeline-maven-plugin/9d070ce514aa0e140ea4560734252dff28fe6584
Log:
~~JENKINS-46785~~ Strategy to enable / disable publishers in pipelines.
Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...])" attribute

SCM/JIRA link daemon added a comment - 2017-12-14 11:24 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/9d070ce514aa0e140ea4560734252dff28fe6584 Log: JENKINS-46785 Strategy to enable / disable publishers in pipelines. Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...] )" attribute

SCM/JIRA link daemon added a comment - 2018-02-26 22:05

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java
http://jenkins-ci.org/commit/pipeline-maven-plugin/687ad6006569d0680f38ef22946f5948af64c0be
Log:
~~JENKINS-46785~~ Add unit test

SCM/JIRA link daemon added a comment - 2018-02-26 22:05 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/687ad6006569d0680f38ef22946f5948af64c0be Log: JENKINS-46785 Add unit test

SCM/JIRA link daemon added a comment - 2018-02-26 22:26

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
http://jenkins-ci.org/commit/pipeline-maven-plugin/8e24731eefdcd35fc169475d3af4caa41491b034
Log:
~~JENKINS-46785~~ Strategy to enable / disable publishers in pipelines.
Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...])" attribute

SCM/JIRA link daemon added a comment - 2018-02-26 22:26 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/8e24731eefdcd35fc169475d3af4caa41491b034 Log: JENKINS-46785 Strategy to enable / disable publishers in pipelines. Default strategy, "IMPLICIT" is the current strategy to implicitly enable all publishers unless they are explicitly disabled. The second available strategy, "EXPLICIT", requires to explicitly enable the publishers in the "withMaven(options: [...] )" attribute

SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java
http://jenkins-ci.org/commit/pipeline-maven-plugin/7e44b1ab23138133d2eefcafe4e35a0158cbdcb2
Log:
~~JENKINS-46785~~ Add unit test

SCM/JIRA link daemon added a comment - 2018-02-26 22:27 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/7e44b1ab23138133d2eefcafe4e35a0158cbdcb2 Log: JENKINS-46785 Add unit test

SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Code changed in jenkins
User: Cyrille Le Clerc
Path:
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java
jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly
jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java
jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java
http://jenkins-ci.org/commit/pipeline-maven-plugin/1d0617207186decf257afc2d8b08ad454c319109
Log:
~~JENKINS-46785~~ Strategy to enable / disable publishers in pipelines

Compare: https://github.com/jenkinsci/pipeline-maven-plugin/compare/586c9f75a5f3...1d0617207186

SCM/JIRA link daemon added a comment - 2018-02-26 22:27 Code changed in jenkins User: Cyrille Le Clerc Path: jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisher.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategy.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/MavenSpyLogProcessor.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStep.java jenkins-plugin/src/main/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepExecution.java jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/config.jelly jenkins-plugin/src/main/resources/org/jenkinsci/plugins/pipeline/maven/WithMavenStep/help-publisherStrategy.html jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherStrategyTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/MavenPublisherTest.java jenkins-plugin/src/test/java/org/jenkinsci/plugins/pipeline/maven/WithMavenStepTest.java http://jenkins-ci.org/commit/pipeline-maven-plugin/1d0617207186decf257afc2d8b08ad454c319109 Log: JENKINS-46785 Strategy to enable / disable publishers in pipelines Compare: https://github.com/jenkinsci/pipeline-maven-plugin/compare/586c9f75a5f3...1d0617207186

Cyrille Le Clerc added a comment - 2018-02-26 22:59 - edited

Fixed in 3.4.0-beta-1: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/pipeline-maven/3.4.0-beta-1/pipeline-maven-3.4.0-beta-1.hpi

teilo olamy can you please test?

Sample:

node {
    stage ('Build') {
        git "https://github.com/cyrille-leclerc/my-jar.git"
         // disable all publishers
        withMaven(maven: 'maven-3.5.2', publisherStrategy: 'EXPLICIT') {
           sh "mvn dependency:go-offline"
        }
        
        withMaven(maven: 'maven-3.5.2') {
           sh "mvn clean deploy"
        }
    }
}

Cyrille Le Clerc added a comment - 2018-02-26 22:59 - edited Fixed in 3.4.0-beta-1: https://repo.jenkins-ci.org/releases/org/jenkins-ci/plugins/pipeline-maven/3.4.0-beta-1/pipeline-maven-3.4.0-beta-1.hpi teilo olamy can you please test? Sample: node { stage ( 'Build' ) { git "https: //github.com/cyrille-leclerc/my-jar.git" // disable all publishers withMaven(maven: 'maven-3.5.2' , publisherStrategy: 'EXPLICIT' ) { sh "mvn dependency:go-offline" } withMaven(maven: 'maven-3.5.2' ) { sh "mvn clean deploy" } } }

Cyrille Le Clerc added a comment - 2018-03-05 11:37

olamy, teilo friendly ping

Cyrille Le Clerc added a comment - 2018-03-05 11:37 olamy , teilo friendly ping

Olivier Lamy added a comment - 2018-03-06 09:43

cleclerc sorry for the late reply but works fine! Thanks!

Olivier Lamy added a comment - 2018-03-06 09:43 cleclerc sorry for the late reply but works fine! Thanks!

Cyrille Le Clerc added a comment - 2018-03-06 11:07

Solved in 3.4.0

Cyrille Le Clerc added a comment - 2018-03-06 11:07 Solved in 3.4.0

Assignee:: Cyrille Le Clerc

Reporter:: James Nord

Votes:: 2 Vote for this issue

Watchers:: 9 Start watching this issue

Created:: 2017-09-11 10:00

Updated:: 2018-03-06 11:07

Resolved:: 2018-03-06 11:07

Details

Description

Attachments

Issue Links

Activity

Collapse comment: SCM/JIRA link daemon added a comment - 2017-12-14 11:06

Expand comment: SCM/JIRA link daemon added a comment - 2017-12-14 11:06

Collapse comment: SCM/JIRA link daemon added a comment - 2017-12-14 11:24

Expand comment: SCM/JIRA link daemon added a comment - 2017-12-14 11:24

Collapse comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:05

Expand comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:05

Collapse comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:26

Expand comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:26

Collapse comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Expand comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Collapse comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Expand comment: SCM/JIRA link daemon added a comment - 2018-02-26 22:27

Collapse comment: Cyrille Le Clerc added a comment - 2018-02-26 22:59, Edited by Cyrille Le Clerc - 2018-02-27 08:58

Expand comment: Cyrille Le Clerc added a comment - 2018-02-26 22:59, Edited by Cyrille Le Clerc - 2018-02-27 08:58

Collapse comment: Cyrille Le Clerc added a comment - 2018-03-05 11:37

Expand comment: Cyrille Le Clerc added a comment - 2018-03-05 11:37

Collapse comment: Olivier Lamy added a comment - 2018-03-06 09:43

Expand comment: Olivier Lamy added a comment - 2018-03-06 09:43

Collapse comment: Cyrille Le Clerc added a comment - 2018-03-06 11:07

Expand comment: Cyrille Le Clerc added a comment - 2018-03-06 11:07

People

Dates