Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-46864

Jenkins agent header check doesn't meet RFC, it's case-sensitive

    XMLWordPrintable

Details

    Description

      When you setup slave with slave-agent.jnlp it tries to connect to /tcpSlaveAgentListener/ and get JNLP port. I'm not sure if this code is relevant but the check seem to be working like this:

      https://github.com/kpfleming/jenkins-remoting/blob/master/src/main/java/hudson/remoting/Engine.java#L166

      However according to RFC 7230 and RFC 7540 HTTP headers are case-insensitive.

       

      The problem is that if you use proxy written in go agent won't connect with an "java.io.IOException: https://myjenkins.net/ is not Jenkins" error.
      See https://github.com/golang/go/issues/21868 for more details.

      Attachments

        Issue Links

          Activity

            People

              vulong237 Long Nguyen
              hryamzik Roman Belyakovsky
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: