Details
-
Type:
Improvement
-
Status: Closed (View Workflow)
-
Priority:
Major
-
Resolution: Fixed
-
Component/s: bitbucket-branch-source-plugin
-
Labels:None
-
Similar Issues:
-
Released As:2.3.0
Description
Bitbucket has, as of 5.4.0, a better webhook integration.
This is especially good for the Bitbucket users that can't install unsuported plugins. The new solution is always enabled and doesn't need additional configuration.
Explanation about this: https://confluence.atlassian.com/bitbucketserver/managing-webhooks-in-bitbucket-server-938025878.html
The different payloads it has : https://confluence.atlassian.com/bitbucketserver/event-payload-938025882.html
I believe there isn't a webhook api yet, and I haven't found anything yet about plans of creating it. I think we have to wait until then?
Attachments
Issue Links
- is blocked by
-
JENKINS-47891 Bitbucket branch source plugin does not understand the new Bitbucket Server webhooks
-
- Resolved
-
- is duplicated by
-
-
- Resolved
-
- is related to
-
JENKINS-33507 Bitbucket Server webhooks and Bitbucket Cloud build status notifications
-
- Closed
-
- links to
Activity
The webhook API documentation at https://developer.atlassian.com/static/rest/bitbucket-server/5.5.0/bitbucket-rest.html#idm140236731154672 is lacking details though about the request body JSON format to create a new hook.
Konrad Windszus
added a comment - The webhook API documentation at https://developer.atlassian.com/static/rest/bitbucket-server/5.5.0/bitbucket-rest.html#idm140236731154672 is lacking details though about the request body JSON format to create a new hook. The documentation includes an example JSON response after successfully creating a webhook. I tried sending the same kind of JSON object in the request and that created a webhook OK. Bitbucket Server apparently ignores the "id", "createdDate", and "updatedDate" properties of the request JSON object.
Kalle Niemitalo
added a comment - The documentation includes an example JSON response after successfully creating a webhook. I tried sending the same kind of JSON object in the request and that created a webhook OK. Bitbucket Server apparently ignores the "id", "createdDate", and "updatedDate" properties of the request JSON object. In Jenkins, I can open the configuration page of a job, add the "Override hook management" behavior to a "Bitbucket" branch source, and change the setting to "Disable hook management". I hope this setting will work with Bitbucket Server too, so that I can configure the webhook manually and not have to grant REPO_ADMIN permission to Jenkins. However, it is not clear how I would then tell Jenkins the webhook secret with which Bitbucket Server will authenticate the payload. Or is Jenkins going to validate the HMAC at all?
Kalle Niemitalo
added a comment - In Jenkins, I can open the configuration page of a job, add the "Override hook management" behavior to a "Bitbucket" branch source, and change the setting to "Disable hook management". I hope this setting will work with Bitbucket Server too, so that I can configure the webhook manually and not have to grant REPO_ADMIN permission to Jenkins. However, it is not clear how I would then tell Jenkins the webhook secret with which Bitbucket Server will authenticate the payload. Or is Jenkins going to validate the HMAC at all? I created a branch with some changes at https://github.com/jenkinsci/bitbucket-branch-source-plugin/compare/master...kwin:bbserver-use-native-webhooks This is not complete yet as I still have to figure how to correctly fill the changes in BitbucketServerPushEvent and BitbucketServerPullRequest.
Erwin Oldenkamp Maybe you can have a look from there, as you did the original implementation against your own plugin.
Konrad Windszus
added a comment - - edited I created a branch with some changes at https://github.com/jenkinsci/bitbucket-branch-source-plugin/compare/master...kwin:bbserver-use-native-webhooks This is not complete yet as I still have to figure how to correctly fill the changes in BitbucketServerPushEvent and BitbucketServerPullRequest.
Erwin Oldenkamp Maybe you can have a look from there, as you did the original implementation against your own plugin. At first glance: LGTM.
Building it like this will mean that the plugin is no longer supported ( Fine by me), have you thought about maybe supporting both first? Or maybe first deprecating the current version in favor of the new version? Either way is fine by me, as we can update Bitbucket to 5.5.0 very easy. I'll attach a diagram of current installed on which version. Do note that the plugin isn't used for Jenkins only, but the majority does. 
Erwin Oldenkamp
added a comment - - edited At first glance: LGTM.
Building it like this will mean that the plugin is no longer supported ( Fine by me), have you thought about maybe supporting both first? Or maybe first deprecating the current version in favor of the new version? Either way is fine by me, as we can update Bitbucket to 5.5.0 very easy. I'll attach a diagram of current installed on which version. Do note that the plugin isn't used for Jenkins only, but the majority does. I would love to see this implemented. Having backwards compatibility or even just multiple method signatures that allows using the old behavior when an extra field like BitbucketType isn't present, would be sweet. The new smart parsing fuctionality looks fantastic and I really hate having to purchase a plugin on the Bitbucket side to send "dumbed down" webhooks to Jenkins if the existing Jenkins built in could handle the newer BB 5.4.x and higher payloads itself.
Ethan Spoelstra
added a comment - I would love to see this implemented. Having backwards compatibility or even just multiple method signatures that allows using the old behavior when an extra field like BitbucketType isn't present, would be sweet. The new smart parsing fuctionality looks fantastic and I really hate having to purchase a plugin on the Bitbucket side to send "dumbed down" webhooks to Jenkins if the existing Jenkins built in could handle the newer BB 5.4.x and higher payloads itself. 
There is a webhooks API. See this reference.