Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47127

Favicon in war broken since 2.79

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Resolved (View Workflow)
    • Priority: Major
    • Resolution: Fixed
    • Component/s: core
    • Labels:
    • Environment:
      jenkins.war v2.79
    • Similar Issues:

      Description

      favicon.ico in the root of the packaged war file (from http://mirrors.jenkins.io/war/) is being mangled since Jenkins v2.79.

      Compared to previous releases, the favicon file has doubled in size and now can no longer be read by browsers or by image editing software such as GIMP.

      The favicon in the source on github hasn't changed in 7 years, so I would guess this is as a result of some kind of change in war packaging, such as an encoding issue.

        Attachments

          Issue Links

          relates to

          Improvement - An improvement or enhancement to an existing feature or task. JENKINS-7304 please place the ${project.version} into the web.xml /web-app/display-name

          • Trivial - Cosmetic problem like misspelt words or misaligned text.
          • Closed
          links to

          Web Link Core PR-3048

          Web Link Core PR-3052

            Activity

            Ascending order - Click to sort in descending order
            12 older comments
            Hide
            Permalink
            batmat Baptiste Mathus added a comment -

            kboz Daniel Beck agreed, I started receiving the notifications of MWAR-404 being reverted during the night just before going to sleep, and I thought that anyway we still have still to let it mature.

            Though the upcoming 3.2.0 release seems like it will contain a fix, I don't think this will be released before the end of the week though. So I'll still leave it some thoughts & hours, and I'll probably file a "revert to MWAR 3.0.0" PR later tonight or tomorrow for instance.

            If you think this must be expedited, just tell me so and I can file the PR more quickly.

            Show
            batmat Baptiste Mathus added a comment - kboz Daniel Beck agreed, I started receiving the notifications of MWAR-404 being reverted during the night just before going to sleep, and I thought that anyway we still have still to let it mature. Though the upcoming 3.2.0 release seems like it will contain a fix, I don't think this will be released before the end of the week though. So I'll still leave it some thoughts & hours, and I'll probably file a "revert to MWAR 3.0.0" PR later tonight or tomorrow for instance. If you think this must be expedited, just tell me so and I can file the PR more quickly.
            Hide
            Permalink
            danielbeck Daniel Beck added a comment -

            We just need it done by the weekend.

            Show
            danielbeck Daniel Beck added a comment - We just need it done by the weekend.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Baptiste Mathus
            Path:
            pom.xml
            http://jenkins-ci.org/commit/jenkins/d7dc9bc324bf0bc567c5b2a5b1ecfb71b99cf1e2
            Log:
            JENKINS-47127 Downgrade to m-war-p 3.0.0

            MWAR-404 introduced the regression in maven-war-plugin 3.1.0that makes
            every files be filtered, including binaries.

            MWAR-407 has been filed to revert MWAR-404, but that will be only in
            m-war-p 3.1.1 or 3.2.0 which are not yet released.

            So we downgrade to 3.0.0 for now.

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Baptiste Mathus Path: pom.xml http://jenkins-ci.org/commit/jenkins/d7dc9bc324bf0bc567c5b2a5b1ecfb71b99cf1e2 Log: JENKINS-47127 Downgrade to m-war-p 3.0.0 MWAR-404 introduced the regression in maven-war-plugin 3.1.0that makes every files be filtered, including binaries. MWAR-407 has been filed to revert MWAR-404, but that will be only in m-war-p 3.1.1 or 3.2.0 which are not yet released. So we downgrade to 3.0.0 for now.
            Hide
            Permalink
            scm_issue_link SCM/JIRA link daemon added a comment -

            Code changed in jenkins
            User: Daniel Beck
            Path:
            pom.xml
            http://jenkins-ci.org/commit/jenkins/52342b26e51df5b989ab60ef77bd217b263df1ff
            Log:
            Merge pull request #3052 from batmat/JENKINS-47127-revert-to-m-war-p-3.0

            JENKINS-47127 Downgrade to m-war-p 3.0.0

            Compare: https://github.com/jenkinsci/jenkins/compare/34b8eb0628a7...52342b26e51d

            Show
            scm_issue_link SCM/JIRA link daemon added a comment - Code changed in jenkins User: Daniel Beck Path: pom.xml http://jenkins-ci.org/commit/jenkins/52342b26e51df5b989ab60ef77bd217b263df1ff Log: Merge pull request #3052 from batmat/ JENKINS-47127 -revert-to-m-war-p-3.0 JENKINS-47127 Downgrade to m-war-p 3.0.0 Compare: https://github.com/jenkinsci/jenkins/compare/34b8eb0628a7...52342b26e51d
            Hide
            Permalink
            danielbeck Daniel Beck added a comment -

            Fixed in 2.82.

            Show
            danielbeck Daniel Beck added a comment - Fixed in 2.82.

              People

              Assignee:
              batmat Baptiste Mathus
              Reporter:
              kboz kboz
              Votes:
              0 Vote for this issue
              Watchers:
              5 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: