Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47370

Unable to override global envs after update to 2.1.4

    • 2.1.6

      We have a global setting of JIRA_URL=jira.acme.com

      In some jobs we override this in the "Prepare an environment for the run" section to JIRA_URL=jira-staging.acme.com

       

      After upgrading to 1.24 this stopped working. The effective value as seen in shell scripts is jira.acme.com

       

      Setting the value in a "Inject environment variables" build step also has no effect.

      The only thing that has an effect is to set the value inside the shell script.

          [JENKINS-47370] Unable to override global envs after update to 2.1.4

          Code changed in jenkins
          User: Oleg Nenashev
          Path:
          pom.xml
          http://jenkins-ci.org/commit/envinject-plugin/05fffd291109514321bfbeab0fd62454ebb74f88
          Log:
          Merge pull request #127 from oleg-nenashev/2.1.4-compat-notice

          Add compatibility notice for JENKINS-47364 and JENKINS-47370

          Compare: https://github.com/jenkinsci/envinject-plugin/compare/03a66052daa3...05fffd291109

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Oleg Nenashev Path: pom.xml http://jenkins-ci.org/commit/envinject-plugin/05fffd291109514321bfbeab0fd62454ebb74f88 Log: Merge pull request #127 from oleg-nenashev/2.1.4-compat-notice Add compatibility notice for JENKINS-47364 and JENKINS-47370 Compare: https://github.com/jenkinsci/envinject-plugin/compare/03a66052daa3...05fffd291109

          arnaud dovi added a comment -

          If you are not going to touch this issue anymore this is serious problem here, as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInject I have to ban all jenkins domains in the host Linux configuration level to stop Jenkins updates

          My suggestion (only if you are not going to improve this fix causing regressions)

          • branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)"

          So we can stick to this version, because I believe we need Jenkins updates while we dont need EnvInject updates anymore and want it as it is working actually, the fix you published for it was not affecting us.

          arnaud dovi added a comment - If you are not going to touch this issue anymore this is serious problem here, as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInject I have to ban all jenkins domains in the host Linux configuration level to stop Jenkins updates My suggestion (only if you are not going to improve this fix causing regressions) branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)" So we can stick to this version, because I believe we need Jenkins updates while we dont need EnvInject updates anymore and want it as it is working actually, the fix you published for it was not affecting us.

          Oleg Nenashev added a comment -

          I am going to make the change, not sure when. I am traveling since mid-October, and unfortunately I had no time to work on it. Everybody is welcome to submit a pull request.

          > as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInjec

          If your users are able to install and update plugins, IMHO you have a larger problem than EnvInject. Common users should have no access to plugin management if they ignore warnings in Web UI and changelogs. If you do not see the warning in the Update Manager on your instance, let me know.

          > branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)"

          It cannot be easily done in such way due to the risk of binary conflicts. Anyway, I am going to improve the configuration and to at least offer the opt-out flag.

          Oleg Nenashev added a comment - I am going to make the change, not sure when. I am traveling since mid-October, and unfortunately I had no time to work on it. Everybody is welcome to submit a pull request. > as administrator It's impossible to communicate to the team the DO NOT UPDATE EnvInjec If your users are able to install and update plugins, IMHO you have a larger problem than EnvInject. Common users should have no access to plugin management if they ignore warnings in Web UI and changelogs. If you do not see the warning in the Update Manager on your instance, let me know. > branch the 2.1.3 version to a newer plugin called "Environment Injector Plugin (Old compatibility version)" It cannot be easily done in such way due to the risk of binary conflicts. Anyway, I am going to improve the configuration and to at least offer the opt-out flag.

          Fabien LD added a comment -

          Got the same issue. Fixed reverting that plugin

          Fabien LD added a comment - Got the same issue. Fixed reverting that plugin

          pjdarton added a comment -

          This issue sounds very much like JENKINS-14437.

          pjdarton added a comment - This issue sounds very much like JENKINS-14437 .

          Oleg Nenashev added a comment -

          The regression impact is properly documented && the plugin 2.1.4 is marked as incompatible, so it should minimize the impact on users. 2.1.3 is also available through archives.

          Although I understand all the possible frustration by plugin users, I decided to NOT work on this issue. The regression has been introduced by me by a fix created during the working time, and I cordially apologize for any inconvenience it caused. Taking the proper regression announcement my team decided to not fix the regression in foreseeable future, because it is focused on other much more important tasks around Jenkins stability. I have no time to work on it during my spare time, because I am focused on the Jenkins core maintenance and other community work. On the other hand, I will be happy to review and deliver pull requests if somebody proposes them.

          I would also like to highlight that the plugin is waiting for adoption for more than two years. During all this time I was trying to keep this plugin afloat by reviewing the incoming pull requests, fixing defects and keeping the codebase up to date to simplify the handover. But I have not been using this plugin on my own so that such maintenance was a bit lame. I invite all active users to contribute to the plugin by taking ownership of this plugin and of EnvInject API. I am happy to provide any required knowledge transfers and do some assistance during the first months of maintenance

          Oleg Nenashev added a comment - The regression impact is properly documented && the plugin 2.1.4 is marked as incompatible, so it should minimize the impact on users. 2.1.3 is also available through archives. Although I understand all the possible frustration by plugin users, I decided to NOT work on this issue. The regression has been introduced by me by a fix created during the working time, and I cordially apologize for any inconvenience it caused. Taking the proper regression announcement my team decided to not fix the regression in foreseeable future, because it is focused on other much more important tasks around Jenkins stability. I have no time to work on it during my spare time, because I am focused on the Jenkins core maintenance and other community work. On the other hand, I will be happy to review and deliver pull requests if somebody proposes them. I would also like to highlight that the plugin is waiting for adoption for more than two years. During all this time I was trying to keep this plugin afloat by reviewing the incoming pull requests, fixing defects and keeping the codebase up to date to simplify the handover. But I have not been using this plugin on my own so that such maintenance was a bit lame. I invite all active users to contribute to the plugin by taking ownership of this plugin and of EnvInject API. I am happy to provide any required knowledge transfers and do some assistance during the first months of maintenance

          ickersep added a comment -

          This seems to be fixed in 2.1.6

          ickersep added a comment - This seems to be fixed in 2.1.6

          Oleg Nenashev added a comment -

          it's not

          Oleg Nenashev added a comment - it's not

          We're heavily affected by this issue and can't upgrade from 2.1.3 because of it.

          Francisco Lozano added a comment - We're heavily affected by this issue and can't upgrade from 2.1.3 because of it.

          For your information, all related to this Jira component have been transferred to Github: https://github.com/jenkinsci/envinject-api-plugin/issues

          Note: this is an automated bulk comment

          Alexander Brandes added a comment - For your information, all related to this Jira component have been transferred to Github: https://github.com/jenkinsci/envinject-api-plugin/issues Note: this is an automated bulk comment

            Unassigned Unassigned
            jbochenski Jakub Bochenski
            Votes:
            14 Vote for this issue
            Watchers:
            25 Start watching this issue

              Created:
              Updated:
              Resolved: