Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47391

Swarm plugin with -labelsFile does not delete removed labels

    • Icon: Bug Bug
    • Resolution: Fixed
    • Icon: Minor Minor
    • swarm-plugin
    • swarm-plugin 3.4
      Jenkins 2.60.2
    • 3.15

      Code on the Jenkins plugin side responsible for label removing has been commented out during cleanup.
      https://github.com/jenkinsci/swarm-plugin/blame/master/plugin/src/main/java/hudson/plugins/swarm/PluginImpl.java#L144

      To reproduce:
      run swarm jar with -labelsFile option, modify label string in the file (add a new label and remove some existing label), wait for 10 seconds, go to the agent's page in Jenkins.
      The new label will appear, but the deleted one will remain.

          [JENKINS-47391] Swarm plugin with -labelsFile does not delete removed labels

          Oleg Nenashev added a comment -

          Wow, the previous maintainer just commented it out when fixing FindBugs: https://github.com/jenkinsci/swarm-plugin/commit/67e9d17408c44ddb0778cc4256884245942e32b0

          Oleg Nenashev added a comment - Wow, the previous maintainer just commented it out when fixing FindBugs: https://github.com/jenkinsci/swarm-plugin/commit/67e9d17408c44ddb0778cc4256884245942e32b0

          Basil Crow added a comment -

          This was fixed in #75 and released in 3.15.

          Basil Crow added a comment - This was fixed in #75 and released in 3.15.

            Unassigned Unassigned
            nickolayr Nickolay Rumyantsev
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

              Created:
              Updated:
              Resolved: