Details
-
Bug
-
Status: Closed (View Workflow)
-
Minor
-
Resolution: Fixed
Description
Jenkinsfiles like what you see below (note the lack of 'expression' block in the 'when' clause) cause a NullPointerException instead of reporting a syntax error.
pipeline {
agent { label 'Some Machine' }
parameters {
string(name: 'Type', defaultValue: 'Nightly', description: 'Type of build to perform -- can be "Nightly," "CI," or "PR"')
}
stages {
stage('Fix Me') {
when {
params.Type == 'CI'
}
steps {
echo "Hello World"
}
}
}
}
Attachments
Issue Links
- links to
Activity
| Field | Original Value | New Value |
|---|---|---|
| Component/s | pipeline-model-definition-plugin [ 21706 ] | |
| Component/s | declarative-pipeline-when-conditions-plugin [ 23168 ] | |
| Component/s | pipeline [ 21692 ] |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Remote Link | This issue links to "PR #209 (Web Link)" [ 17926 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/parser/ModelParser.groovy
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
pipeline-model-definition/src/test/resources/errors/whenContainingNonCondition.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/114588a7be038d48177c80d9f05e0a7e017c9501
Log:
[FIXED JENKINS-47559] Don't do full validation for non-conditions
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
| Status | Resolved [ 5 ] | Closed [ 6 ] |
PR up at https://github.com/jenkinsci/pipeline-model-definition-plugin/pull/209