Details
-
Bug
-
Status: Resolved (View Workflow)
-
Major
-
Resolution: Fixed
-
None
-
Platform: All, OS: Linux
Description
When two ant tasks are run in parallel, sometimes the EXECUTOR_NUMBER for the
two tasks are the same. The EXECTOR_NUMBER variable should be unique for each
task. Here is the documentation URL for the EXECUTOR_NUMBER environment variable.
http://wiki.jenkins-ci.org/display/JENKINS/Building+a+software+project
Below are the steps to reproduce this issue.
Note: This defect seems to be non-deterministic. I will list the steps that,
when followed, will often produce the described defect.
1. Create four new Hudson jobs.
2. Configure each job. Under each job's "Build" section Add a build step,
select "invoke Ant".
3. Click the "Advanced" button under the "Invoke Ant" section. Paste the
following into the "Properties" text box.
EXECUTOR_NUMBER=$EXECUTOR_NUMBER
4. Configure the Ant build step of each job to run an ant task that prints out
the ${EXECUTOR_NUMBER} variable.
5. Setup Hudson to be able to run four executors simultaneously.
6. Launch each of the four jobs in parallel. Try to launch them at the same
time if possible.
7. Look at the console output of each of the jobs. On some runs, two separate
jobs will use the same executor number.
8. When step 7 has finished, if the defect has not manifested itself, repeat
steps 6 and 7.
Attachments
Issue Links
- is duplicated by
-
-
- Resolved
-
Activity
See the linked duplicate issue for another possible way to reproduce the issue (adding+removing executors).
janick reynders
added a comment - I think the problem is that when an Executor is added to a Computer its number is set to Computer.executors.size(). This is not correct because when the number of executors was decreased for some reason (executor crash, decrease by config, ...) it is not always the last Executer that is removed from the Computer. If the number of executors is increased again (Thread restart, increase by config) the new executor should not just take Computer.executors.size() as its number but it should that a number in the range [0,numExecutors) that is not taken yet by another executor.
I added a patch that fixes this issue.
janick reynders
added a comment - I think the problem is that when an Executor is added to a Computer its number is set to Computer.executors.size(). This is not correct because when the number of executors was decreased for some reason (executor crash, decrease by config, ...) it is not always the last Executer that is removed from the Computer. If the number of executors is increased again (Thread restart, increase by config) the new executor should not just take Computer.executors.size() as its number but it should that a number in the range [0,numExecutors) that is not taken yet by another executor.
I added a patch that fixes this issue.
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
core/src/main/java/hudson/model/Computer.java
test/src/test/java/hudson/model/ExecutorTest.java
http://jenkins-ci.org/commit/core/f88a2ba3336714a7d03b1d7b0f5a32b3c106cffd
Log:
Merge branch 'JENKINS-4756'
JENKINS-4756:
minor touch up
FIXEDJENKINS-4756the executor number was not always unique. Computer.executors.size() does not provide a unique number within one Computer.
Code changed in jenkins
User: Kohsuke Kawaguchi
Path:
changelog.html
http://jenkins-ci.org/commit/core/85a8dd009a35377ca64d067d6cc4254e8ec29a16
Log:
[FIXED JENKINS-4756] recording the pull request #33 from Janick Reynders
sounds similar