Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47643

Allow [ci skip] to work for non-pull request changes

    XMLWordPrintable

    Details

    • Similar Issues:

      Description

      the README for version 0.1.1 of https://plugins.jenkins.io/bitbucket-scm-trait-commit-skip indicates, in the Description, that "The filtering is only performed at change requests events, so push events to non-pull requests will be always run."

      it would be totally amazing and make my day if this functionality applied equally to non-pull request changes (we never build pull requests).

      i assigned it to you, javier, just to make sure you'd see it. please feel free to detach yourself.

        Attachments

          Issue Links

            Activity

            Hide
            witokondoria Javier Delgado added a comment -

            Certainly, the expected tokens doesnt contain hypens (á la circleci - https://circleci.com/docs/2.0/skip-build/)
            There is another PR, still unreviewed, to allow a regexp (instead of such fixed tokens).
            Will fix the behaviour names so they differ
            The outcome of JENKINS-45502 will indeed alter how the skipping is performed. Nevertheless, giving the ticket priority and activity, I wouldnt foresee it to receive work mid-term.

            Show
            witokondoria Javier Delgado added a comment - Certainly, the expected tokens doesnt contain hypens (á la circleci - https://circleci.com/docs/2.0/skip-build/ ) There is another PR, still unreviewed, to allow a regexp (instead of such fixed tokens). Will fix the behaviour names so they differ The outcome of JENKINS-45502 will indeed alter how the skipping is performed. Nevertheless, giving the ticket priority and activity, I wouldnt foresee it to receive work mid-term.
            Hide
            shamil Alex Simenduev added a comment -

            Javier Delgado any updates on this. We are really looking forward to this feature...

            Show
            shamil Alex Simenduev added a comment - Javier Delgado any updates on this. We are really looking forward to this feature...
            Hide
            witokondoria Javier Delgado added a comment -

            This should be included on the 0.2.0 released plugin. Should appear at the update center shortly.

            Could you provide feedback, in order to close this ticket?

            Show
            witokondoria Javier Delgado added a comment - This should be included on the 0.2.0 released plugin. Should appear at the update center shortly. Could you provide feedback, in order to close this ticket?
            Hide
            shamil Alex Simenduev added a comment -

            Thanks a lot Javier Delgado. Works as expected!

            Show
            shamil Alex Simenduev added a comment - Thanks a lot Javier Delgado . Works as expected!
            Hide
            kiemes Tom Kiemes added a comment -

            Javier Delgado sorry to bother, but was this developed just for Bitbucket or also for GitHub?

            I am using version 0.4.0 of "GitHub Commit Skip SCM Behaviour" plugin on a Jenkins connected to GitHub Enterprise and my configuration looks as follows:

            • GitHub Organisation project
            • Build strategies (in this order; not sure if the order is important here):
              • Change requests
              • Regular branches
              • Skip build trigger if commit message contains
                • Pattern : skip

            The documentation still states, that "The filtering is only performed for change request events, so push events to non-pull requests will be always run". But the same sentence is still in the doc for BitBucket and as far as I understand the discussion, this is working?

            Any help would be appreciated.

            Best regards, Tom

            Show
            kiemes Tom Kiemes added a comment - Javier Delgado sorry to bother, but was this developed just for Bitbucket or also for GitHub? I am using version 0.4.0 of "GitHub Commit Skip SCM Behaviour" plugin on a Jenkins connected to GitHub Enterprise and my configuration looks as follows: GitHub Organisation project Build strategies (in this order; not sure if the order is important here): Change requests Regular branches Skip build trigger if commit message contains Pattern : skip The documentation still states, that "The filtering is only performed for change request events, so push events to non-pull requests will be always run". But the same sentence is still in the doc for BitBucket and as far as I understand the discussion, this is working? Any help would be appreciated. Best regards, Tom

              People

              Assignee:
              witokondoria Javier Delgado
              Reporter:
              kburnett Kevin Burnett
              Votes:
              6 Vote for this issue
              Watchers:
              8 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved: