Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47673

Current BO Master forces third party bo based plugins to use the exact versions of npm deps

    • Blue Ocean 1.4 - beta 3, Blue Ocean 1.4 - beta 2

      Since the move to hpi based jdl et. al. custom plugins are forced to sync any given dependency that is coming from BO in your plugin package.json so that you use the *exact* version as BO does.

      If not you get blank screen and some error of "0 of undefined" and then you see e.g. "react-router" involved so you need to look into your version and theirs of "react-router".

      Once you have it, you have to keep the dependency of BO on your watch to adopt when they do.

      Prior to the change the dep resolving did neither worked correctly in returning you the version BO uses and not the one you requested but at least in 90% of the cases the plugin would have still worked.

      The problem here as I see it, is it forces plugin developer to release plugins on a fixed BO version and every time BO does a new release, meaning keeping backward compatibility is becoming impossible.

          [JENKINS-47673] Current BO Master forces third party bo based plugins to use the exact versions of npm deps

          Michael Neale added a comment -

          kzantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 

          Michael Neale added a comment - kzantow so is  resolvable ?- ie it won't fuss if the third party plugin deps don't match up 100%? 

          > unexpected ways

          beats completely broken everytime

          michaelneale you have summarized it well.

          Thorsten Scherler added a comment - > unexpected ways beats completely broken everytime michaelneale you have summarized it well.

          Michael Neale added a comment -

          tscherler it may just be react router, but kzantow is looking into it, obviously not intended. 

          Michael Neale added a comment - tscherler it may just be react router, but kzantow is looking into it, obviously not intended. 

          Alvaro Lobato added a comment -

          I've linked a document that seems relevant to this issue.

          Alvaro Lobato added a comment - I've linked a document that seems relevant to this issue.

          I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example

          Thorsten Scherler added a comment - I doubt that it is only react-router, since the error I saw had come from the bundle the router had been just an example

          alobato yes I think the doc explains the problem we see point on.

          Thorsten Scherler added a comment - alobato yes I think the doc explains the problem we see point on.

          Michael Neale added a comment -

          kzantow this one may be done now the shrinkwrap files went back in right? 

          Michael Neale added a comment - kzantow this one may be done now the shrinkwrap files went back in right? 

          Karl Shultz added a comment -

          Testing Notes:

          • This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.

          Karl Shultz added a comment - Testing Notes: This isn't something that can be tested within Blue Ocean itself, because the problem stems from custom plugins which rely upon, or extend, Blue Ocean itself.

          Michael Neale added a comment -

          still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 

          Michael Neale added a comment - still a WIP - keith working very hard at it.. .this is marked as a blocker and getting the attention it needs. 

          Alvaro Lobato added a comment -

          michaelneale and kzantow thanks for the effort!!!

          Alvaro Lobato added a comment - michaelneale and kzantow thanks for the effort!!!

            kzantow Keith Zantow
            tscherler Thorsten Scherler
            Votes:
            1 Vote for this issue
            Watchers:
            6 Start watching this issue

              Created:
              Updated:
              Resolved: