Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47705

"Disable removed jobs" feature does not work with pipeline jobs

    XMLWordPrintable

Details

    • Bug
    • Resolution: Fixed
    • Major
    • job-dsl-plugin
    • None

    Description

      When I use the "Disable removed jobs" feature of the Job DSL plugin, it does not work with Pipeline jobs. The job is correctly detected as an unreferenced item by ExecuteDslScripts, but it is not disabled because the Job DSL plugin is doing the disable via AbstractProject.disable():

              // Update unreferenced jobs
        for (GeneratedJob unreferencedJob : unreferenced) {
            Item removedItem = getLookupStrategy().getItem(seedJob, unreferencedJob.getJobName(), Item.class);
            if (removedItem != null && removedJobAction != RemovedJobAction.IGNORE) {
                if (removedJobAction == RemovedJobAction.DELETE) {
                    removedItem.delete();
                    removed.add(unreferencedJob);
                } else {
                    if (removedItem instanceof AbstractProject) {
                        AbstractProject project = (AbstractProject) removedItem;
                        project.checkPermission(Item.CONFIGURE);
                        if (project.isInQueue()) {
                            project.checkPermission(Item.CANCEL); // disable() will cancel queued builds
                        }
                        project.disable();
                        disabled.add(unreferencedJob);
                    }
                }
            }
        }

      Pipeline jobs don't extend AbstractProject, so this logic won't disable them.

      This issue was previously blocked on Jenkins fixing pipeline jobs so that they support enable/disable at all. That bug has now been taken care of in JENKINS-27299 which defines enabling/disabling in ParameterizedJob rather than AbstractProject. This fix has been made available starting in Jenkins 2.61 (or 2.73 LTS). So now the Job DSL plugin needs to be updated to take advantage of this new functionality if present.

      Attachments

        Issue Links

          depends on

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-27299 Refactor Disable Build feature out of AbstractProject for Pipeline Compatibility

          • Minor - Minor loss of function, or other problem where easy workaround is present.
          • Resolved
          is blocked by

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-46899 Gradle JPI Plugin can't use coreVersion of Jenkins >= 2.64

          • Major - Major loss of function.
          • Closed

          Activity

            People

              daspilker Daniel Spilker
              basil Basil Crow
              Votes:
              4 Vote for this issue
              Watchers:
              6 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: