Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-47716

Last changes plugin shows commit message heading mismatched with diffs

    XMLWordPrintable

    Details

    • Type: Bug
    • Status: Closed (View Workflow)
    • Priority: Minor
    • Resolution: Fixed
    • Component/s: last-changes-plugin
    • Labels:
      None
    • Environment:
      Jenkins 2.73.2
      Last changes plugin 1.0.11
      Git plugin 3.6.3
      Git client plugin 2.6.0
    • Similar Issues:

      Description

      The last changes plugin shows a summary of the preceding revision and the current revision at the top of the page.

      When viewing on a wide screen, the "current revision" is shown on the left, even though the diffs associated with the "current revision" are presented on the right.

      The "end revision" is shown on the right in the heading, even though the diffs associated with the prior revision are presented on the left.

      Would also help clarity if "End revision" were called "Prior revision" or "Previous revision". I mistakenly interpreted the word "end" to mean the most recent revision on that branch, when that's not what it means in this context.

        Attachments

          Activity

          Hide
          rmpestano Rafael Pestano added a comment -

          Hi Mark Waite,

           

          Can you try with the attached SNAPSHOT?

           

          thank you very much for the feedback.

          Show
          rmpestano Rafael Pestano added a comment - Hi Mark Waite ,   Can you try with the attached SNAPSHOT?   thank you very much for the feedback.
          Hide
          markewaite Mark Waite added a comment - - edited

          Snapshot shows a new behavior. The current summary is on the left, and current source code is on the left. The previous summary is on the right, and the source code is on the right.

          That's an improvement (more consistent), but I'm accustomed to reading the "before" on the left and the "after" on the right.

          Also reports a
          MissingFieldException: No field 'endRevision' found in class 'com.github.jenkins.lastchanges.LastChangesPublisher'
          in the "Manage Jenkins" page

          Show
          markewaite Mark Waite added a comment - - edited Snapshot shows a new behavior. The current summary is on the left, and current source code is on the left. The previous summary is on the right, and the source code is on the right. That's an improvement (more consistent), but I'm accustomed to reading the "before" on the left and the "after" on the right. Also reports a MissingFieldException: No field 'endRevision' found in class 'com.github.jenkins.lastchanges.LastChangesPublisher' in the "Manage Jenkins" page
          Hide
          rmpestano Rafael Pestano added a comment - - edited

           but I'm accustomed to reading the "before" on the left and the "after" on the right.

          You're right, both IntelliJ and github in split mode shows the "after" on the right. I'll change that and release v1.1.0.

           

          About the "MissingFieldException" it looks like it's a Jenkins cache thing because there is no more 'endRevision' on the plugin anymore.

          Show
          rmpestano Rafael Pestano added a comment - - edited  but I'm accustomed to reading the "before" on the left and the "after" on the right. You're right, both IntelliJ and github in split mode shows the "after" on the right. I'll change that and release v1.1.0.   About the "MissingFieldException" it looks like it's a Jenkins cache thing because there is no more 'endRevision' on the plugin anymore.
          Hide
          markewaite Mark Waite added a comment -

          I believe there are techniques which allow you to update a plugin and change the fields it manages, without generating that administrative monitor warning. Unfortunately, I don't know the location of the information which describes how to perform that upgrad.e

          Show
          markewaite Mark Waite added a comment - I believe there are techniques which allow you to update a plugin and change the fields it manages, without generating that administrative monitor warning. Unfortunately, I don't know the location of the information which describes how to perform that upgrad.e
          Hide
          rmpestano Rafael Pestano added a comment - - edited
          Show
          rmpestano Rafael Pestano added a comment - - edited This issue was fixed in  https://github.com/jenkinsci/last-changes-plugin/releases/tag/1.1.0

            People

            Assignee:
            rmpestano Rafael Pestano
            Reporter:
            markewaite Mark Waite
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: