Details
-
Type:
Bug
-
Status: Closed (View Workflow)
-
Priority:
Minor
-
Resolution: Fixed
-
Component/s: pipeline-model-definition-plugin
-
Labels:None
-
Environment:Parent POM 2.33
Jenkins 2.7.3
Declarative 1.2.2
-
Similar Issues:
Description
I am hoping to extend the Declarative Model Validator to provide linting services that have the team's policies / standards integrated. Working on a validator for ModelASTPostBuild I saw that the validator was being called twice.
My extension:
@Extension public class PostBuildValidator extends DeclarativeValidatorContributor { @CheckForNull @Override public String validateElement(@Nonnull ModelASTPostBuild postBuild, @CheckForNull FlowExecution execution) { return "abc" + postBuild.getName(); } }
My jenkinsfile:
pipeline {
agent {
label 'unix'
}
stages {
stage('test'){
steps{
echo "test"
}
}
}
post {
always{
echo "cleaning"
deleteDir()
}
}
}
Response from pipeline-model-converter/validateJenkinsfile:
{"status":"ok","data":{"result":"failure","errors":[
{"error":["abcpost @ line 12, column 3.","abcpost @ line 12, column 3."]}]}}
Attachments
Issue Links
- links to
Activity
Steven Foster
created issue -
Steven Foster
made changes -
| Field | Original Value | New Value |
|---|---|---|
| Description |
I am hoping to extend the Declarative Model Validator to provide linting services that have the team's policies / "style" integrated. Working on a validator for ModelASTPostBuild I saw that the validator was being called twice. My extension: {code:java} @Extension public class PostBuildValidator extends DeclarativeValidatorContributor { @CheckForNull @Override public String validateElement(@Nonnull ModelASTPostBuild postBuild, @CheckForNull FlowExecution execution) { return "abc" + postBuild.getName(); } } {code} My jenkinsfile: {code:java} pipeline { agent { label 'unix' } stages { stage('test'){ steps{ echo "test" } } } post { always{ echo "cleaning" deleteDir() } } } {code} Response from pipeline-model-converter/validateJenkinsfile: {"status":"ok","data":{"result":"failure","errors":[{"error":["abcpost @ line 12, column 3.","abcpost @ line 12, column 3."]}]}} |
I am hoping to extend the Declarative Model Validator to provide linting services that have the team's policies / standards integrated. Working on a validator for ModelASTPostBuild I saw that the validator was being called twice. My extension: {code:java} @Extension public class PostBuildValidator extends DeclarativeValidatorContributor { @CheckForNull @Override public String validateElement(@Nonnull ModelASTPostBuild postBuild, @CheckForNull FlowExecution execution) { return "abc" + postBuild.getName(); } } {code} My jenkinsfile: {code:java} pipeline { agent { label 'unix' } stages { stage('test'){ steps{ echo "test" } } } post { always{ echo "cleaning" deleteDir() } } } {code} Response from pipeline-model-converter/validateJenkinsfile: {"status":"ok","data":{"result":"failure","errors":[{"error":["abcpost @ line 12, column 3.","abcpost @ line 12, column 3."]}]}} |
| Status | Open [ 1 ] | In Progress [ 3 ] |
| Status | In Progress [ 3 ] | In Review [ 10005 ] |
| Remote Link | This issue links to "PR #213 (Web Link)" [ 17989 ] |
Finding the same behaviour for ModelASTOption validator, need a separate ticket?
Steven Foster
added a comment - Finding the same behaviour for ModelASTOption validator, need a separate ticket? The duplication is from public boolean validateElement(@Nonnull ModelASTMethodCall meth), I suppose that is intentional and I should just differentiate them somehow
Steven Foster
added a comment - The duplication is from public boolean validateElement(@Nonnull ModelASTMethodCall meth), I suppose that is intentional and I should just differentiate them somehow Nah, that’s on me, I’ll clean it up in the same PR.
And updated. Double checking now to make sure I don't have any other cases of super.validate calls like with ModelASTBuildConditionsContainer and ModelASTMethodCall that are double calling validateFromContributors...
Only other case was ModelASTTreeStep, which doesn't have its own validateElement method in the first place, so we should be all good.
Will be in next release (1.2.4).
| Resolution | Fixed [ 1 ] | |
| Status | In Review [ 10005 ] | Resolved [ 5 ] |
Code changed in jenkins
User: Andrew Bayer
Path:
pipeline-model-definition/src/main/groovy/org/jenkinsci/plugins/pipeline/modeldefinition/validator/ModelValidatorImpl.groovy
pipeline-model-definition/src/test/java/org/jenkinsci/plugins/pipeline/modeldefinition/ValidatorTest.java
pipeline-model-definition/src/test/resources/errors/postValidatorContributor.groovy
http://jenkins-ci.org/commit/pipeline-model-definition-plugin/f3d3486038c985a8f938f0f9da735c2839903dbd
Log:
[FIXED JENKINS-47814] Don't run post validator contirbutors twice
Bulk closing resolved issues.
| Status | Resolved [ 5 ] | Closed [ 6 ] |
Think I found it. Verifying now.