• Icon: New Feature New Feature
    • Resolution: Unresolved
    • Icon: Minor Minor
    • github-plugin
    • None

      The github-plugin currently supports PUSH events from Github only:

      https://github.com/jenkinsci/github-plugin/blob/78167fd8a507ada4382c961c65539f7e1d9ba054/src/main/java/org/jenkinsci/plugins/github/webhook/subscriber/DefaultPushGHEventSubscriber.java#L54-L60

      We'd like to be able to take action based on other events such as a release/tag being cut (X-GitHub-Event: create). We poked around a bit and see that there is an open PR to support additional events (https://github.com/jenkinsci/github-plugin/pull/54). Are there any plans to address the outstanding issues in the PR or add this feature, in general?

          [JENKINS-47938] Add Support for More Github Events

          This change requires massive rewrite of plugin, as it originally was not designed for variable events. But for now I have no time to do such great things as it requires to put a lot of efforts doing this in java7-way with lot of backward-compatibility steps to not break any existing installation after the upgrade. With my current focus on avoiding jenkins it exists in the tail of very long backlog. So if you can implement it as new trigger probably with java7 I can help with review and merge with pleasure. PR#54 breaks some binary compatibility and generally contains a lot of issues because of tightly-coupled to a specific case.

          Kirill Merkushev added a comment - This change requires massive rewrite of plugin, as it originally was not designed for variable events. But for now I have no time to do such great things as it requires to put a lot of efforts doing this in java7-way with lot of backward-compatibility steps to not break any existing installation after the upgrade. With my current focus on avoiding jenkins it exists in the tail of very long backlog. So if you can implement it as new trigger probably with java7 I can help with review and merge with pleasure. PR#54 breaks some binary compatibility and generally contains a lot of issues because of tightly-coupled to a specific case.

            lanwen Kirill Merkushev
            ryanfrantz Ryan Frantz
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: