Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48252

ATH for Blue Ocean Pull Requests tab

    XMLWordPrintable

Details

    • Blue Ocean - Candidates

    Description

      Summary:
      While researching test coverage related to JENKINS-47492, it was discovered that there are selenium test coverage gaps around the Pull Requests tab in Blue Ocean. This ticket is being opened to track the creation of such tests.

      Attachments

        Issue Links

          is related to

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-48198 "TypeError: Cannot read property 'toLowerCase' of undefined" for i18n title

          • Critical - Crashes, loss of data, severe memory leak.
          • Reopened

          Bug - A problem which impairs or prevents the functions of the product. JENKINS-47492 "TypeError: Cannot read property 'toLowerCase' of undefined" when trying to list PRs

          • Major - Major loss of function.
          • Closed

          Activity

            Ascending order - Click to sort in descending order
            kshultz Karl Shultz added a comment -

            Adding links to the two issues which spawned this one.

            kshultz Karl Shultz added a comment - Adding links to the two issues which spawned this one.
            kshultz Karl Shultz added a comment -

            The relevant bits from the testing notes for 47492 and 48198 read as follows:

            Testing Notes:

            • ...going forward, to have an automated UI test which verifies the correct function of the Pull Requests tab. There might be one, but I've not found it anywhere in here.
            • I've also not found any JS tests which target the PR tab, but that could be my lack of familiarity with those.
            kshultz Karl Shultz added a comment - The relevant bits from the testing notes for 47492 and 48198 read as follows: Testing Notes: ...going forward, to have an automated UI test which verifies the correct function of the Pull Requests tab. There might be one, but I've not found it anywhere in here . I've also not found any JS tests which target the PR tab, but that could be my lack of familiarity with those.
            vilacides Isa Vilacides added a comment -

            kshultz can you define the exact steps that you expect the test or tests to cover?

            vilacides Isa Vilacides added a comment - kshultz can you define the exact steps that you expect the test or tests to cover?
            kshultz Karl Shultz added a comment -

            I'd like to see a pretty standard pull request flow done. Doesn't need to be anything fancy, but maybe:

            1. To begin with, check to make sure the "You don't have any open pull requests" message shows up
            2. PR gets created in the testcase
            3. Blue Ocean picks up on it and starts a build
            4. Once completed, click through to the build and make sure it's there
            kshultz Karl Shultz added a comment - I'd like to see a pretty standard pull request flow done. Doesn't need to be anything fancy, but maybe: To begin with, check to make sure the "You don't have any open pull requests" message shows up PR gets created in the testcase Blue Ocean picks up on it and starts a build Once completed, click through to the build and make sure it's there
            kshultz Karl Shultz added a comment -

            Merged 1680.

            kshultz Karl Shultz added a comment - Merged 1680 .

            People

              kshultz Karl Shultz
              kshultz Karl Shultz
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: