[JENKINS-48288] Can't change primaryView after Folder is generated

Type: Bug
Resolution: Fixed
Priority: Minor
Component/s: job-dsl-plugin
Labels:
None

Similar Issues:
Powered by SuggestiMate

Show

As already discussed in https://groups.google.com/d/topic/job-dsl-plugin/hCOem65Gpa8/discussion:

Minmal example:

folder('foo') {
  primaryView 'bar'
}

listView("foo/bar") {
  jobs {
      regex '.*'
  }
}

This is probably the simplest example of a folder, an additional listView in that folder, which SHOULD be set as the primary view in that folder. It works in testcases, generates the correct XML and is correct when run on a "fresh" Jenkins.

When run on a Jenkins instance where 'foo' already exists, the primary view is not updated...

is related to

JENKINS-31308 Creating folder removes existing views within that

Open

Daniel Spilker added a comment - 2018-03-14 15:36 - edited

Will be fixed in Job DSL 1.69 which introduces new syntax to create the view a part of the folder:

folder('foo') {
  views {
    listView('bar') {
      jobs {
        regex('.*')
      }
    }
  }
  primaryView('bar')
}

PR: https://github.com/jenkinsci/job-dsl-plugin/pull/1114

Daniel Spilker added a comment - 2018-03-14 15:36 - edited Will be fixed in Job DSL 1.69 which introduces new syntax to create the view a part of the folder: folder( 'foo' ) { views { listView( 'bar' ) { jobs { regex( '.*' ) } } } primaryView( 'bar' ) } PR: https://github.com/jenkinsci/job-dsl-plugin/pull/1114

SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/Folder-5.14-template.xml
job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/FolderSpec.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/086f107a56c6c6c907e9f11698100c2ef5733cd8
Log:
allow to configure views as part of a folder

[FIXES JENKINS-48288]

SCM/JIRA link daemon added a comment - 2018-03-14 15:45 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/Folder-5.14-template.xml job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/FolderSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/086f107a56c6c6c907e9f11698100c2ef5733cd8 Log: allow to configure views as part of a folder [FIXES JENKINS-48288]

SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
docs/Migration.md
job-dsl-core/src/main/docs/examples/javaposse/jobdsl/dsl/Folder/views.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/Folder-5.14-template.xml
job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/FolderSpec.groovy
job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/5bcd1ef96593275531bf439b3f7f812d28ca4f9d
Log:
Merge pull request #1114 from daspilker/~~JENKINS-48288~~

~~JENKINS-48288~~ allow to configure views as part of a folder

Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/9f7792633d8e...5bcd1ef96593

SCM/JIRA link daemon added a comment - 2018-03-14 15:45 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-core/src/main/docs/examples/javaposse/jobdsl/dsl/Folder/views.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/Folder-5.14-template.xml job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/FolderSpec.groovy job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/5bcd1ef96593275531bf439b3f7f812d28ca4f9d Log: Merge pull request #1114 from daspilker/ JENKINS-48288 JENKINS-48288 allow to configure views as part of a folder Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/9f7792633d8e...5bcd1ef96593

SCM/JIRA link daemon added a comment - 2018-04-06 06:33

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
docs/Migration.md
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractFolder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ComputedFolder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob.groovy
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob-2.10-template.xml
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob-2.0.0-template.xml
job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/0bac030e0e932e53922e6228cadbbd9081de1c3c
Log:
follow-up for ~~JENKINS-48288~~ to fix multibranchPipelineJob and organizationFolder

SCM/JIRA link daemon added a comment - 2018-04-06 06:33 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractFolder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ComputedFolder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob.groovy job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob-2.10-template.xml job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob-2.0.0-template.xml job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/0bac030e0e932e53922e6228cadbbd9081de1c3c Log: follow-up for JENKINS-48288 to fix multibranchPipelineJob and organizationFolder

SCM/JIRA link daemon added a comment - 2018-04-06 06:33

Code changed in jenkins
User: Daniel Spilker
Path:
docs/Home.md
docs/Migration.md
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractFolder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ComputedFolder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob.groovy
job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob.groovy
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob-2.10-template.xml
job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob-2.0.0-template.xml
job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy
http://jenkins-ci.org/commit/job-dsl-plugin/c094cd7e82b6d91c39679e563562bd4e2584bd0d
Log:
Merge pull request #1120 from daspilker/~~JENKINS-48288~~

~~JENKINS-48288~~ fix multibranchPipelineJob and organizationFolder

Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/2b0a2202e53a...c094cd7e82b6

SCM/JIRA link daemon added a comment - 2018-04-06 06:33 Code changed in jenkins User: Daniel Spilker Path: docs/Home.md docs/Migration.md job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/AbstractFolder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/ComputedFolder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/Folder.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/JobParent.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob.groovy job-dsl-core/src/main/groovy/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob.groovy job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/MultibranchWorkflowJob-2.10-template.xml job-dsl-core/src/main/resources/javaposse/jobdsl/dsl/jobs/OrganizationFolderJob-2.0.0-template.xml job-dsl-core/src/test/groovy/javaposse/jobdsl/dsl/JobParentSpec.groovy http://jenkins-ci.org/commit/job-dsl-plugin/c094cd7e82b6d91c39679e563562bd4e2584bd0d Log: Merge pull request #1120 from daspilker/ JENKINS-48288 JENKINS-48288 fix multibranchPipelineJob and organizationFolder Compare: https://github.com/jenkinsci/job-dsl-plugin/compare/2b0a2202e53a...c094cd7e82b6

Jenkins

Details

Description

Attachments

Issue Links

Activity

Collapse comment: Daniel Spilker added a comment - 2018-03-14 15:36, Edited by Daniel Spilker - 2018-03-14 15:37

Expand comment: Daniel Spilker added a comment - 2018-03-14 15:36, Edited by Daniel Spilker - 2018-03-14 15:37

Collapse comment: SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Expand comment: SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Collapse comment: SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Expand comment: SCM/JIRA link daemon added a comment - 2018-03-14 15:45

Collapse comment: SCM/JIRA link daemon added a comment - 2018-04-06 06:33

Expand comment: SCM/JIRA link daemon added a comment - 2018-04-06 06:33

Collapse comment: SCM/JIRA link daemon added a comment - 2018-04-06 06:33

Expand comment: SCM/JIRA link daemon added a comment - 2018-04-06 06:33

People

Dates