[JENKINS-48348] If task can be run only on master, use shortcut

        Oleg Nenashev added a comment -

        It has been integrated towards 2.93

        Oleg Nenashev added a comment - It has been integrated towards 2.93

        Daniel Beck added a comment -

        I point out a possible regression in very unusual label setups in a recent PR comment. No opinion re LTS fitness.

        Daniel Beck added a comment - I point out a possible regression in very unusual label setups in a recent PR comment. No opinion re LTS fitness.

        Code changed in jenkins
        User: Alexander Akbashev
        Path:
        core/src/main/java/hudson/model/Queue.java
        http://jenkins-ci.org/commit/jenkins/eb41a7bb0a58474a0fc627ca1cb8f2002ad26b47
        Log:
        JENKINS-48348 If task can be run only on master, use shortcut

        Currently Jenkins to fire WorkflowJob re-calculates the ConstistentHash
        for entire cluster even if there is no nodes were updated. If cluster is
        big enough (>100 nodes), it becomes a problem, because MD5 is quite
        expensive itself plus all this logic comes with high memory footprint.

        Using the knowledge that WorkflowJob can be executed only on Jenkins master,
        we can create a shortcut that does not do expensive calculation and just
        returns Runnable or `null`.

        (cherry picked from commit 00ccd23f6441a55bfd625660911d4bc79c7578ba)

        SCM/JIRA link daemon added a comment - Code changed in jenkins User: Alexander Akbashev Path: core/src/main/java/hudson/model/Queue.java http://jenkins-ci.org/commit/jenkins/eb41a7bb0a58474a0fc627ca1cb8f2002ad26b47 Log: JENKINS-48348 If task can be run only on master, use shortcut Currently Jenkins to fire WorkflowJob re-calculates the ConstistentHash for entire cluster even if there is no nodes were updated. If cluster is big enough (>100 nodes), it becomes a problem, because MD5 is quite expensive itself plus all this logic comes with high memory footprint. Using the knowledge that WorkflowJob can be executed only on Jenkins master, we can create a shortcut that does not do expensive calculation and just returns Runnable or `null`. (cherry picked from commit 00ccd23f6441a55bfd625660911d4bc79c7578ba)

          oleg_nenashev Oleg Nenashev
          jimilian Alexander A
          Votes:
          0 Vote for this issue
          Watchers:
          3 Start watching this issue

            Created:
            Updated:
            Resolved: