Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48387

No job should be taken as a reference if it is triggered by Gerrit

    XMLWordPrintable

Details

    Description

      The plugin is configured the following way:

      • 'Compute new warnings' is activated
      • 'Only use stable builds as reference' is activated

      The behaviour of the plugin is incorrect when following development workflow is used:

      • developer A uploads a change 'a', patch set 1 to Gerrit that fixes N warnings.
      • the job for PS1 passes in Jenkins, since we have less warnings, and this build becomes the new reference
      • developer A upload for change 'a' a patch set 2 to Gerrit where the initial N warnings are present again (he had removed them by 'mistake').
      • the job for PS2 fails, since it refers to PS1 as a reference

       

      In general, the same effect can be seen in various combinations: developer A and developer B upload at roughly the same time and can be blocked since e.g. developer B's job will reference non yet merged change of developer A.

      An option should be added so that no passing build that has GERRIT_CHANGE_NUMBER parameter (or similar) is taken as a reference.

      Attachments

        Issue Links

          Activity

            drulli Ulli Hafner added a comment -

            This is already possible: set checkbox 'Use previous build as reference'.

            drulli Ulli Hafner added a comment - This is already possible: set checkbox 'Use previous build as reference'.
            chantivlad chanti vlad added a comment -

            Well the closing was fast 

            PLease see my updated description.

            chantivlad chanti vlad added a comment - Well the closing was fast  PLease see my updated description.
            drulli Ulli Hafner added a comment -

            Can you please check if this is different from JENKINS-13056?

            drulli Ulli Hafner added a comment - Can you please check if this is different from JENKINS-13056 ?
            chantivlad chanti vlad added a comment -

            Yes this sounds about right. Thanks for the pointer, i did not find this similar issue in my search.

            chantivlad chanti vlad added a comment - Yes this sounds about right. Thanks for the pointer, i did not find this similar issue in my search.

            People

              drulli Ulli Hafner
              chantivlad chanti vlad
              Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

                Created:
                Updated:
                Resolved: