Uploaded image for project: 'Jenkins'
  1. Jenkins
  2. JENKINS-48536

Organization folder does not call afterSave on child multibranch projects

XMLWordPrintable

    • Icon: Bug Bug
    • Resolution: Unresolved
    • Icon: Minor Minor
    • branch-api-plugin
    • None

      Found by rsandell

      Because afterSave() is only called from the doSubmit method it will never be called for multibranch projects in an org folder (which is wrong)

          [JENKINS-48536] Organization folder does not call afterSave on child multibranch projects

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          pom.xml
          src/test/java/integration/EventsTest.java
          http://jenkins-ci.org/commit/branch-api-plugin/d267982f1aab13274e09519529b274ee51e3652a
          Log:
          JENKINS-48536 Add test case

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: pom.xml src/test/java/integration/EventsTest.java http://jenkins-ci.org/commit/branch-api-plugin/d267982f1aab13274e09519529b274ee51e3652a Log: JENKINS-48536 Add test case

          SCM/JIRA link daemon added a comment -

          Code changed in jenkins
          User: Stephen Connolly
          Path:
          src/main/java/jenkins/branch/MultiBranchProject.java
          src/main/java/jenkins/branch/OrganizationFolder.java
          http://jenkins-ci.org/commit/branch-api-plugin/d4f20e4121c1f95a6ea3731e7306de6f841650f6
          Log:
          [FIXED JENKINS-48536] OrganizationFolder should ensure MultibranchProject calls SCMSource.afterSave()

          SCM/JIRA link daemon added a comment - Code changed in jenkins User: Stephen Connolly Path: src/main/java/jenkins/branch/MultiBranchProject.java src/main/java/jenkins/branch/OrganizationFolder.java http://jenkins-ci.org/commit/branch-api-plugin/d4f20e4121c1f95a6ea3731e7306de6f841650f6 Log: [FIXED JENKINS-48536] OrganizationFolder should ensure MultibranchProject calls SCMSource.afterSave()

          Stephen Connolly added a comment -

          Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

          Stephen Connolly added a comment - Removing myself as assignee. My current work assignments do not provide sufficient bandwidth to review these issues and in the majority of cases I am only assigned by virtue of being the default assignee. For the credentials-api and scm-api related plugins I have permission to allocate time reviewing changes to these APIs themselves to ensure these APIs remain cohesive, but that can be handled through PR reviews rather than assigning issues in JIRA

            Unassigned Unassigned
            stephenconnolly Stephen Connolly
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated: