The unit tests of master branch of PCT are failing due to:

       

      -------------------------------------------------------------------------------
      Test set: org.jenkins.tools.test.PluginCompatTesterTest
      -------------------------------------------------------------------------------
      Tests run: 2, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 4.997 sec <<< FAILURE!
      testWithUrl(org.jenkins.tools.test.PluginCompatTesterTest) Time elapsed: 4.87 sec <<< ERROR!
      com.thoughtworks.xstream.converters.ConversionException: TreeMap does not contain <comparator> element
      ---- Debugging information ----
      class : org.jenkins.tools.test.model.PluginCompatReport
      required-type : java.util.TreeMap
      line number : 5
      -------------------------------
      at com.thoughtworks.xstream.converters.collections.TreeMapConverter.unmarshal(TreeMapConverter.java:77)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:82)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:76)
      at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unmarshallField(AbstractReflectionConverter.java:246)
      at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.doUnmarshal(AbstractReflectionConverter.java:218)
      at com.thoughtworks.xstream.converters.reflection.AbstractReflectionConverter.unmarshal(AbstractReflectionConverter.java:162)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.convert(TreeUnmarshaller.java:82)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:76)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.convertAnother(TreeUnmarshaller.java:60)
      at com.thoughtworks.xstream.core.TreeUnmarshaller.start(TreeUnmarshaller.java:137)
      at com.thoughtworks.xstream.core.AbstractTreeMarshallingStrategy.unmarshal(AbstractTreeMarshallingStrategy.java:33)
      at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:926)
      at com.thoughtworks.xstream.XStream.unmarshal(XStream.java:912)
      at com.thoughtworks.xstream.XStream.fromXML(XStream.java:864)
      at org.jenkins.tools.test.model.PluginCompatReport.fromXml(PluginCompatReport.java:142)
      at org.jenkins.tools.test.PluginCompatTester.testPlugins(PluginCompatTester.java:178)
      at org.jenkins.tools.test.PluginCompatTesterTest.testWithUrl(PluginCompatTesterTest.java:80)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:498)
      at org.junit.runners.model.FrameworkMethod$1.runReflectiveCall(FrameworkMethod.java:44)
      at org.junit.internal.runners.model.ReflectiveCallable.run(ReflectiveCallable.java:15)
      at org.junit.runners.model.FrameworkMethod.invokeExplosively(FrameworkMethod.java:41)
      at org.junit.internal.runners.statements.InvokeMethod.evaluate(InvokeMethod.java:20)
      at org.junit.internal.runners.statements.RunBefores.evaluate(RunBefores.java:28)
      at org.junit.internal.runners.statements.RunAfters.evaluate(RunAfters.java:31)
      at org.junit.rules.ExternalResource$1.evaluate(ExternalResource.java:43)
      at org.junit.runners.BlockJUnit4ClassRunner.runNotIgnored(BlockJUnit4ClassRunner.java:79)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:71)
      at org.junit.runners.BlockJUnit4ClassRunner.runChild(BlockJUnit4ClassRunner.java:49)
      at org.junit.runners.ParentRunner$3.run(ParentRunner.java:193)
      at org.junit.runners.ParentRunner$1.schedule(ParentRunner.java:52)
      at org.junit.runners.ParentRunner.runChildren(ParentRunner.java:191)
      at org.junit.runners.ParentRunner.access$000(ParentRunner.java:42)
      at org.junit.runners.ParentRunner$2.evaluate(ParentRunner.java:184)
      at org.junit.runners.ParentRunner.run(ParentRunner.java:236)
      at org.apache.maven.surefire.junit4.JUnit4TestSet.execute(JUnit4TestSet.java:53)
      at org.apache.maven.surefire.junit4.JUnit4Provider.executeTestSet(JUnit4Provider.java:119)
      at org.apache.maven.surefire.junit4.JUnit4Provider.invoke(JUnit4Provider.java:101)
      at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
      at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
      at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
      at java.lang.reflect.Method.invoke(Method.java:498)
      at org.apache.maven.surefire.booter.ProviderFactory$ClassLoaderProxy.invoke(ProviderFactory.java:103)
      at com.sun.proxy.$Proxy0.invoke(Unknown Source)
      at org.apache.maven.surefire.booter.SurefireStarter.invokeProvider(SurefireStarter.java:150)
      at org.apache.maven.surefire.booter.SurefireStarter.runSuitesInProcess(SurefireStarter.java:91)
      at org.apache.maven.surefire.booter.ForkedBooter.main(ForkedBooter.java:69)
      

       

      To reproduce:

       

      mvn clean install

          [JENKINS-48741] PCT unit tests are failing

          Oleg Nenashev added a comment -

          rarabaolaza dnusbaum maybe we should merge https://github.com/jenkinsci/plugin-compat-tester/pull/54 and try again. The tests are passing locally with that PR

          Oleg Nenashev added a comment - rarabaolaza dnusbaum maybe we should merge https://github.com/jenkinsci/plugin-compat-tester/pull/54 and try again. The tests are passing locally with that PR

          oleg_nenashev dnusbaum I have approved #54 but it seems jglick has requested itself as a reviewer. Should we wait for him?

          Raul Arabaolaza added a comment - oleg_nenashev dnusbaum I have approved #54 but it seems jglick has requested itself as a reviewer. Should we wait for him?

          Oleg Nenashev added a comment -

          2 approvals are fine. If jglick wants me to make more changes, I will do them in follow-up PRs. PCT is not a production component, and there is no plan to release the new version so far

          Oleg Nenashev added a comment - 2 approvals are fine. If jglick wants me to make more changes, I will do them in follow-up PRs. PCT is not a production component, and there is no plan to release the new version so far

          Fine for me

          Raul Arabaolaza added a comment - Fine for me

          Oleg Nenashev added a comment -

          Resolved by JENKINS-48723

          Oleg Nenashev added a comment - Resolved by  JENKINS-48723

            oleg_nenashev Oleg Nenashev
            rarabaolaza Raul Arabaolaza
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Created:
              Updated:
              Resolved: